From: Alexei S. <ale...@gm...> - 2012-07-01 02:28:04
|
Thanks. I've landed this now (after cleaning up some of the code formatting). I've split this into two commits, the first one renaming the file to have the .mm extension: https://github.com/cebix/macemu/commit/3fc0e4dd98c69c39240d061513acddd7dadbc18b And the second one containing your code changes: https://github.com/cebix/macemu/commit/ed28705ee3c2ff1c382b62d638b20b7fd96e85cd Thanks again! -Alexei On Sat, Jun 30, 2012 at 5:50 PM, Charles Srstka < bas...@ch...> wrote: > On Jun 30, 2012, at 3:00 PM, Alexei Svitkine wrote: > > > At a quick glance the changes look good. > > > > Do you mind fixing up the style so its consistent throughout? (i.e. > making sure indentation is consistent and adding a space after the "if" in > if statements - right now some have it and others don't.) > > > > Then, we can land it in the upstream repository. > > > > -Alexei > > I just talked to Ronald after sending him a SheepShaver build made from > applying the patch directly to the source from github, and he says it’s > working properly on his machine now, so here’s the revised patch: > > > > > Thanks, > Charles > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > > |