Re: [B2-devel] [PATCH] Patch for copying and pasting styled text in Basilisk II / SheepShaver

[Charles S. <bas...@ch...>]

On Jun 30, 2012, at 3:00 PM, Alexei Svitkine wrote:

> At a quick glance the changes look good.
> 
> Do you mind fixing up the style so its consistent throughout? (i.e. making sure indentation is consistent and adding a space after the "if" in if statements - right now some have it and others don't.)
> 
> Then, we can land it in the upstream repository.
> 
> -Alexei

Ah, sorry about that! I noticed that the existing code didn’t use a space before the parens for function calls, and I used the same style for the if statements. Also, Xcode’s automatic indentation likes to use spaces, whereas I see that the existing code was using tabs. I’ve fixed all this.

I think I’ll hold off on sending the revised patch until I hear back from Ronald and see if I can find out what’s causing what he’s seeing.

Charles