Re: [B2-devel] [PATCH] Patch for copying and pasting styled text in Basilisk II / SheepShaver

[Ronald P. R. <ron...@xs...>]

Core 2 Duo iMac, 10.7.4 (64-bit Kernel and Extensions), SheepShaver with your patch running in 64-bit mode:

SimpleText (SheepShaver) -> TextEdit (host)
Only plain text arrives (with incorrect accented characters)

TextEdit (host) -> SimpleText (SheepShaver)
Only plain text arrives (with correct accented characters)

Tex-Edit Plus 3.0.2 (SheepShaver) -> TextEdit (host)
Only plain text arrives (with incorrect accented characters)

TextEdit(host) -> Tex-Edit Plus 3.0.2 (SheepShaver)
Only plain text arrives (with correct accented characters)


I repeated with a previous (June 22, 2012) SheepShaver build, also in 64-bit mode, and the results are exactly the same.

I see no difference at all between the two builds with regard to copying styled text.

Could Howard have applied the patch incorrectly?

Ronald.


Op 30 jun. 2012, om 21:08 heeft Charles Srstka het volgende geschreven:

> I don’t have a version of AppleWorks that works in Classic, and I haven’t been able to get Word to start up in SheepShaver, but I’ve tried the following combinations, and all seem to work:
> 
> SimpleText (SheepShaver) -> TextEdit (host)
> TextEdit (host) -> SimpleText (SheepShaver)
> Tex-Edit 4.1.3 (SheepShaver) -> TextEdit (host)
> TextEdit(host) -> Tex-Edit 4.1.3 (SheepShaver)
> 
> All seem to work on my machine (MBP, 10.7.4, 64-bit).
> 
> One thing to note is that all the changes I made went into the 64-bit clipboard code. This is because I anticipate that this code will probably end up eventually replacing the 32-bit code outright, so there’s no real point in working on the 32-bit code. Make sure you’re running in 64-bit mode.
> 
> If it’s still not working for you, would it be okay to send me your patched version of the code, so that I can see if I accidentally left anything out of the patch?
> 
> Thanks,
> Charles
> 
> On Jun 30, 2012, at 1:53 PM, Ronald P. Regensburg wrote:
> 
>> Howard Spoelstra (Cat_7 in Emaculation) applied your patch to the latest git version and built a SheepShaver.app from it that he sent to me to try.
>> 
>> Maybe copying styled text should work with some specific applications? I could not make it work either way with the applications I tried: From Word and TextEdit in OSX nothing appeared on the MacOS clipboard, from AppleWorks in MacOS nothing appeared on the OSX clipboard and from Tex-Edit Plus in MacOS only plain text appeared on the OSX clipboard.
>> 
>> The problem with accented characters while copying plain text from MacOS to OSX in 64-bit mode is not solved.
>> 
>> (This build also has the earlier reported problem of not being able to mount CD-ROMs.)
>> 
>> (The recent patch that prevents disk images to be mounted in OSX and SheepShaver at the same time seems to work both ways.)
>> 
>> Ronald.
>> 
>> 
>> Op 30 jun. 2012, om 03:22 heeft Charles Srstka het volgende geschreven:
>> 
>>> Added code to parse the Classic Mac OS 'styl' resources, allowing formatted text to be copied and pasted out of SheepShaver, not just plain text. In order to do this, I made some changes to the emul_op mechanism, patching ZeroScrap() in addition to the scrap methods that were already being patched. The reason for this is that since we need to read data from multiple items that are on the clipboard at once, we cannot simply assume a zero at the beginning of each PutScrap() operation.
>>> 
>>> This patch uses RTF to store styled text on the host side; unfortunately, since the APIs to convert to and from RTF data are in Cocoa but not in CoreFoundation, I had to write the new portions in Objective-C rather than C, and changed the extension from .cpp to .mm accordingly. In the future, if we are confident that this file will only be used on Mac OS X 10.6 and up, we can rewrite the Pasteboard Manager code to use NSPasteboardReading/Writing instead. This would allow us to read and write NSAttributedString objects directly to and from the pasteboard, which would make sure we were always using the OS's preferred rich text format internally instead of hard-coding it specifically to RTF as in the current implementation.
>>> 
>>> I believe that this patch should also fix the problem Ronald reported with copying accented characters.
>>> 
>>> Since I am new to 68k assembly and the emul_op mechanism, I would appreciate if someone could double-check all my changes to make sure that I have done everything correctly.
>>> 
>>> Thanks,
>>> Charles
>>> 
>