Re: [B2-devel] TESyncScrap (Thoughts on SheepShaver and Basilisk II)

[Alexei S. <ale...@gm...>]

On Mon, Jun 18, 2012 at 3:50 PM, Jean-Pierre <cho...@fr...> wrote:

> Here you are.
>
> It's still incomplete, but it could be a good start for sharing pictures
> as well.
>
> Best regards,
>

Hey,

Nice work!

Would you be willing to clean up the patch a little and re-send it (on a
separate thread or via GitHub) for inclusion upstream?

Here are some of my thoughts on a couple of things that could be cleaned up:

  - indentation is inconsistent throughout
  - _CARBON_BUILD_ stuff: I understand that the purpose is to have separate
the two codepaths - but my question is: Is there anything preventing
switching completely to the new path that you've implemented? If it has
feature parity with the old code, we don't need to keep the old code around.

I'm looking forward to landing these changes upstream.

Thanks!

-Alexei