[B2-devel] Leggo my Eggo! (The CD-ROM eject fix)

[Robert M. <mr...@gm...>]

Hi Alexei,

Thank you for checking my work. I am glad to hear that the change can
go in sys_darwin.cpp because that makes more sense to me too.

I was starting to think that SysMediaArrived() was Darwin-only. I
searched all the code to find other references to it, and only found
the one in sys_windows.cpp (it seems to be used by video_sdl.cpp in
WIN32, but why?).

But this would mean that SysMediaArrived() should be in
sys_darwin.cpp, not sys_unix.cpp, right? (I am not suggesting that we
change it, because I realize there is a lot of lost knowledge about
the BasiliskII design... but this is why I made a wild guess that
perhaps this bug might have also affected Linux.)

- Robert

On 2012-04-21, Alexei Svitkine <ale...@gm...> wrote:
> Thanks for your investigation!
>
> I've looked at the code and decided to go with the solution of not
> even starting the media_thread when "nocdrom" is set, since
> the media_thread is only used to scan for CDs in the current
> code.
>
> This way, the emulator is won't be doing useless work when that
> pref is set. As for your concern of whether other Unixes are affected
> by the bug, it actually looks like the only caller of SysMediaArrived()
> in sys_unix.cpp is the code in sys_darwin.cpp, so the issue only
> affected the Darwin version.
>
> I've committed the change to CVS. Thanks again!
>
> -Alexei

-- 
  Robert Munafo  --  mrob.com
  Follow me at: gplus.to/mrob - fb.com/mrob27 - twitter.com/mrob_27 -
mrob27.wordpress.com - youtube.com/user/mrob143 - rilybot.blogspot.com