Re: [B2-devel] bin/cue files

[Alexei S. <ale...@gm...>]

Some comments:

1.

"Includes ideas, even code fragments, from dosbox and libcdio hence
must obey those licences"

What are their licenses?

2.

Please use a consistent brace/indentation style as the rest of the
SheepShaver / Basilisk II codebases. Currently your code mixes and
matches tabs and space (the existing codebase is standardised on tabs)
and uses a different brace style then the rest of the code.

3.

In audio_sdl.cpp, please include the relevant header instead of
declaring extern functions right before calling it.

4.

Please update your CVS - the video_blit.cpp change already exists in trunk.

Cheers,

-Alexei

On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote:
> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine
> <ale...@gm...> wrote:
>> If by svn, you mean cvs, then you've more or less got it. ;)
>>
>> I suggest passing in -u to the diff command to get a unified diff
>> (easier to read). Also, if your changes involve modification to files
>> in both Basilisk and SheepShaver trees, you need to create two
>> patches, one from each tree.
>>
>> Cheers,
>>
>> -Alexei
>>
>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote:
>>> Sure.  I need a little handholding on making the diffs.
>>> Did you have in mind something like the following ?
>>>
>>> 1) I checkout a clean svn snapshot
>>> 2) make my changes
>>> 3) svn diff
>>>
>>> Geoffrey
>>>
>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine
>>> <ale...@gm...> wrote:
>>>> Can you make a patch of the changes (using diff) rather than a tar.gz
>>>> of the files?
>>>>
>>>> -Alexei
>>>>
>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote:
>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support
>>>>> for bin/cue files specifically to enable the use of (images of) mixed
>>>>> digital/audio cdroms.
>>>>>
>>>>> It's been suggested on the SheepShaver forum that I post those files
>>>>> here.  Is it
>>>>> appropriate to attach a tar.gz file to this list ?   If that's
>>>>> inappropriate, is there
>>>>> somebody who would like to catch these files, possibly for checkin to
>>>>> the cvs repository ?
>>>>>
>>>>> In SheepShaver, SDL audio and OS X core audio work and have been
>>>>> tested on linux and OS X.
>>>>> In Basilisk SDL audio works and has been tested on linux.
>>>>>
>>>>> The only bin/cue files my code supports are ones with a single binary
>>>>> and 2532 tracks (audio and raw
>>>>> data).  There are other limitations, but those are the key ones.
>>>>>
>>>>> Geoffrey Brown
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> Start uncovering the many advantages of virtual appliances
>>>>> and start using them to simplify application deployment and
>>>>> accelerate your shift to cloud computing.
>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>> _______________________________________________
>>>>> basilisk-devel mailing list
>>>>> bas...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Start uncovering the many advantages of virtual appliances
>>>> and start using them to simplify application deployment and
>>>> accelerate your shift to cloud computing.
>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>> _______________________________________________
>>>> basilisk-devel mailing list
>>>> bas...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Start uncovering the many advantages of virtual appliances
>>> and start using them to simplify application deployment and
>>> accelerate your shift to cloud computing.
>>> http://p.sf.net/sfu/novell-sfdev2dev
>>> _______________________________________________
>>> basilisk-devel mailing list
>>> bas...@li...
>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>>>
>>
>> ------------------------------------------------------------------------------
>> Start uncovering the many advantages of virtual appliances
>> and start using them to simplify application deployment and
>> accelerate your shift to cloud computing.
>> http://p.sf.net/sfu/novell-sfdev2dev
>> _______________________________________________
>> basilisk-devel mailing list
>> bas...@li...
>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>>
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> basilisk-devel mailing list
> bas...@li...
> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>
>