Re: [B2-devel] Better patch: subprocess as serial port

[Brian J. <bjj...@us...>]

--- Christian Bauer <cb...@th...> wrote:
>
> On Wed, Jul 24, 2002 at 03:39:25PM -0500, Brian Johnson wrote:
> > Here's an improved version of my subprocess-as-serial-port patch.
>
> Impressive. I can now edit B2 source files from within the emulation
> using ZTerm. :-)

So, there's no reason ever to leave full-screen mode....

> ...
> > Suggestions and fixes are most welcome.
>
> I had to add the line
>
>   #define debug(x) ;
>
> after the #include "strlcpy.h" at the beginning of sshpty.c to make
> the linker stop complaining about the missing debug() function.

OK.  Not sure why I didn't run into that....

> Apart from that it seems to work fine. I also took the liberty of
> modifying the kSERDBaudRate selector function to set the actual baud
> rate with cfset[io]speed(), instead of 115200 baud regardless of the
> actual requested rate. :-)
>
> Do you consider this to be CVS-ready?

Sure, if you do.  Could you add a note to the documentation saying how
to use it, while you're at it?  Or would you like me to?

I did notice that if I open and close the serial port a couple times,
BII crashes with a bad reference of some sort.  (I'm using MacOS
7.5.5, running a shell under ClarisWorks 2.1's Comm. Toolbox-based
terminal emulator, quitting ClarisWorks between the opens.)  But I was
never able to use the serial ports at all before making my changes, so
I'm not sure if I caused it or not.

						Brian

--------------------------------------------------------------------

   Q:  How many Microsoft programmers does it take to change a lightbulb?
   A:  None.  They don't bother.  They simply change the standard
       to darkness.
                                           -- Shad Aumann