basilisk-devel

[B2-devel] dyngen.c patch for mach-o x86_64

[Jean-Pierre <cho...@fr...>]

Hi,

I continue my monologue...

Here's a more complete patch for dyngen.c.
This version correctly deals with mach-o 64-bit object files built by  
gcc-4.2.1 as well as gcc-4.0.

Note that there's actually a bug in Apple's gcc 4.2.1 which seems to  
ignore the -fomit-frame-pointer for 64 bit x86_64 code.
i.e.:

With gcc-4.0, the following tiny source code:

	// tst.cpp
	register unsigned int *A0 asm("ebx");
	
	void op_mov_ad_A0_im(void)
	{
		asm volatile ("movabsq $___op_A0,%0" : "=r" (A0));
	}

compiled using:

	gcc-4.0 -arch x86_64 -fomit-frame-pointer -c tst.cpp

produces this otool result:

	tst.o:
	(__TEXT,__text) section
	__Z15op_mov_ad_A0_imv:
	0000000000000000	movq	$0x0000000000000000,%rbx
	000000000000000a	ret

But when compiled using gcc-4.2.1 from Snow Leopard:

	gcc -arch x86_64 -fomit-frame-pointer -c tst.cpp

produces this otool result:

	tst.o:
	(__TEXT,__text) section
	__Z15op_mov_ad_A0_imv:
	0000000000000000	pushq	%rbx
	0000000000000001	movq	$0x0000000000000000,%rbx
	000000000000000b	popq	%rbx
	000000000000000c	ret

my gcc version: i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc.  
build 5646) (dot 1)

I filed a bug at Apple about this.

I also have a few other patches available:
One for clip_macosx.cpp to deal with ne new Pasteboard functions since  
GetCurrentScrap/PutScrapFlavor etc.. have disappeared in Snow  
Leopard's APIs.
One for video_blit.cpp to accept the new GBRA format returned by the  
latest SLD-1.2.14, and a patch for this SDL to remove a memory leak  
(bug filed at libsdl.org).
Let me know if you want them or if you don't care...

Regards,

  - Jean-Pierre.

Re: [B2-devel] dyngen.c patch for mach-o x86_64

[Alexei S. <ale...@gm...>]

Hi Jean-Pierre,

I've committed a previous version of your patch with some modifications.

Please patch your latest changes into the current version in CVS and
re-send the patch.

Also, you should send the other patches to this list as separate
threads and we can discuss them if necessary.

Thanks.

-Alexei

On Tue, Nov 3, 2009 at 6:26 AM, Jean-Pierre <cho...@fr...> wrote:
> Hi,
>
> I continue my monologue...
>
> Here's a more complete patch for dyngen.c.
> This version correctly deals with mach-o 64-bit object files built by
> gcc-4.2.1 as well as gcc-4.0.
>
> Note that there's actually a bug in Apple's gcc 4.2.1 which seems to ignore
> the -fomit-frame-pointer for 64 bit x86_64 code.
> i.e.:
>
> With gcc-4.0, the following tiny source code:
>
>        // tst.cpp
>        register unsigned int *A0 asm("ebx");
>
>        void op_mov_ad_A0_im(void)
>        {
>                asm volatile ("movabsq $___op_A0,%0" : "=r" (A0));
>        }
>
> compiled using:
>
>        gcc-4.0 -arch x86_64 -fomit-frame-pointer -c tst.cpp
>
> produces this otool result:
>
>        tst.o:
>        (__TEXT,__text) section
>        __Z15op_mov_ad_A0_imv:
>        0000000000000000        movq    $0x0000000000000000,%rbx
>        000000000000000a        ret
>
> But when compiled using gcc-4.2.1 from Snow Leopard:
>
>        gcc -arch x86_64 -fomit-frame-pointer -c tst.cpp
>
> produces this otool result:
>
>        tst.o:
>        (__TEXT,__text) section
>        __Z15op_mov_ad_A0_imv:
>        0000000000000000        pushq   %rbx
>        0000000000000001        movq    $0x0000000000000000,%rbx
>        000000000000000b        popq    %rbx
>        000000000000000c        ret
>
> my gcc version: i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build
> 5646) (dot 1)
>
> I filed a bug at Apple about this.
>
> I also have a few other patches available:
> One for clip_macosx.cpp to deal with ne new Pasteboard functions since
> GetCurrentScrap/PutScrapFlavor etc.. have disappeared in Snow Leopard's
> APIs.
> One for video_blit.cpp to accept the new GBRA format returned by the latest
> SLD-1.2.14, and a patch for this SDL to remove a memory leak (bug filed at
> libsdl.org).
> Let me know if you want them or if you don't care...
>
> Regards,
>
>  - Jean-Pierre.
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus
> on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> basilisk-devel mailing list
> bas...@li...
> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>
>

[B2-devel] clip_macosx.cpp patch for x86_64

[Jean-Pierre <cho...@fr...>]

Hi again Alexei,

Le 11 nov. 2009 à 20:52, Alexei Svitkine a écrit :

> Also, you should send the other patches to this list as separate
> threads and we can discuss them if necessary.

Here's a patch for clip_macosx.cpp to use the new PasteBoard functions instead of the Scrap.
I didn't find a way to convert the 'styl' resource which is lost for now...
It also adds an attempt to convert text to/from utf-16 between hosts using the current text encoding on the Mac  - untested.

Best regards,

- Jean-Pierre.

Re: [B2-devel] dyngen.c patch for mach-o x86_64

[Jean-Pierre <cho...@fr...>]

Hi Alexei,

Le 11 nov. 2009 à 20:52, Alexei Svitkine a écrit :

> Hi Jean-Pierre,
> 
> I've committed a previous version of your patch with some modifications.
> 
> Please patch your latest changes into the current version in CVS and
> re-send the patch.

Here it is.

Best regards,

 - Jean-Pierre.

Re: [B2-devel] dyngen.c patch for mach-o x86_64

[Jean-Pierre <cho...@fr...>]

Hi Alexei,

Here's one more patch for lowmem.c to complete the x86_64 changes, as the previous version couldn't deal with 64-bit binaries.

Best regards,

 - Jean-Pierre.

Re: [B2-devel] dyngen.c patch for mach-o x86_64

[Alexei S. <ale...@gm...>]

Committed with the formatting changes. In the future, please try to
avoid mixing tabs and spaces.

Thanks.

-Alexei

On Thu, Nov 12, 2009 at 4:52 AM, Jean-Pierre <cho...@fr...> wrote:
> Hi Alexei,
>
> Here's one more patch for lowmem.c to complete the x86_64 changes, as the previous version couldn't deal with 64-bit binaries.
>
> Best regards,
>
>  - Jean-Pierre.
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> basilisk-devel mailing list
> bas...@li...
> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>
>

Re: [B2-devel] dyngen.c patch for mach-o x86_64

[Jean-Pierre <cho...@fr...>]

Le 13 nov. 2009 à 02:58, Alexei Svitkine a écrit :

> Committed with the formatting changes. In the future, please try to
> avoid mixing tabs and spaces.

Well, my editor is set up for Python, for which tabs are not a good idea.

I left a bug in dyngen.c, there's a variable declared "local16", but  "local" is used instead.

Best regards,

 - Jean-Pierre.

Re: [B2-devel] dyngen.c patch for mach-o x86_64

[Alexei S. <ale...@gm...>]

Committed fix for the variable name mismatch.

-Alexei

On Fri, Nov 13, 2009 at 3:06 AM, Jean-Pierre <cho...@fr...> wrote:
>
> Le 13 nov. 2009 à 02:58, Alexei Svitkine a écrit :
>
>> Committed with the formatting changes. In the future, please try to
>> avoid mixing tabs and spaces.
>
> Well, my editor is set up for Python, for which tabs are not a good idea.
>
> I left a bug in dyngen.c, there's a variable declared "local16", but  "local" is used instead.
>
> Best regards,
>
>  - Jean-Pierre.
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> basilisk-devel mailing list
> bas...@li...
> https://lists.sourceforge.net/lists/listinfo/basilisk-devel
>