Menu
▾
▴
basilisk-devel — Basilisk II development-related discussion
You can subscribe to this list here.
| 2000 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
(13) |
Sep
(42) |
Oct
(17) |
Nov
(7) |
Dec
(14) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2001 |
Jan
(14) |
Feb
(8) |
Mar
(13) |
Apr
(10) |
May
(28) |
Jun
(28) |
Jul
(23) |
Aug
(7) |
Sep
(2) |
Oct
(24) |
Nov
(9) |
Dec
(2) |
| 2002 |
Jan
(58) |
Feb
(15) |
Mar
(57) |
Apr
(26) |
May
(7) |
Jun
|
Jul
(10) |
Aug
|
Sep
(19) |
Oct
(9) |
Nov
(6) |
Dec
(4) |
| 2003 |
Jan
(4) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(14) |
Jun
(3) |
Jul
(7) |
Aug
(4) |
Sep
(7) |
Oct
(4) |
Nov
(11) |
Dec
(3) |
| 2004 |
Jan
(32) |
Feb
(21) |
Mar
(3) |
Apr
(11) |
May
(33) |
Jun
(42) |
Jul
(46) |
Aug
(2) |
Sep
(3) |
Oct
|
Nov
(42) |
Dec
(23) |
| 2005 |
Jan
(5) |
Feb
(2) |
Mar
(12) |
Apr
(26) |
May
(8) |
Jun
(18) |
Jul
(21) |
Aug
(3) |
Sep
|
Oct
(1) |
Nov
(10) |
Dec
(1) |
| 2006 |
Jan
(17) |
Feb
(17) |
Mar
(3) |
Apr
(2) |
May
(2) |
Jun
(7) |
Jul
(6) |
Aug
(4) |
Sep
|
Oct
(3) |
Nov
(7) |
Dec
(4) |
| 2007 |
Jan
(6) |
Feb
(4) |
Mar
|
Apr
(3) |
May
(7) |
Jun
(17) |
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
(2) |
Dec
(5) |
| 2008 |
Jan
(14) |
Feb
(2) |
Mar
(2) |
Apr
|
May
(1) |
Jun
(2) |
Jul
|
Aug
|
Sep
|
Oct
(2) |
Nov
|
Dec
|
| 2009 |
Jan
(2) |
Feb
(22) |
Mar
(3) |
Apr
|
May
(7) |
Jun
|
Jul
|
Aug
(15) |
Sep
|
Oct
(32) |
Nov
(9) |
Dec
|
| 2010 |
Jan
(18) |
Feb
(2) |
Mar
(14) |
Apr
(1) |
May
|
Jun
|
Jul
(2) |
Aug
(7) |
Sep
(6) |
Oct
(35) |
Nov
(4) |
Dec
|
| 2011 |
Jan
(4) |
Feb
|
Mar
(9) |
Apr
|
May
|
Jun
(3) |
Jul
|
Aug
|
Sep
(9) |
Oct
|
Nov
|
Dec
(4) |
| 2012 |
Jan
(4) |
Feb
|
Mar
(8) |
Apr
(9) |
May
|
Jun
(176) |
Jul
(86) |
Aug
(20) |
Sep
(3) |
Oct
|
Nov
|
Dec
|
| 2013 |
Jan
|
Feb
(4) |
Mar
(5) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(2) |
Nov
|
Dec
|
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(4) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2015 |
Jan
|
Feb
|
Mar
(3) |
Apr
|
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
(1) |
| 2016 |
Jan
(1) |
Feb
(2) |
Mar
|
Apr
|
May
|
Jun
|
Jul
(2) |
Aug
(4) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2017 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(6) |
Aug
(13) |
Sep
(3) |
Oct
|
Nov
|
Dec
|
| 2018 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(11) |
Aug
|
Sep
(5) |
Oct
(2) |
Nov
|
Dec
|
| 2020 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(1) |
Nov
(1) |
Dec
|
|
From: Geoffrey B. <geo...@in...> - 2010-10-07 01:31:20
|
I rebuilt with a fresh checkout of basilisk and sheepshaver. Here's how I configured ./configure --without-gtk --with-sdl-video This is pretty tough to debug, but the crash occurs at vm_alloc.cpp line 294. if (mmap((caddr_t)addr, size, VM_PAGE_DEFAULT, the_map_flags, fd, 0) =\ = (void *)MAP_FAILED) causes a seg fault addr = 0 size = 0x4000000 the_map_flags = 0 Clearly the odd diff I had prevented this being executed. Geoffrey |
|
From: Michael S. <msb...@me...> - 2010-10-07 01:14:24
|
FYI... If I recall correctly, what is happening in this section of the code is this: In REAL_ADDRESSING mode, the addresses in the VM (Mac OS) are the same as in the host system (e.g. Linux or Mac OS). The problem is Mac OS wants a low memory global area, which means it needs an allocation at address zero in the host address space. First it tries to allocate the entire RAM/ROM area starting at address zero in the host, assuming that it can arrange for the SheepShaver module to be loaded at some other address (HAVE_LINKER_SCRIPT). If that succeeds, we're in good shape. Otherwise, on Darwin (OS X) hosts it can use a trick to get around the problem (PAGEZERO_HACK). The auto-config is supposed to test if that works. The hack means it doesn't have to do a low memory allocation. If it can't do PAGEZERO_HACK then it tries to allocate just the small low memory area it needs, at zero. On some Linux systems, you must do sudo sysctl -w vm.mmap_min_addr=0 to allow it to allocate at address zero. But if you don't allow it, you should get an error, not a segv. And on non-OS X hosts, I can't figure out how it would work to not allocate the address zero block. On Oct 6, 2010, at 7:46 PM, Geoffrey Brown wrote: > sigsegv right after the gtk gui. I was able (barely) to step in gdb until > the crash occurred and if I recall correctly it was exactly at the point > of executing that ifdefed code. I was trying to build a fresh > checkout to see if my vhd stuff breaks on linux. Later, I > looked to see what had "changed" and found that diff. > > Geoffrey > > On Wed, Oct 6, 2010 at 8:42 PM, Alexei Svitkine > <ale...@gm...> wrote: >> How does it crash? >> >> -Alexei >> >> On Wed, Oct 6, 2010 at 8:35 PM, Geoffrey Brown <geo...@in...> wrote: >>> Ok, that's curious. The sources I was building on Linux previously >>> had this diff >>> >>> diff -r1.88 main_unix.cpp >>> 846c846 >>> < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT >>> --- >>>> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK >>> >>> But as you point out there doesn't seem to have been any activity on >>> this recently >>> so I'm not sure how I ended up with that diff -- I went to the web based cvs to >>> see if I could find the change and can't. >>> >>> In any case, without the "PAGEZERO_HACK' flag to make that #if false, things >>> bomb immediately on linux. Adding that "back" I can make forward progress. >>> I have no idea where that came from (a bug fix suggested on a forum?) >>> >>> So, maybe I need to configure for linux differently -- I've been doing >>> >>> ./configure --enable-sdl-audio --enable-sdl-video >>> >>> I'll try to figure out what is going on. >>> >>> Geoffrey >>> >>> >>> >>> >>> On Wed, Oct 6, 2010 at 8:09 PM, Alexei Svitkine >>> <ale...@gm...> wrote: >>>> Which change are you talking about? >>>> >>>> I don't see any recent activity around that part of main_unix.cpp... >>>> >>>> Which combination of macros does your config define that causes the problem? >>>> >>>> -Alexei >>>> >>>> On Wed, Oct 6, 2010 at 7:55 PM, Geoffrey Brown <geo...@in...> wrote: >>>>> The following change which was checked in to the repository causes >>>>> immediate segv on Linux >>>>> (Linux ... machine name elided .... .6.18-194.17.1.el5 #1 SMP Mon Sep >>>>> 20 07:16:16 EDT 2010 i686 i686 i386 GNU/Linux >>>>> >>>>> >>>>> RCS file: /home/cvs/cebix/SheepShaver/src/Unix/main_unix.cpp,v >>>>> retrieving revision 1.88 >>>>> diff -r1.88 main_unix.cpp >>>>> 846c846 >>>>> < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT >>>>> --- >>>>>> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK >>>>> >>>>> >>>>> Clearly that code was turned off previously >>>>> >>>>> Geoffrey >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Beautiful is writing same markup. Internet Explorer 9 supports >>>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>>>> Spend less time writing and rewriting code and more time creating great >>>>> experiences on the web. Be a part of the beta today. >>>>> http://p.sf.net/sfu/beautyoftheweb >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Beautiful is writing same markup. Internet Explorer 9 supports >>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>>> Spend less time writing and rewriting code and more time creating great >>>> experiences on the web. Be a part of the beta today. >>>> http://p.sf.net/sfu/beautyoftheweb >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Beautiful is writing same markup. Internet Explorer 9 supports >>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>> Spend less time writing and rewriting code and more time creating great >>> experiences on the web. Be a part of the beta today. >>> http://p.sf.net/sfu/beautyoftheweb >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel |
|
From: Geoffrey B. <geo...@in...> - 2010-10-07 00:46:49
|
sigsegv right after the gtk gui. I was able (barely) to step in gdb until the crash occurred and if I recall correctly it was exactly at the point of executing that ifdefed code. I was trying to build a fresh checkout to see if my vhd stuff breaks on linux. Later, I looked to see what had "changed" and found that diff. Geoffrey On Wed, Oct 6, 2010 at 8:42 PM, Alexei Svitkine <ale...@gm...> wrote: > How does it crash? > > -Alexei > > On Wed, Oct 6, 2010 at 8:35 PM, Geoffrey Brown <geo...@in...> wrote: >> Ok, that's curious. The sources I was building on Linux previously >> had this diff >> >> diff -r1.88 main_unix.cpp >> 846c846 >> < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT >> --- >>> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK >> >> But as you point out there doesn't seem to have been any activity on >> this recently >> so I'm not sure how I ended up with that diff -- I went to the web based cvs to >> see if I could find the change and can't. >> >> In any case, without the "PAGEZERO_HACK' flag to make that #if false, things >> bomb immediately on linux. Adding that "back" I can make forward progress. >> I have no idea where that came from (a bug fix suggested on a forum?) >> >> So, maybe I need to configure for linux differently -- I've been doing >> >> ./configure --enable-sdl-audio --enable-sdl-video >> >> I'll try to figure out what is going on. >> >> Geoffrey >> >> >> >> >> On Wed, Oct 6, 2010 at 8:09 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> Which change are you talking about? >>> >>> I don't see any recent activity around that part of main_unix.cpp... >>> >>> Which combination of macros does your config define that causes the problem? >>> >>> -Alexei >>> >>> On Wed, Oct 6, 2010 at 7:55 PM, Geoffrey Brown <geo...@in...> wrote: >>>> The following change which was checked in to the repository causes >>>> immediate segv on Linux >>>> (Linux ... machine name elided .... .6.18-194.17.1.el5 #1 SMP Mon Sep >>>> 20 07:16:16 EDT 2010 i686 i686 i386 GNU/Linux >>>> >>>> >>>> RCS file: /home/cvs/cebix/SheepShaver/src/Unix/main_unix.cpp,v >>>> retrieving revision 1.88 >>>> diff -r1.88 main_unix.cpp >>>> 846c846 >>>> < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT >>>> --- >>>>> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK >>>> >>>> >>>> Clearly that code was turned off previously >>>> >>>> Geoffrey >>>> >>>> ------------------------------------------------------------------------------ >>>> Beautiful is writing same markup. Internet Explorer 9 supports >>>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>>> Spend less time writing and rewriting code and more time creating great >>>> experiences on the web. Be a part of the beta today. >>>> http://p.sf.net/sfu/beautyoftheweb >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Beautiful is writing same markup. Internet Explorer 9 supports >>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>> Spend less time writing and rewriting code and more time creating great >>> experiences on the web. Be a part of the beta today. >>> http://p.sf.net/sfu/beautyoftheweb >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-10-07 00:43:39
|
How does it crash? -Alexei On Wed, Oct 6, 2010 at 8:35 PM, Geoffrey Brown <geo...@in...> wrote: > Ok, that's curious. The sources I was building on Linux previously > had this diff > > diff -r1.88 main_unix.cpp > 846c846 > < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT > --- >> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK > > But as you point out there doesn't seem to have been any activity on > this recently > so I'm not sure how I ended up with that diff -- I went to the web based cvs to > see if I could find the change and can't. > > In any case, without the "PAGEZERO_HACK' flag to make that #if false, things > bomb immediately on linux. Adding that "back" I can make forward progress. > I have no idea where that came from (a bug fix suggested on a forum?) > > So, maybe I need to configure for linux differently -- I've been doing > > ./configure --enable-sdl-audio --enable-sdl-video > > I'll try to figure out what is going on. > > Geoffrey > > > > > On Wed, Oct 6, 2010 at 8:09 PM, Alexei Svitkine > <ale...@gm...> wrote: >> Which change are you talking about? >> >> I don't see any recent activity around that part of main_unix.cpp... >> >> Which combination of macros does your config define that causes the problem? >> >> -Alexei >> >> On Wed, Oct 6, 2010 at 7:55 PM, Geoffrey Brown <geo...@in...> wrote: >>> The following change which was checked in to the repository causes >>> immediate segv on Linux >>> (Linux ... machine name elided .... .6.18-194.17.1.el5 #1 SMP Mon Sep >>> 20 07:16:16 EDT 2010 i686 i686 i386 GNU/Linux >>> >>> >>> RCS file: /home/cvs/cebix/SheepShaver/src/Unix/main_unix.cpp,v >>> retrieving revision 1.88 >>> diff -r1.88 main_unix.cpp >>> 846c846 >>> < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT >>> --- >>>> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK >>> >>> >>> Clearly that code was turned off previously >>> >>> Geoffrey >>> >>> ------------------------------------------------------------------------------ >>> Beautiful is writing same markup. Internet Explorer 9 supports >>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>> Spend less time writing and rewriting code and more time creating great >>> experiences on the web. Be a part of the beta today. >>> http://p.sf.net/sfu/beautyoftheweb >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-07 00:35:30
|
Ok, that's curious. The sources I was building on Linux previously had this diff diff -r1.88 main_unix.cpp 846c846 < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT --- > #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK But as you point out there doesn't seem to have been any activity on this recently so I'm not sure how I ended up with that diff -- I went to the web based cvs to see if I could find the change and can't. In any case, without the "PAGEZERO_HACK' flag to make that #if false, things bomb immediately on linux. Adding that "back" I can make forward progress. I have no idea where that came from (a bug fix suggested on a forum?) So, maybe I need to configure for linux differently -- I've been doing ./configure --enable-sdl-audio --enable-sdl-video I'll try to figure out what is going on. Geoffrey On Wed, Oct 6, 2010 at 8:09 PM, Alexei Svitkine <ale...@gm...> wrote: > Which change are you talking about? > > I don't see any recent activity around that part of main_unix.cpp... > > Which combination of macros does your config define that causes the problem? > > -Alexei > > On Wed, Oct 6, 2010 at 7:55 PM, Geoffrey Brown <geo...@in...> wrote: >> The following change which was checked in to the repository causes >> immediate segv on Linux >> (Linux ... machine name elided .... .6.18-194.17.1.el5 #1 SMP Mon Sep >> 20 07:16:16 EDT 2010 i686 i686 i386 GNU/Linux >> >> >> RCS file: /home/cvs/cebix/SheepShaver/src/Unix/main_unix.cpp,v >> retrieving revision 1.88 >> diff -r1.88 main_unix.cpp >> 846c846 >> < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT >> --- >>> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK >> >> >> Clearly that code was turned off previously >> >> Geoffrey >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-10-07 00:10:40
|
Which change are you talking about? I don't see any recent activity around that part of main_unix.cpp... Which combination of macros does your config define that causes the problem? -Alexei On Wed, Oct 6, 2010 at 7:55 PM, Geoffrey Brown <geo...@in...> wrote: > The following change which was checked in to the repository causes > immediate segv on Linux > (Linux ... machine name elided .... .6.18-194.17.1.el5 #1 SMP Mon Sep > 20 07:16:16 EDT 2010 i686 i686 i386 GNU/Linux > > > RCS file: /home/cvs/cebix/SheepShaver/src/Unix/main_unix.cpp,v > retrieving revision 1.88 > diff -r1.88 main_unix.cpp > 846c846 > < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT > --- >> #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK > > > Clearly that code was turned off previously > > Geoffrey > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-06 23:55:27
|
The following change which was checked in to the repository causes immediate segv on Linux (Linux ... machine name elided .... .6.18-194.17.1.el5 #1 SMP Mon Sep 20 07:16:16 EDT 2010 i686 i686 i386 GNU/Linux RCS file: /home/cvs/cebix/SheepShaver/src/Unix/main_unix.cpp,v retrieving revision 1.88 diff -r1.88 main_unix.cpp 846c846 < #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT --- > #if REAL_ADDRESSING && HAVE_LINKER_SCRIPT && PAGEZERO_HACK Clearly that code was turned off previously Geoffrey |
|
From: Alexei S. <ale...@gm...> - 2010-10-06 00:53:25
|
Sounds interesting. By the way, I am not against patches refactoring the current code to make it cleaner and easier to understand. Cheers, -Alexei On Tue, Oct 5, 2010 at 8:45 PM, Geoffrey Brown <geo...@in...> wrote: > Thanks for all your help. > > I've also been working on enabling the use of vhd files (especially > snapshots) using the now open source libvhd (released by xen). It's > all working, but > it took some tweaking to libvhd to compile on OS X -- I've no idea how hard > it would be on Windows. Again this requires changes to sys_unix.cpp. Actually > the hardest part was making those changes to sys_unix.cpp. It's too > bad that the cdrom and > "disk" support doesn't make better use of c++ -- with the current implementation > of sys_unix (and I imagine the windows equivalent) all the special case > code is mixed together which makes it hard to follow. > > Geoffrey > > On Tue, Oct 5, 2010 at 8:36 PM, Alexei Svitkine > <ale...@gm...> wrote: >> I've committed your changes with some minor formatting tweaks. >> >> I've also updated SheepShaver's root Makefile to include your two new >> files in 'make links'. >> >> Finally, I've removed the commented out ifndef SHEEPSHAVER block - >> assuming it wasn't needed. >> >> Thanks for contributing! >> >> -Alexei >> >> On Tue, Oct 5, 2010 at 9:46 AM, Geoffrey Brown <geo...@in...> wrote: >>> I think I've made all the changes except one -- I didn't change the >>> free/malloc pair >>> for realloc. I think the error cases are easier to understand for >>> free/malloc than >>> for realloc and there isn't a performance issue since an allocation is >>> expected only when a stream is >>> started. The following should work: >>> >>> 1) Basilisk and SheepShaver with sdl-audio and bincue on linux and os x >>> 2) SheepShaver with bincue and core audio on os x -- the Basilisk >>> configuration seems to be lagging Sheepshaver and doesn't support core >>> audio even without the bincue support. >>> >>> I haven't done the changes necessary for windows and would have >>> to set up a system to do them. >>> >>> Geoffrey >>> >>> On Mon, Oct 4, 2010 at 7:32 PM, Alexei Svitkine >>> <ale...@gm...> wrote: >>>> One more thing I forgot to mention: >>>> >>>> Please put the license comment first - above your comment explaining >>>> the file. Begin the license comment with the name of the file and a >>>> one-line description of what it does (see how other files do it). >>>> Also, include your name in the Copyright in the license comment >>>> (unless you want your changes under some other license). >>>> >>>> After this, you can put the other comment that explains the file in >>>> more depth (limitations, etc) following the license comment. >>>> >>>> Thanks again, >>>> >>>> -Alexei >>>> >>>> On Mon, Oct 4, 2010 at 7:19 PM, Alexei Svitkine >>>> <ale...@gm...> wrote: >>>>> Hi Geoffrey, >>>>> >>>>> Patch looks mostly good, though I have a few comments: >>>>> >>>>> 1. In LoadCueSheet(), you call fstat() without checking the return >>>>> value for success - please handle the failure case. >>>>> >>>>> 2. I suggest refactoring the keyword parsing part of LoadCueSheet() >>>>> into a separate helper function to make the code more readable. Either >>>>> the whole while() itself or just the loop body. >>>>> >>>>> 3. You're still using non-Sheepshaver style braces / incorrect >>>>> indentation in fill_buffer(). In that block, I also suggest using >>>>> realloc() instead of free()/malloc() (and don't forget to free the >>>>> original buf if realloc() fails). >>>>> >>>>> 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block >>>>> is necessary? >>>>> >>>>> 5. Can you explain the logic in read_bincue()? It seems you're reading >>>>> by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by >>>>> 'available'. This seems incorrect to me, but I'm not familiar with the >>>>> format. >>>>> >>>>> 6. Can you make the first if in CDPlay_bincue consistent with the >>>>> similar ones in other functions (i.e. remove the extra parens)? >>>>> >>>>> 7. You're not checking the return value of lseek() in a couple of >>>>> places. Likewise with malloc()/strdup(). >>>>> >>>>> 8. I suggest using sprintf() in the "FILE" keyword handling section >>>>> instead of strcpy()+strcat()+srcat(). >>>>> >>>>> 9. Can there be multiple "FILE" keywords? If so, you'll be leaking >>>>> cs->binfile strings. >>>>> >>>>> 10. Please add D(bug()) lines in all the places in the keyword parsing >>>>> code where you goto fail. >>>>> >>>>> Please address the above comments and re-send the bincue_unix.cpp file. Thanks! >>>>> >>>>> -Alexei >>>>> >>>>> On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>> Here's a second attempt. I added the appropriate license -- in reviewing my >>>>>> code it appears only dosbox contributed any code and this could easily >>>>>> be excised (though it uses the same gpl version as sheepshaver/basilisk). >>>>>> >>>>>> I've attempted to follow the existing brace style and made sure tabs are >>>>>> used instead of spaces. >>>>>> >>>>>> I've also made fixes 3 & 4. >>>>>> >>>>>> Geoffrey >>>>>> >>>>>> On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine >>>>>> <ale...@gm...> wrote: >>>>>>> Some comments: >>>>>>> >>>>>>> 1. >>>>>>> >>>>>>> "Includes ideas, even code fragments, from dosbox and libcdio hence >>>>>>> must obey those licences" >>>>>>> >>>>>>> What are their licenses? >>>>>>> >>>>>>> 2. >>>>>>> >>>>>>> Please use a consistent brace/indentation style as the rest of the >>>>>>> SheepShaver / Basilisk II codebases. Currently your code mixes and >>>>>>> matches tabs and space (the existing codebase is standardised on tabs) >>>>>>> and uses a different brace style then the rest of the code. >>>>>>> >>>>>>> 3. >>>>>>> >>>>>>> In audio_sdl.cpp, please include the relevant header instead of >>>>>>> declaring extern functions right before calling it. >>>>>>> >>>>>>> 4. >>>>>>> >>>>>>> Please update your CVS - the video_blit.cpp change already exists in trunk. >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> -Alexei >>>>>>> >>>>>>> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>>>>>>> <ale...@gm...> wrote: >>>>>>>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>>>>>>> >>>>>>>>> I suggest passing in -u to the diff command to get a unified diff >>>>>>>>> (easier to read). Also, if your changes involve modification to files >>>>>>>>> in both Basilisk and SheepShaver trees, you need to create two >>>>>>>>> patches, one from each tree. >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> >>>>>>>>> -Alexei >>>>>>>>> >>>>>>>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>>>> Sure. I need a little handholding on making the diffs. >>>>>>>>>> Did you have in mind something like the following ? >>>>>>>>>> >>>>>>>>>> 1) I checkout a clean svn snapshot >>>>>>>>>> 2) make my changes >>>>>>>>>> 3) svn diff >>>>>>>>>> >>>>>>>>>> Geoffrey >>>>>>>>>> >>>>>>>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>>>>>>> <ale...@gm...> wrote: >>>>>>>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>>>>>>> of the files? >>>>>>>>>>> >>>>>>>>>>> -Alexei >>>>>>>>>>> >>>>>>>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>>>>>>> digital/audio cdroms. >>>>>>>>>>>> >>>>>>>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>>>>>>> here. Is it >>>>>>>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>>>>>>> inappropriate, is there >>>>>>>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>>>>>>> the cvs repository ? >>>>>>>>>>>> >>>>>>>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>>>>>>> tested on linux and OS X. >>>>>>>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>>>>>>> >>>>>>>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>>>>>>> and 2532 tracks (audio and raw >>>>>>>>>>>> data). There are other limitations, but those are the key ones. >>>>>>>>>>>> >>>>>>>>>>>> Geoffrey Brown >>>>>>>>>>>> >>>>>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>>>>> and start using them to simplify application deployment and >>>>>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>> basilisk-devel mailing list >>>>>>>>>>>> bas...@li... >>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>>>> and start using them to simplify application deployment and >>>>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> basilisk-devel mailing list >>>>>>>>>>> bas...@li... >>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>>> and start using them to simplify application deployment and >>>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>>> _______________________________________________ >>>>>>>>>> basilisk-devel mailing list >>>>>>>>>> bas...@li... >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>>> >>>>>>>>> >>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>> and start using them to simplify application deployment and >>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>> _______________________________________________ >>>>>>>>> basilisk-devel mailing list >>>>>>>>> bas...@li... >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>> and start using them to simplify application deployment and >>>>>>>> accelerate your shift to cloud computing. >>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>> _______________________________________________ >>>>>>>> basilisk-devel mailing list >>>>>>>> bas...@li... >>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Virtualization is moving to the mainstream and overtaking non-virtualized >>>>>> environment for deploying applications. Does it make network security >>>>>> easier or more difficult to achieve? Read this whitepaper to separate the >>>>>> two and get a better understanding. >>>>>> http://p.sf.net/sfu/hp-phase2-d2d >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>>> >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Virtualization is moving to the mainstream and overtaking non-virtualized >>>> environment for deploying applications. Does it make network security >>>> easier or more difficult to achieve? Read this whitepaper to separate the >>>> two and get a better understanding. >>>> http://p.sf.net/sfu/hp-phase2-d2d >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Beautiful is writing same markup. Internet Explorer 9 supports >>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >>> Spend less time writing and rewriting code and more time creating great >>> experiences on the web. Be a part of the beta today. >>> http://p.sf.net/sfu/beautyoftheweb >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >>> >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-06 00:45:44
|
Thanks for all your help. I've also been working on enabling the use of vhd files (especially snapshots) using the now open source libvhd (released by xen). It's all working, but it took some tweaking to libvhd to compile on OS X -- I've no idea how hard it would be on Windows. Again this requires changes to sys_unix.cpp. Actually the hardest part was making those changes to sys_unix.cpp. It's too bad that the cdrom and "disk" support doesn't make better use of c++ -- with the current implementation of sys_unix (and I imagine the windows equivalent) all the special case code is mixed together which makes it hard to follow. Geoffrey On Tue, Oct 5, 2010 at 8:36 PM, Alexei Svitkine <ale...@gm...> wrote: > I've committed your changes with some minor formatting tweaks. > > I've also updated SheepShaver's root Makefile to include your two new > files in 'make links'. > > Finally, I've removed the commented out ifndef SHEEPSHAVER block - > assuming it wasn't needed. > > Thanks for contributing! > > -Alexei > > On Tue, Oct 5, 2010 at 9:46 AM, Geoffrey Brown <geo...@in...> wrote: >> I think I've made all the changes except one -- I didn't change the >> free/malloc pair >> for realloc. I think the error cases are easier to understand for >> free/malloc than >> for realloc and there isn't a performance issue since an allocation is >> expected only when a stream is >> started. The following should work: >> >> 1) Basilisk and SheepShaver with sdl-audio and bincue on linux and os x >> 2) SheepShaver with bincue and core audio on os x -- the Basilisk >> configuration seems to be lagging Sheepshaver and doesn't support core >> audio even without the bincue support. >> >> I haven't done the changes necessary for windows and would have >> to set up a system to do them. >> >> Geoffrey >> >> On Mon, Oct 4, 2010 at 7:32 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> One more thing I forgot to mention: >>> >>> Please put the license comment first - above your comment explaining >>> the file. Begin the license comment with the name of the file and a >>> one-line description of what it does (see how other files do it). >>> Also, include your name in the Copyright in the license comment >>> (unless you want your changes under some other license). >>> >>> After this, you can put the other comment that explains the file in >>> more depth (limitations, etc) following the license comment. >>> >>> Thanks again, >>> >>> -Alexei >>> >>> On Mon, Oct 4, 2010 at 7:19 PM, Alexei Svitkine >>> <ale...@gm...> wrote: >>>> Hi Geoffrey, >>>> >>>> Patch looks mostly good, though I have a few comments: >>>> >>>> 1. In LoadCueSheet(), you call fstat() without checking the return >>>> value for success - please handle the failure case. >>>> >>>> 2. I suggest refactoring the keyword parsing part of LoadCueSheet() >>>> into a separate helper function to make the code more readable. Either >>>> the whole while() itself or just the loop body. >>>> >>>> 3. You're still using non-Sheepshaver style braces / incorrect >>>> indentation in fill_buffer(). In that block, I also suggest using >>>> realloc() instead of free()/malloc() (and don't forget to free the >>>> original buf if realloc() fails). >>>> >>>> 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block >>>> is necessary? >>>> >>>> 5. Can you explain the logic in read_bincue()? It seems you're reading >>>> by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by >>>> 'available'. This seems incorrect to me, but I'm not familiar with the >>>> format. >>>> >>>> 6. Can you make the first if in CDPlay_bincue consistent with the >>>> similar ones in other functions (i.e. remove the extra parens)? >>>> >>>> 7. You're not checking the return value of lseek() in a couple of >>>> places. Likewise with malloc()/strdup(). >>>> >>>> 8. I suggest using sprintf() in the "FILE" keyword handling section >>>> instead of strcpy()+strcat()+srcat(). >>>> >>>> 9. Can there be multiple "FILE" keywords? If so, you'll be leaking >>>> cs->binfile strings. >>>> >>>> 10. Please add D(bug()) lines in all the places in the keyword parsing >>>> code where you goto fail. >>>> >>>> Please address the above comments and re-send the bincue_unix.cpp file. Thanks! >>>> >>>> -Alexei >>>> >>>> On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: >>>>> Here's a second attempt. I added the appropriate license -- in reviewing my >>>>> code it appears only dosbox contributed any code and this could easily >>>>> be excised (though it uses the same gpl version as sheepshaver/basilisk). >>>>> >>>>> I've attempted to follow the existing brace style and made sure tabs are >>>>> used instead of spaces. >>>>> >>>>> I've also made fixes 3 & 4. >>>>> >>>>> Geoffrey >>>>> >>>>> On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine >>>>> <ale...@gm...> wrote: >>>>>> Some comments: >>>>>> >>>>>> 1. >>>>>> >>>>>> "Includes ideas, even code fragments, from dosbox and libcdio hence >>>>>> must obey those licences" >>>>>> >>>>>> What are their licenses? >>>>>> >>>>>> 2. >>>>>> >>>>>> Please use a consistent brace/indentation style as the rest of the >>>>>> SheepShaver / Basilisk II codebases. Currently your code mixes and >>>>>> matches tabs and space (the existing codebase is standardised on tabs) >>>>>> and uses a different brace style then the rest of the code. >>>>>> >>>>>> 3. >>>>>> >>>>>> In audio_sdl.cpp, please include the relevant header instead of >>>>>> declaring extern functions right before calling it. >>>>>> >>>>>> 4. >>>>>> >>>>>> Please update your CVS - the video_blit.cpp change already exists in trunk. >>>>>> >>>>>> Cheers, >>>>>> >>>>>> -Alexei >>>>>> >>>>>> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>>>>>> <ale...@gm...> wrote: >>>>>>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>>>>>> >>>>>>>> I suggest passing in -u to the diff command to get a unified diff >>>>>>>> (easier to read). Also, if your changes involve modification to files >>>>>>>> in both Basilisk and SheepShaver trees, you need to create two >>>>>>>> patches, one from each tree. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> >>>>>>>> -Alexei >>>>>>>> >>>>>>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>>> Sure. I need a little handholding on making the diffs. >>>>>>>>> Did you have in mind something like the following ? >>>>>>>>> >>>>>>>>> 1) I checkout a clean svn snapshot >>>>>>>>> 2) make my changes >>>>>>>>> 3) svn diff >>>>>>>>> >>>>>>>>> Geoffrey >>>>>>>>> >>>>>>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>>>>>> <ale...@gm...> wrote: >>>>>>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>>>>>> of the files? >>>>>>>>>> >>>>>>>>>> -Alexei >>>>>>>>>> >>>>>>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>>>>>> digital/audio cdroms. >>>>>>>>>>> >>>>>>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>>>>>> here. Is it >>>>>>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>>>>>> inappropriate, is there >>>>>>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>>>>>> the cvs repository ? >>>>>>>>>>> >>>>>>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>>>>>> tested on linux and OS X. >>>>>>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>>>>>> >>>>>>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>>>>>> and 2532 tracks (audio and raw >>>>>>>>>>> data). There are other limitations, but those are the key ones. >>>>>>>>>>> >>>>>>>>>>> Geoffrey Brown >>>>>>>>>>> >>>>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>>>> and start using them to simplify application deployment and >>>>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> basilisk-devel mailing list >>>>>>>>>>> bas...@li... >>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>>> and start using them to simplify application deployment and >>>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>>> _______________________________________________ >>>>>>>>>> basilisk-devel mailing list >>>>>>>>>> bas...@li... >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>>> >>>>>>>>> >>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>> and start using them to simplify application deployment and >>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>> _______________________________________________ >>>>>>>>> basilisk-devel mailing list >>>>>>>>> bas...@li... >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>> and start using them to simplify application deployment and >>>>>>>> accelerate your shift to cloud computing. >>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>> _______________________________________________ >>>>>>>> basilisk-devel mailing list >>>>>>>> bas...@li... >>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Virtualization is moving to the mainstream and overtaking non-virtualized >>>>> environment for deploying applications. Does it make network security >>>>> easier or more difficult to achieve? Read this whitepaper to separate the >>>>> two and get a better understanding. >>>>> http://p.sf.net/sfu/hp-phase2-d2d >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>>> >>>> >>> >>> ------------------------------------------------------------------------------ >>> Virtualization is moving to the mainstream and overtaking non-virtualized >>> environment for deploying applications. Does it make network security >>> easier or more difficult to achieve? Read this whitepaper to separate the >>> two and get a better understanding. >>> http://p.sf.net/sfu/hp-phase2-d2d >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Beautiful is writing same markup. Internet Explorer 9 supports >> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. >> Spend less time writing and rewriting code and more time creating great >> experiences on the web. Be a part of the beta today. >> http://p.sf.net/sfu/beautyoftheweb >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-10-06 00:37:03
|
I've committed your changes with some minor formatting tweaks. I've also updated SheepShaver's root Makefile to include your two new files in 'make links'. Finally, I've removed the commented out ifndef SHEEPSHAVER block - assuming it wasn't needed. Thanks for contributing! -Alexei On Tue, Oct 5, 2010 at 9:46 AM, Geoffrey Brown <geo...@in...> wrote: > I think I've made all the changes except one -- I didn't change the > free/malloc pair > for realloc. I think the error cases are easier to understand for > free/malloc than > for realloc and there isn't a performance issue since an allocation is > expected only when a stream is > started. The following should work: > > 1) Basilisk and SheepShaver with sdl-audio and bincue on linux and os x > 2) SheepShaver with bincue and core audio on os x -- the Basilisk > configuration seems to be lagging Sheepshaver and doesn't support core > audio even without the bincue support. > > I haven't done the changes necessary for windows and would have > to set up a system to do them. > > Geoffrey > > On Mon, Oct 4, 2010 at 7:32 PM, Alexei Svitkine > <ale...@gm...> wrote: >> One more thing I forgot to mention: >> >> Please put the license comment first - above your comment explaining >> the file. Begin the license comment with the name of the file and a >> one-line description of what it does (see how other files do it). >> Also, include your name in the Copyright in the license comment >> (unless you want your changes under some other license). >> >> After this, you can put the other comment that explains the file in >> more depth (limitations, etc) following the license comment. >> >> Thanks again, >> >> -Alexei >> >> On Mon, Oct 4, 2010 at 7:19 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> Hi Geoffrey, >>> >>> Patch looks mostly good, though I have a few comments: >>> >>> 1. In LoadCueSheet(), you call fstat() without checking the return >>> value for success - please handle the failure case. >>> >>> 2. I suggest refactoring the keyword parsing part of LoadCueSheet() >>> into a separate helper function to make the code more readable. Either >>> the whole while() itself or just the loop body. >>> >>> 3. You're still using non-Sheepshaver style braces / incorrect >>> indentation in fill_buffer(). In that block, I also suggest using >>> realloc() instead of free()/malloc() (and don't forget to free the >>> original buf if realloc() fails). >>> >>> 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block >>> is necessary? >>> >>> 5. Can you explain the logic in read_bincue()? It seems you're reading >>> by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by >>> 'available'. This seems incorrect to me, but I'm not familiar with the >>> format. >>> >>> 6. Can you make the first if in CDPlay_bincue consistent with the >>> similar ones in other functions (i.e. remove the extra parens)? >>> >>> 7. You're not checking the return value of lseek() in a couple of >>> places. Likewise with malloc()/strdup(). >>> >>> 8. I suggest using sprintf() in the "FILE" keyword handling section >>> instead of strcpy()+strcat()+srcat(). >>> >>> 9. Can there be multiple "FILE" keywords? If so, you'll be leaking >>> cs->binfile strings. >>> >>> 10. Please add D(bug()) lines in all the places in the keyword parsing >>> code where you goto fail. >>> >>> Please address the above comments and re-send the bincue_unix.cpp file. Thanks! >>> >>> -Alexei >>> >>> On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: >>>> Here's a second attempt. I added the appropriate license -- in reviewing my >>>> code it appears only dosbox contributed any code and this could easily >>>> be excised (though it uses the same gpl version as sheepshaver/basilisk). >>>> >>>> I've attempted to follow the existing brace style and made sure tabs are >>>> used instead of spaces. >>>> >>>> I've also made fixes 3 & 4. >>>> >>>> Geoffrey >>>> >>>> On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine >>>> <ale...@gm...> wrote: >>>>> Some comments: >>>>> >>>>> 1. >>>>> >>>>> "Includes ideas, even code fragments, from dosbox and libcdio hence >>>>> must obey those licences" >>>>> >>>>> What are their licenses? >>>>> >>>>> 2. >>>>> >>>>> Please use a consistent brace/indentation style as the rest of the >>>>> SheepShaver / Basilisk II codebases. Currently your code mixes and >>>>> matches tabs and space (the existing codebase is standardised on tabs) >>>>> and uses a different brace style then the rest of the code. >>>>> >>>>> 3. >>>>> >>>>> In audio_sdl.cpp, please include the relevant header instead of >>>>> declaring extern functions right before calling it. >>>>> >>>>> 4. >>>>> >>>>> Please update your CVS - the video_blit.cpp change already exists in trunk. >>>>> >>>>> Cheers, >>>>> >>>>> -Alexei >>>>> >>>>> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>>>>> <ale...@gm...> wrote: >>>>>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>>>>> >>>>>>> I suggest passing in -u to the diff command to get a unified diff >>>>>>> (easier to read). Also, if your changes involve modification to files >>>>>>> in both Basilisk and SheepShaver trees, you need to create two >>>>>>> patches, one from each tree. >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> -Alexei >>>>>>> >>>>>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>> Sure. I need a little handholding on making the diffs. >>>>>>>> Did you have in mind something like the following ? >>>>>>>> >>>>>>>> 1) I checkout a clean svn snapshot >>>>>>>> 2) make my changes >>>>>>>> 3) svn diff >>>>>>>> >>>>>>>> Geoffrey >>>>>>>> >>>>>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>>>>> <ale...@gm...> wrote: >>>>>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>>>>> of the files? >>>>>>>>> >>>>>>>>> -Alexei >>>>>>>>> >>>>>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>>>>> digital/audio cdroms. >>>>>>>>>> >>>>>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>>>>> here. Is it >>>>>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>>>>> inappropriate, is there >>>>>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>>>>> the cvs repository ? >>>>>>>>>> >>>>>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>>>>> tested on linux and OS X. >>>>>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>>>>> >>>>>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>>>>> and 2532 tracks (audio and raw >>>>>>>>>> data). There are other limitations, but those are the key ones. >>>>>>>>>> >>>>>>>>>> Geoffrey Brown >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>>> and start using them to simplify application deployment and >>>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>>> _______________________________________________ >>>>>>>>>> basilisk-devel mailing list >>>>>>>>>> bas...@li... >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>>> >>>>>>>>> >>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>> and start using them to simplify application deployment and >>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>> _______________________________________________ >>>>>>>>> basilisk-devel mailing list >>>>>>>>> bas...@li... >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>> and start using them to simplify application deployment and >>>>>>>> accelerate your shift to cloud computing. >>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>> _______________________________________________ >>>>>>>> basilisk-devel mailing list >>>>>>>> bas...@li... >>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Virtualization is moving to the mainstream and overtaking non-virtualized >>>> environment for deploying applications. Does it make network security >>>> easier or more difficult to achieve? Read this whitepaper to separate the >>>> two and get a better understanding. >>>> http://p.sf.net/sfu/hp-phase2-d2d >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>>> >>> >> >> ------------------------------------------------------------------------------ >> Virtualization is moving to the mainstream and overtaking non-virtualized >> environment for deploying applications. Does it make network security >> easier or more difficult to achieve? Read this whitepaper to separate the >> two and get a better understanding. >> http://p.sf.net/sfu/hp-phase2-d2d >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Beautiful is writing same markup. Internet Explorer 9 supports > standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. > Spend less time writing and rewriting code and more time creating great > experiences on the web. Be a part of the beta today. > http://p.sf.net/sfu/beautyoftheweb > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-05 13:47:05
|
I think I've made all the changes except one -- I didn't change the free/malloc pair for realloc. I think the error cases are easier to understand for free/malloc than for realloc and there isn't a performance issue since an allocation is expected only when a stream is started. The following should work: 1) Basilisk and SheepShaver with sdl-audio and bincue on linux and os x 2) SheepShaver with bincue and core audio on os x -- the Basilisk configuration seems to be lagging Sheepshaver and doesn't support core audio even without the bincue support. I haven't done the changes necessary for windows and would have to set up a system to do them. Geoffrey On Mon, Oct 4, 2010 at 7:32 PM, Alexei Svitkine <ale...@gm...> wrote: > One more thing I forgot to mention: > > Please put the license comment first - above your comment explaining > the file. Begin the license comment with the name of the file and a > one-line description of what it does (see how other files do it). > Also, include your name in the Copyright in the license comment > (unless you want your changes under some other license). > > After this, you can put the other comment that explains the file in > more depth (limitations, etc) following the license comment. > > Thanks again, > > -Alexei > > On Mon, Oct 4, 2010 at 7:19 PM, Alexei Svitkine > <ale...@gm...> wrote: >> Hi Geoffrey, >> >> Patch looks mostly good, though I have a few comments: >> >> 1. In LoadCueSheet(), you call fstat() without checking the return >> value for success - please handle the failure case. >> >> 2. I suggest refactoring the keyword parsing part of LoadCueSheet() >> into a separate helper function to make the code more readable. Either >> the whole while() itself or just the loop body. >> >> 3. You're still using non-Sheepshaver style braces / incorrect >> indentation in fill_buffer(). In that block, I also suggest using >> realloc() instead of free()/malloc() (and don't forget to free the >> original buf if realloc() fails). >> >> 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block >> is necessary? >> >> 5. Can you explain the logic in read_bincue()? It seems you're reading >> by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by >> 'available'. This seems incorrect to me, but I'm not familiar with the >> format. >> >> 6. Can you make the first if in CDPlay_bincue consistent with the >> similar ones in other functions (i.e. remove the extra parens)? >> >> 7. You're not checking the return value of lseek() in a couple of >> places. Likewise with malloc()/strdup(). >> >> 8. I suggest using sprintf() in the "FILE" keyword handling section >> instead of strcpy()+strcat()+srcat(). >> >> 9. Can there be multiple "FILE" keywords? If so, you'll be leaking >> cs->binfile strings. >> >> 10. Please add D(bug()) lines in all the places in the keyword parsing >> code where you goto fail. >> >> Please address the above comments and re-send the bincue_unix.cpp file. Thanks! >> >> -Alexei >> >> On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: >>> Here's a second attempt. I added the appropriate license -- in reviewing my >>> code it appears only dosbox contributed any code and this could easily >>> be excised (though it uses the same gpl version as sheepshaver/basilisk). >>> >>> I've attempted to follow the existing brace style and made sure tabs are >>> used instead of spaces. >>> >>> I've also made fixes 3 & 4. >>> >>> Geoffrey >>> >>> On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine >>> <ale...@gm...> wrote: >>>> Some comments: >>>> >>>> 1. >>>> >>>> "Includes ideas, even code fragments, from dosbox and libcdio hence >>>> must obey those licences" >>>> >>>> What are their licenses? >>>> >>>> 2. >>>> >>>> Please use a consistent brace/indentation style as the rest of the >>>> SheepShaver / Basilisk II codebases. Currently your code mixes and >>>> matches tabs and space (the existing codebase is standardised on tabs) >>>> and uses a different brace style then the rest of the code. >>>> >>>> 3. >>>> >>>> In audio_sdl.cpp, please include the relevant header instead of >>>> declaring extern functions right before calling it. >>>> >>>> 4. >>>> >>>> Please update your CVS - the video_blit.cpp change already exists in trunk. >>>> >>>> Cheers, >>>> >>>> -Alexei >>>> >>>> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>>>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>>>> <ale...@gm...> wrote: >>>>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>>>> >>>>>> I suggest passing in -u to the diff command to get a unified diff >>>>>> (easier to read). Also, if your changes involve modification to files >>>>>> in both Basilisk and SheepShaver trees, you need to create two >>>>>> patches, one from each tree. >>>>>> >>>>>> Cheers, >>>>>> >>>>>> -Alexei >>>>>> >>>>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>>>> Sure. I need a little handholding on making the diffs. >>>>>>> Did you have in mind something like the following ? >>>>>>> >>>>>>> 1) I checkout a clean svn snapshot >>>>>>> 2) make my changes >>>>>>> 3) svn diff >>>>>>> >>>>>>> Geoffrey >>>>>>> >>>>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>>>> <ale...@gm...> wrote: >>>>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>>>> of the files? >>>>>>>> >>>>>>>> -Alexei >>>>>>>> >>>>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>>>> digital/audio cdroms. >>>>>>>>> >>>>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>>>> here. Is it >>>>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>>>> inappropriate, is there >>>>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>>>> the cvs repository ? >>>>>>>>> >>>>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>>>> tested on linux and OS X. >>>>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>>>> >>>>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>>>> and 2532 tracks (audio and raw >>>>>>>>> data). There are other limitations, but those are the key ones. >>>>>>>>> >>>>>>>>> Geoffrey Brown >>>>>>>>> >>>>>>>>> ------------------------------------------------------------------------------ >>>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>>> and start using them to simplify application deployment and >>>>>>>>> accelerate your shift to cloud computing. >>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>>> _______________________________________________ >>>>>>>>> basilisk-devel mailing list >>>>>>>>> bas...@li... >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>> and start using them to simplify application deployment and >>>>>>>> accelerate your shift to cloud computing. >>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>> _______________________________________________ >>>>>>>> basilisk-devel mailing list >>>>>>>> bas...@li... >>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Virtualization is moving to the mainstream and overtaking non-virtualized >>> environment for deploying applications. Does it make network security >>> easier or more difficult to achieve? Read this whitepaper to separate the >>> two and get a better understanding. >>> http://p.sf.net/sfu/hp-phase2-d2d >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >>> >> > > ------------------------------------------------------------------------------ > Virtualization is moving to the mainstream and overtaking non-virtualized > environment for deploying applications. Does it make network security > easier or more difficult to achieve? Read this whitepaper to separate the > two and get a better understanding. > http://p.sf.net/sfu/hp-phase2-d2d > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-05 00:21:23
|
Thanks, It'll take a few days to get to it, but I'll do it as quickly as I can. Geoffrey On Mon, Oct 4, 2010 at 7:19 PM, Alexei Svitkine <ale...@gm...> wrote: > Hi Geoffrey, > > Patch looks mostly good, though I have a few comments: > > 1. In LoadCueSheet(), you call fstat() without checking the return > value for success - please handle the failure case. > > 2. I suggest refactoring the keyword parsing part of LoadCueSheet() > into a separate helper function to make the code more readable. Either > the whole while() itself or just the loop body. > > 3. You're still using non-Sheepshaver style braces / incorrect > indentation in fill_buffer(). In that block, I also suggest using > realloc() instead of free()/malloc() (and don't forget to free the > original buf if realloc() fails). > > 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block > is necessary? > > 5. Can you explain the logic in read_bincue()? It seems you're reading > by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by > 'available'. This seems incorrect to me, but I'm not familiar with the > format. > > 6. Can you make the first if in CDPlay_bincue consistent with the > similar ones in other functions (i.e. remove the extra parens)? > > 7. You're not checking the return value of lseek() in a couple of > places. Likewise with malloc()/strdup(). > > 8. I suggest using sprintf() in the "FILE" keyword handling section > instead of strcpy()+strcat()+srcat(). > > 9. Can there be multiple "FILE" keywords? If so, you'll be leaking > cs->binfile strings. > > 10. Please add D(bug()) lines in all the places in the keyword parsing > code where you goto fail. > > Please address the above comments and re-send the bincue_unix.cpp file. Thanks! > > -Alexei > > On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: >> Here's a second attempt. I added the appropriate license -- in reviewing my >> code it appears only dosbox contributed any code and this could easily >> be excised (though it uses the same gpl version as sheepshaver/basilisk). >> >> I've attempted to follow the existing brace style and made sure tabs are >> used instead of spaces. >> >> I've also made fixes 3 & 4. >> >> Geoffrey >> >> On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine >> <ale...@gm...> wrote: >>> Some comments: >>> >>> 1. >>> >>> "Includes ideas, even code fragments, from dosbox and libcdio hence >>> must obey those licences" >>> >>> What are their licenses? >>> >>> 2. >>> >>> Please use a consistent brace/indentation style as the rest of the >>> SheepShaver / Basilisk II codebases. Currently your code mixes and >>> matches tabs and space (the existing codebase is standardised on tabs) >>> and uses a different brace style then the rest of the code. >>> >>> 3. >>> >>> In audio_sdl.cpp, please include the relevant header instead of >>> declaring extern functions right before calling it. >>> >>> 4. >>> >>> Please update your CVS - the video_blit.cpp change already exists in trunk. >>> >>> Cheers, >>> >>> -Alexei >>> >>> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>>> <ale...@gm...> wrote: >>>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>>> >>>>> I suggest passing in -u to the diff command to get a unified diff >>>>> (easier to read). Also, if your changes involve modification to files >>>>> in both Basilisk and SheepShaver trees, you need to create two >>>>> patches, one from each tree. >>>>> >>>>> Cheers, >>>>> >>>>> -Alexei >>>>> >>>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>>> Sure. I need a little handholding on making the diffs. >>>>>> Did you have in mind something like the following ? >>>>>> >>>>>> 1) I checkout a clean svn snapshot >>>>>> 2) make my changes >>>>>> 3) svn diff >>>>>> >>>>>> Geoffrey >>>>>> >>>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>>> <ale...@gm...> wrote: >>>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>>> of the files? >>>>>>> >>>>>>> -Alexei >>>>>>> >>>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>>> digital/audio cdroms. >>>>>>>> >>>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>>> here. Is it >>>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>>> inappropriate, is there >>>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>>> the cvs repository ? >>>>>>>> >>>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>>> tested on linux and OS X. >>>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>>> >>>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>>> and 2532 tracks (audio and raw >>>>>>>> data). There are other limitations, but those are the key ones. >>>>>>>> >>>>>>>> Geoffrey Brown >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>> and start using them to simplify application deployment and >>>>>>>> accelerate your shift to cloud computing. >>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>> _______________________________________________ >>>>>>>> basilisk-devel mailing list >>>>>>>> bas...@li... >>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Virtualization is moving to the mainstream and overtaking non-virtualized >> environment for deploying applications. Does it make network security >> easier or more difficult to achieve? Read this whitepaper to separate the >> two and get a better understanding. >> http://p.sf.net/sfu/hp-phase2-d2d >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> >> > > ------------------------------------------------------------------------------ > Virtualization is moving to the mainstream and overtaking non-virtualized > environment for deploying applications. Does it make network security > easier or more difficult to achieve? Read this whitepaper to separate the > two and get a better understanding. > http://p.sf.net/sfu/hp-phase2-d2d > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-10-04 23:32:43
|
One more thing I forgot to mention: Please put the license comment first - above your comment explaining the file. Begin the license comment with the name of the file and a one-line description of what it does (see how other files do it). Also, include your name in the Copyright in the license comment (unless you want your changes under some other license). After this, you can put the other comment that explains the file in more depth (limitations, etc) following the license comment. Thanks again, -Alexei On Mon, Oct 4, 2010 at 7:19 PM, Alexei Svitkine <ale...@gm...> wrote: > Hi Geoffrey, > > Patch looks mostly good, though I have a few comments: > > 1. In LoadCueSheet(), you call fstat() without checking the return > value for success - please handle the failure case. > > 2. I suggest refactoring the keyword parsing part of LoadCueSheet() > into a separate helper function to make the code more readable. Either > the whole while() itself or just the loop body. > > 3. You're still using non-Sheepshaver style braces / incorrect > indentation in fill_buffer(). In that block, I also suggest using > realloc() instead of free()/malloc() (and don't forget to free the > original buf if realloc() fails). > > 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block > is necessary? > > 5. Can you explain the logic in read_bincue()? It seems you're reading > by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by > 'available'. This seems incorrect to me, but I'm not familiar with the > format. > > 6. Can you make the first if in CDPlay_bincue consistent with the > similar ones in other functions (i.e. remove the extra parens)? > > 7. You're not checking the return value of lseek() in a couple of > places. Likewise with malloc()/strdup(). > > 8. I suggest using sprintf() in the "FILE" keyword handling section > instead of strcpy()+strcat()+srcat(). > > 9. Can there be multiple "FILE" keywords? If so, you'll be leaking > cs->binfile strings. > > 10. Please add D(bug()) lines in all the places in the keyword parsing > code where you goto fail. > > Please address the above comments and re-send the bincue_unix.cpp file. Thanks! > > -Alexei > > On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: >> Here's a second attempt. I added the appropriate license -- in reviewing my >> code it appears only dosbox contributed any code and this could easily >> be excised (though it uses the same gpl version as sheepshaver/basilisk). >> >> I've attempted to follow the existing brace style and made sure tabs are >> used instead of spaces. >> >> I've also made fixes 3 & 4. >> >> Geoffrey >> >> On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine >> <ale...@gm...> wrote: >>> Some comments: >>> >>> 1. >>> >>> "Includes ideas, even code fragments, from dosbox and libcdio hence >>> must obey those licences" >>> >>> What are their licenses? >>> >>> 2. >>> >>> Please use a consistent brace/indentation style as the rest of the >>> SheepShaver / Basilisk II codebases. Currently your code mixes and >>> matches tabs and space (the existing codebase is standardised on tabs) >>> and uses a different brace style then the rest of the code. >>> >>> 3. >>> >>> In audio_sdl.cpp, please include the relevant header instead of >>> declaring extern functions right before calling it. >>> >>> 4. >>> >>> Please update your CVS - the video_blit.cpp change already exists in trunk. >>> >>> Cheers, >>> >>> -Alexei >>> >>> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>>> <ale...@gm...> wrote: >>>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>>> >>>>> I suggest passing in -u to the diff command to get a unified diff >>>>> (easier to read). Also, if your changes involve modification to files >>>>> in both Basilisk and SheepShaver trees, you need to create two >>>>> patches, one from each tree. >>>>> >>>>> Cheers, >>>>> >>>>> -Alexei >>>>> >>>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>>> Sure. I need a little handholding on making the diffs. >>>>>> Did you have in mind something like the following ? >>>>>> >>>>>> 1) I checkout a clean svn snapshot >>>>>> 2) make my changes >>>>>> 3) svn diff >>>>>> >>>>>> Geoffrey >>>>>> >>>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>>> <ale...@gm...> wrote: >>>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>>> of the files? >>>>>>> >>>>>>> -Alexei >>>>>>> >>>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>>> digital/audio cdroms. >>>>>>>> >>>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>>> here. Is it >>>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>>> inappropriate, is there >>>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>>> the cvs repository ? >>>>>>>> >>>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>>> tested on linux and OS X. >>>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>>> >>>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>>> and 2532 tracks (audio and raw >>>>>>>> data). There are other limitations, but those are the key ones. >>>>>>>> >>>>>>>> Geoffrey Brown >>>>>>>> >>>>>>>> ------------------------------------------------------------------------------ >>>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>>> and start using them to simplify application deployment and >>>>>>>> accelerate your shift to cloud computing. >>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>>> _______________________________________________ >>>>>>>> basilisk-devel mailing list >>>>>>>> bas...@li... >>>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Virtualization is moving to the mainstream and overtaking non-virtualized >> environment for deploying applications. Does it make network security >> easier or more difficult to achieve? Read this whitepaper to separate the >> two and get a better understanding. >> http://p.sf.net/sfu/hp-phase2-d2d >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> >> > |
|
From: Alexei S. <ale...@gm...> - 2010-10-04 23:20:15
|
Hi Geoffrey, Patch looks mostly good, though I have a few comments: 1. In LoadCueSheet(), you call fstat() without checking the return value for success - please handle the failure case. 2. I suggest refactoring the keyword parsing part of LoadCueSheet() into a separate helper function to make the code more readable. Either the whole while() itself or just the loop body. 3. You're still using non-Sheepshaver style braces / incorrect indentation in fill_buffer(). In that block, I also suggest using realloc() instead of free()/malloc() (and don't forget to free the original buf if realloc() fails). 4. Can you add a comment explaining why the #ifndef SHEEPSHAVER block is necessary? 5. Can you explain the logic in read_bincue()? It seems you're reading by RAW_SECTOR_SIZE, but incrementing bytes_read / decrementing len by 'available'. This seems incorrect to me, but I'm not familiar with the format. 6. Can you make the first if in CDPlay_bincue consistent with the similar ones in other functions (i.e. remove the extra parens)? 7. You're not checking the return value of lseek() in a couple of places. Likewise with malloc()/strdup(). 8. I suggest using sprintf() in the "FILE" keyword handling section instead of strcpy()+strcat()+srcat(). 9. Can there be multiple "FILE" keywords? If so, you'll be leaking cs->binfile strings. 10. Please add D(bug()) lines in all the places in the keyword parsing code where you goto fail. Please address the above comments and re-send the bincue_unix.cpp file. Thanks! -Alexei On Mon, Oct 4, 2010 at 9:36 AM, Geoffrey Brown <geo...@in...> wrote: > Here's a second attempt. I added the appropriate license -- in reviewing my > code it appears only dosbox contributed any code and this could easily > be excised (though it uses the same gpl version as sheepshaver/basilisk). > > I've attempted to follow the existing brace style and made sure tabs are > used instead of spaces. > > I've also made fixes 3 & 4. > > Geoffrey > > On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine > <ale...@gm...> wrote: >> Some comments: >> >> 1. >> >> "Includes ideas, even code fragments, from dosbox and libcdio hence >> must obey those licences" >> >> What are their licenses? >> >> 2. >> >> Please use a consistent brace/indentation style as the rest of the >> SheepShaver / Basilisk II codebases. Currently your code mixes and >> matches tabs and space (the existing codebase is standardised on tabs) >> and uses a different brace style then the rest of the code. >> >> 3. >> >> In audio_sdl.cpp, please include the relevant header instead of >> declaring extern functions right before calling it. >> >> 4. >> >> Please update your CVS - the video_blit.cpp change already exists in trunk. >> >> Cheers, >> >> -Alexei >> >> On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >>> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >>> <ale...@gm...> wrote: >>>> If by svn, you mean cvs, then you've more or less got it. ;) >>>> >>>> I suggest passing in -u to the diff command to get a unified diff >>>> (easier to read). Also, if your changes involve modification to files >>>> in both Basilisk and SheepShaver trees, you need to create two >>>> patches, one from each tree. >>>> >>>> Cheers, >>>> >>>> -Alexei >>>> >>>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>>> Sure. I need a little handholding on making the diffs. >>>>> Did you have in mind something like the following ? >>>>> >>>>> 1) I checkout a clean svn snapshot >>>>> 2) make my changes >>>>> 3) svn diff >>>>> >>>>> Geoffrey >>>>> >>>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>>> <ale...@gm...> wrote: >>>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>>> of the files? >>>>>> >>>>>> -Alexei >>>>>> >>>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>>> digital/audio cdroms. >>>>>>> >>>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>>> here. Is it >>>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>>> inappropriate, is there >>>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>>> the cvs repository ? >>>>>>> >>>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>>> tested on linux and OS X. >>>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>>> >>>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>>> and 2532 tracks (audio and raw >>>>>>> data). There are other limitations, but those are the key ones. >>>>>>> >>>>>>> Geoffrey Brown >>>>>>> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Start uncovering the many advantages of virtual appliances >>>>>>> and start using them to simplify application deployment and >>>>>>> accelerate your shift to cloud computing. >>>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>>> _______________________________________________ >>>>>>> basilisk-devel mailing list >>>>>>> bas...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Virtualization is moving to the mainstream and overtaking non-virtualized > environment for deploying applications. Does it make network security > easier or more difficult to achieve? Read this whitepaper to separate the > two and get a better understanding. > http://p.sf.net/sfu/hp-phase2-d2d > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-04 13:36:09
|
Here's a second attempt. I added the appropriate license -- in reviewing my code it appears only dosbox contributed any code and this could easily be excised (though it uses the same gpl version as sheepshaver/basilisk). I've attempted to follow the existing brace style and made sure tabs are used instead of spaces. I've also made fixes 3 & 4. Geoffrey On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine <ale...@gm...> wrote: > Some comments: > > 1. > > "Includes ideas, even code fragments, from dosbox and libcdio hence > must obey those licences" > > What are their licenses? > > 2. > > Please use a consistent brace/indentation style as the rest of the > SheepShaver / Basilisk II codebases. Currently your code mixes and > matches tabs and space (the existing codebase is standardised on tabs) > and uses a different brace style then the rest of the code. > > 3. > > In audio_sdl.cpp, please include the relevant header instead of > declaring extern functions right before calling it. > > 4. > > Please update your CVS - the video_blit.cpp change already exists in trunk. > > Cheers, > > -Alexei > > On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> If by svn, you mean cvs, then you've more or less got it. ;) >>> >>> I suggest passing in -u to the diff command to get a unified diff >>> (easier to read). Also, if your changes involve modification to files >>> in both Basilisk and SheepShaver trees, you need to create two >>> patches, one from each tree. >>> >>> Cheers, >>> >>> -Alexei >>> >>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>> Sure. I need a little handholding on making the diffs. >>>> Did you have in mind something like the following ? >>>> >>>> 1) I checkout a clean svn snapshot >>>> 2) make my changes >>>> 3) svn diff >>>> >>>> Geoffrey >>>> >>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>> <ale...@gm...> wrote: >>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>> of the files? >>>>> >>>>> -Alexei >>>>> >>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>> digital/audio cdroms. >>>>>> >>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>> here. Is it >>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>> inappropriate, is there >>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>> the cvs repository ? >>>>>> >>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>> tested on linux and OS X. >>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>> >>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>> and 2532 tracks (audio and raw >>>>>> data). There are other limitations, but those are the key ones. >>>>>> >>>>>> Geoffrey Brown >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-10-02 17:38:38
|
Thanks for taking a close look, I'll take care of those and send you a fresh version. Geoffrey On Sat, Oct 2, 2010 at 11:40 AM, Alexei Svitkine <ale...@gm...> wrote: > Some comments: > > 1. > > "Includes ideas, even code fragments, from dosbox and libcdio hence > must obey those licences" > > What are their licenses? > > 2. > > Please use a consistent brace/indentation style as the rest of the > SheepShaver / Basilisk II codebases. Currently your code mixes and > matches tabs and space (the existing codebase is standardised on tabs) > and uses a different brace style then the rest of the code. > > 3. > > In audio_sdl.cpp, please include the relevant header instead of > declaring extern functions right before calling it. > > 4. > > Please update your CVS - the video_blit.cpp change already exists in trunk. > > Cheers, > > -Alexei > > On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: >> On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> If by svn, you mean cvs, then you've more or less got it. ;) >>> >>> I suggest passing in -u to the diff command to get a unified diff >>> (easier to read). Also, if your changes involve modification to files >>> in both Basilisk and SheepShaver trees, you need to create two >>> patches, one from each tree. >>> >>> Cheers, >>> >>> -Alexei >>> >>> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>>> Sure. I need a little handholding on making the diffs. >>>> Did you have in mind something like the following ? >>>> >>>> 1) I checkout a clean svn snapshot >>>> 2) make my changes >>>> 3) svn diff >>>> >>>> Geoffrey >>>> >>>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>>> <ale...@gm...> wrote: >>>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>>> of the files? >>>>> >>>>> -Alexei >>>>> >>>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>>> digital/audio cdroms. >>>>>> >>>>>> It's been suggested on the SheepShaver forum that I post those files >>>>>> here. Is it >>>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>>> inappropriate, is there >>>>>> somebody who would like to catch these files, possibly for checkin to >>>>>> the cvs repository ? >>>>>> >>>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>>> tested on linux and OS X. >>>>>> In Basilisk SDL audio works and has been tested on linux. >>>>>> >>>>>> The only bin/cue files my code supports are ones with a single binary >>>>>> and 2532 tracks (audio and raw >>>>>> data). There are other limitations, but those are the key ones. >>>>>> >>>>>> Geoffrey Brown >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Start uncovering the many advantages of virtual appliances >>>>>> and start using them to simplify application deployment and >>>>>> accelerate your shift to cloud computing. >>>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>>> _______________________________________________ >>>>>> basilisk-devel mailing list >>>>>> bas...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-10-02 15:41:32
|
Some comments: 1. "Includes ideas, even code fragments, from dosbox and libcdio hence must obey those licences" What are their licenses? 2. Please use a consistent brace/indentation style as the rest of the SheepShaver / Basilisk II codebases. Currently your code mixes and matches tabs and space (the existing codebase is standardised on tabs) and uses a different brace style then the rest of the code. 3. In audio_sdl.cpp, please include the relevant header instead of declaring extern functions right before calling it. 4. Please update your CVS - the video_blit.cpp change already exists in trunk. Cheers, -Alexei On Thu, Sep 30, 2010 at 9:07 AM, Geoffrey Brown <geo...@in...> wrote: > On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine > <ale...@gm...> wrote: >> If by svn, you mean cvs, then you've more or less got it. ;) >> >> I suggest passing in -u to the diff command to get a unified diff >> (easier to read). Also, if your changes involve modification to files >> in both Basilisk and SheepShaver trees, you need to create two >> patches, one from each tree. >> >> Cheers, >> >> -Alexei >> >> On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >>> Sure. I need a little handholding on making the diffs. >>> Did you have in mind something like the following ? >>> >>> 1) I checkout a clean svn snapshot >>> 2) make my changes >>> 3) svn diff >>> >>> Geoffrey >>> >>> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >>> <ale...@gm...> wrote: >>>> Can you make a patch of the changes (using diff) rather than a tar.gz >>>> of the files? >>>> >>>> -Alexei >>>> >>>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>>> for bin/cue files specifically to enable the use of (images of) mixed >>>>> digital/audio cdroms. >>>>> >>>>> It's been suggested on the SheepShaver forum that I post those files >>>>> here. Is it >>>>> appropriate to attach a tar.gz file to this list ? If that's >>>>> inappropriate, is there >>>>> somebody who would like to catch these files, possibly for checkin to >>>>> the cvs repository ? >>>>> >>>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>>> tested on linux and OS X. >>>>> In Basilisk SDL audio works and has been tested on linux. >>>>> >>>>> The only bin/cue files my code supports are ones with a single binary >>>>> and 2532 tracks (audio and raw >>>>> data). There are other limitations, but those are the key ones. >>>>> >>>>> Geoffrey Brown >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Start uncovering the many advantages of virtual appliances >>>>> and start using them to simplify application deployment and >>>>> accelerate your shift to cloud computing. >>>>> http://p.sf.net/sfu/novell-sfdev2dev >>>>> _______________________________________________ >>>>> basilisk-devel mailing list >>>>> bas...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > > |
|
From: Geoffrey B. <geo...@in...> - 2010-09-30 13:07:25
|
On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine <ale...@gm...> wrote: > If by svn, you mean cvs, then you've more or less got it. ;) > > I suggest passing in -u to the diff command to get a unified diff > (easier to read). Also, if your changes involve modification to files > in both Basilisk and SheepShaver trees, you need to create two > patches, one from each tree. > > Cheers, > > -Alexei > > On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >> Sure. I need a little handholding on making the diffs. >> Did you have in mind something like the following ? >> >> 1) I checkout a clean svn snapshot >> 2) make my changes >> 3) svn diff >> >> Geoffrey >> >> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> Can you make a patch of the changes (using diff) rather than a tar.gz >>> of the files? >>> >>> -Alexei >>> >>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>> for bin/cue files specifically to enable the use of (images of) mixed >>>> digital/audio cdroms. >>>> >>>> It's been suggested on the SheepShaver forum that I post those files >>>> here. Is it >>>> appropriate to attach a tar.gz file to this list ? If that's >>>> inappropriate, is there >>>> somebody who would like to catch these files, possibly for checkin to >>>> the cvs repository ? >>>> >>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>> tested on linux and OS X. >>>> In Basilisk SDL audio works and has been tested on linux. >>>> >>>> The only bin/cue files my code supports are ones with a single binary >>>> and 2532 tracks (audio and raw >>>> data). There are other limitations, but those are the key ones. >>>> >>>> Geoffrey Brown >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-09-30 01:51:31
|
ok (yes I meant cvs). So there will be two diff files -- one from each tree -- and two new files handling the bincue stuff for the src/Unix directory. I'll send them tomorrow from work. Geoffrey On Wed, Sep 29, 2010 at 9:47 PM, Alexei Svitkine <ale...@gm...> wrote: > If by svn, you mean cvs, then you've more or less got it. ;) > > I suggest passing in -u to the diff command to get a unified diff > (easier to read). Also, if your changes involve modification to files > in both Basilisk and SheepShaver trees, you need to create two > patches, one from each tree. > > Cheers, > > -Alexei > > On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: >> Sure. I need a little handholding on making the diffs. >> Did you have in mind something like the following ? >> >> 1) I checkout a clean svn snapshot >> 2) make my changes >> 3) svn diff >> >> Geoffrey >> >> On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine >> <ale...@gm...> wrote: >>> Can you make a patch of the changes (using diff) rather than a tar.gz >>> of the files? >>> >>> -Alexei >>> >>> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>>> for bin/cue files specifically to enable the use of (images of) mixed >>>> digital/audio cdroms. >>>> >>>> It's been suggested on the SheepShaver forum that I post those files >>>> here. Is it >>>> appropriate to attach a tar.gz file to this list ? If that's >>>> inappropriate, is there >>>> somebody who would like to catch these files, possibly for checkin to >>>> the cvs repository ? >>>> >>>> In SheepShaver, SDL audio and OS X core audio work and have been >>>> tested on linux and OS X. >>>> In Basilisk SDL audio works and has been tested on linux. >>>> >>>> The only bin/cue files my code supports are ones with a single binary >>>> and 2532 tracks (audio and raw >>>> data). There are other limitations, but those are the key ones. >>>> >>>> Geoffrey Brown >>>> >>>> ------------------------------------------------------------------------------ >>>> Start uncovering the many advantages of virtual appliances >>>> and start using them to simplify application deployment and >>>> accelerate your shift to cloud computing. >>>> http://p.sf.net/sfu/novell-sfdev2dev >>>> _______________________________________________ >>>> basilisk-devel mailing list >>>> bas...@li... >>>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-09-30 01:47:45
|
If by svn, you mean cvs, then you've more or less got it. ;) I suggest passing in -u to the diff command to get a unified diff (easier to read). Also, if your changes involve modification to files in both Basilisk and SheepShaver trees, you need to create two patches, one from each tree. Cheers, -Alexei On Wed, Sep 29, 2010 at 9:41 PM, Geoffrey Brown <geo...@in...> wrote: > Sure. I need a little handholding on making the diffs. > Did you have in mind something like the following ? > > 1) I checkout a clean svn snapshot > 2) make my changes > 3) svn diff > > Geoffrey > > On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine > <ale...@gm...> wrote: >> Can you make a patch of the changes (using diff) rather than a tar.gz >> of the files? >> >> -Alexei >> >> On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >>> I've developed changes to Basilisk and Sheepshaver to provide limited support >>> for bin/cue files specifically to enable the use of (images of) mixed >>> digital/audio cdroms. >>> >>> It's been suggested on the SheepShaver forum that I post those files >>> here. Is it >>> appropriate to attach a tar.gz file to this list ? If that's >>> inappropriate, is there >>> somebody who would like to catch these files, possibly for checkin to >>> the cvs repository ? >>> >>> In SheepShaver, SDL audio and OS X core audio work and have been >>> tested on linux and OS X. >>> In Basilisk SDL audio works and has been tested on linux. >>> >>> The only bin/cue files my code supports are ones with a single binary >>> and 2532 tracks (audio and raw >>> data). There are other limitations, but those are the key ones. >>> >>> Geoffrey Brown >>> >>> ------------------------------------------------------------------------------ >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> _______________________________________________ >>> basilisk-devel mailing list >>> bas...@li... >>> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >>> >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-09-30 01:41:25
|
Sure. I need a little handholding on making the diffs. Did you have in mind something like the following ? 1) I checkout a clean svn snapshot 2) make my changes 3) svn diff Geoffrey On Wed, Sep 29, 2010 at 9:25 PM, Alexei Svitkine <ale...@gm...> wrote: > Can you make a patch of the changes (using diff) rather than a tar.gz > of the files? > > -Alexei > > On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: >> I've developed changes to Basilisk and Sheepshaver to provide limited support >> for bin/cue files specifically to enable the use of (images of) mixed >> digital/audio cdroms. >> >> It's been suggested on the SheepShaver forum that I post those files >> here. Is it >> appropriate to attach a tar.gz file to this list ? If that's >> inappropriate, is there >> somebody who would like to catch these files, possibly for checkin to >> the cvs repository ? >> >> In SheepShaver, SDL audio and OS X core audio work and have been >> tested on linux and OS X. >> In Basilisk SDL audio works and has been tested on linux. >> >> The only bin/cue files my code supports are ones with a single binary >> and 2532 tracks (audio and raw >> data). There are other limitations, but those are the key ones. >> >> Geoffrey Brown >> >> ------------------------------------------------------------------------------ >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> _______________________________________________ >> basilisk-devel mailing list >> bas...@li... >> https://lists.sourceforge.net/lists/listinfo/basilisk-devel >> > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Alexei S. <ale...@gm...> - 2010-09-30 01:26:20
|
Can you make a patch of the changes (using diff) rather than a tar.gz of the files? -Alexei On Wed, Sep 29, 2010 at 9:20 AM, Geoffrey Brown <geo...@in...> wrote: > I've developed changes to Basilisk and Sheepshaver to provide limited support > for bin/cue files specifically to enable the use of (images of) mixed > digital/audio cdroms. > > It's been suggested on the SheepShaver forum that I post those files > here. Is it > appropriate to attach a tar.gz file to this list ? If that's > inappropriate, is there > somebody who would like to catch these files, possibly for checkin to > the cvs repository ? > > In SheepShaver, SDL audio and OS X core audio work and have been > tested on linux and OS X. > In Basilisk SDL audio works and has been tested on linux. > > The only bin/cue files my code supports are ones with a single binary > and 2532 tracks (audio and raw > data). There are other limitations, but those are the key ones. > > Geoffrey Brown > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
|
From: Geoffrey B. <geo...@in...> - 2010-09-29 13:20:22
|
I've developed changes to Basilisk and Sheepshaver to provide limited support for bin/cue files specifically to enable the use of (images of) mixed digital/audio cdroms. It's been suggested on the SheepShaver forum that I post those files here. Is it appropriate to attach a tar.gz file to this list ? If that's inappropriate, is there somebody who would like to catch these files, possibly for checkin to the cvs repository ? In SheepShaver, SDL audio and OS X core audio work and have been tested on linux and OS X. In Basilisk SDL audio works and has been tested on linux. The only bin/cue files my code supports are ones with a single binary and 2532 tracks (audio and raw data). There are other limitations, but those are the key ones. Geoffrey Brown |
|
From: Edward M. <em...@co...> - 2010-08-24 15:19:53
|
As a follow-up to my notes on the tilde/backtick key, here are some changes to the keycodes file that seem to make ordinary cursor movement possible under Windows with a modern keyboard: 71 115 # Home (was: 89 # KP 7) 72 62 # Cursor Up (was: 91 # KP 8) 73 116 # Page Up (was: 92 # KP 9) 75 59 # Cursor Left (was: 86 # KP 4) 77 60 # Cursor Right (was: 88 # KP 6) 79 119 # End (was: 83 # KP 1) 80 61 # Cursor Down (was: 84 # KP 2) 81 121 # Page Down(was: 85 # KP 3) 82 114 # Insert (was: 82 # KP 0) 83 117 # Del (was: 65 # KP .) I haven't tested these extensively. I don't know if they belong in the source code. The assignments for the four Cursor keys came from someone's posting on an old web page; I added the rest. Edward Mendelson |
|
From: Ronald P. R. <ron...@xs...> - 2010-08-24 09:57:52
|
Better ask support questions in the forum on E-Maculation site: <http://www.emaculation.com/> Ronald P. Regensburg. Op 24 aug 2010, om 11:26 heeft Natanael Arndt het volgende geschreven: > Hallo, > I'm trying set up a MacOS 9 on a MacOS X because my dad needs some 9 > programs (the default use-case of SheepShaver). > After playing around with the keycodes he has now a working keyboard, > and with the new JIT-Compiller also a very fast system. > But SheepShaver often hangs or crashes. Sometimes he has to click the > starter Icon 3× until the 9 is booting. > Is there a logfile in which I could look for the causes of these > crashes? Or is it possible to start SheepShaver with a verbose option? > > Thank you > Natanael > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > basilisk-devel mailing list > bas...@li... > https://lists.sourceforge.net/lists/listinfo/basilisk-devel > |
9 messages has been excluded from this view by a project administrator.
