From: R. B. <ro...@pa...> - 2006-08-03 12:36:45
|
Masatake YAMATO writes: > > As for a callback, I think that was to allow for the progress bars you > > had added. A callback seems generally useful and doesn't seem to > > signficantly slow down the program so why remove it? > > Weak reason: > I introduced callback for "read" because it is really slow. > However, "readarray" is fast enough. Callback may be useful > but it is not necessary. This is like Bill Gates saying you will never need a computer that uses more than 640K of memory. Okay, so readarray is isn't currently needed for script files in the situation that came up because they are only tens of thousands of lines long. Nobody reads in files that are millions of lines long because, well, it would just take forever without readarray. But should readarray or something like that become popular, perhaps people will use it for reading files other than script files which are orders of magnitudes larger. > > Strong reason: > When I send readarray.c.patch to the bash maintainer, I have > to explain what readarray is. To make the explanation I'll write > simple, I'd like to make readarray simple and small as possible > as I can. Without bashdb background, the maintainer may not > understand why callback is needed; and I may not explain well > the background to him. I don't think it is all that hard to understand or explain. (I do see this that I forgot to document this option. Don't think the background all all that deep either. But that said, you're doing the work; so do it any way you are comfortable. |