[Bashdb-devel] Re: Bugfix patch for V cmd.

[Mikael A. <sn...@te...>]

On Wednesday 06 August 2003 05.30, you wrote:
> I applied the patch and ran the debugger regression tests via:
> make check
>

*Bangs head on desk*, not literally though... 
Messed up a bit when switching to work with cvs. (redid some changes manually 
and forgot to test) it should be 'set' instead of shopt... An updated patch 
is attached (vcd-CVS-002.patch.

> The failure that bothers me is this one:
>
> --- /tmp/misc.check 2003-08-05 23:22:23.000000000 -0400
> +++ ./misc.right    2003-08-02 19:11:44.000000000 -0400
> @@ -550,9 +550,3 @@
>  *** Testing prompt and set tty...
>  bashdb's prompt is:
>         "bashdb${_Dbg_greater}$_Dbg_hi${_Dbg_less}$_Dbg_space".
> -noglob			off
> -../dbg-cmds.inc: line 556: shopt: +o: invalid shell option name
> -../dbg-cmds.inc: line 556: shopt: noglob: invalid shell option name
> -noglob		  off
> -../dbg-cmds.inc: line 556: shopt: +o: invalid shell option name
> -../dbg-cmds.inc: line 556: shopt: noglob: invalid shell option name
> --- /tmp/misc-output.check  2003-08-05 23:22:24.000000000 -0400
> +++ ./misc-output.right	    2003-08-02 15:37:35.000000000 -0400
> @@ -19,5 +19,3 @@
>   41:
>  dq_args="dq*"
>  dq_cmd="V"
> -dq_args="variables dq*"
> -dq_cmd="info"
> FAIL: run-misc
>
> Alas, I don't have time to investigate this right now.

As far as i understand the other tests was ok (some linenumbers were wrong
for me thou ) and that:
dq_args="variables dq*"
dq_cmd="info"
Should be the proper output from infor variables dq* if i understand it 
correctly. Attaching a patch whis updates tests with new line-numbers
and info variables output ( test-CVS-001.patch )

Also cvs seems to lack check_common.in in tests directory. I copied mine from
the v0.40 distribution.


I'll look into this and the linenumber issue i mentioned in the other mail. 
But we'll se if i'll be able to fix it. But i'll probably put off the 
linenumber issue until i've done with a proposed set of changes to 
automake/autoconf. 

Mostly adding som substitution variables so that you
can move things around freely with --prefix etc. Also moved .inc files to 
/usr/share/$package as this should be the proper location as they are arch 
independant. Not all packages do like this, but perl and emacs seems to do it 
that way. And FHS [1] seems to agree also.
Further i have enabled --program-transform-* (AC_ARG_PROGRAM macro) and added
an ALT_PACKAGE_NAME variable to be able to decide on what package name to use 
when installing.

Now i have some questions :
1) I have placed additional m4 macros in debugger/.. (ie bash-dir) in a file 
functions.m4. Is this a good idea or should i place them somewhere else ? The
are used in both bash configure.in and in debugger configure.ac

2) What should be default package name ? As it is now it's bash and with my 
changes that will lead to arch independent data being installed in 
/usr/local/share/bash if --prefix is /usr/local.

3) If i want to do side-by-side installation of bash and bashdb ( this is for 
use in gentoo) and not place it in /usr/local since /usr/local is reserved 
for system-administrator installed packages. And gentoo packages is not 
regarded as being in that category ( since otherwise all gentoo packages 
should fall in that category since they're all buld from scratch).
Have you got any suggestions as how to name the files ? It'd feels natural
to rename bash to bashdb and bashdb to bash-debugger (bdg .) ). but that
might be confusing to people who have already  used bashdb. 


/Mikael

[1] http://www.pathname.com/fhs/2.2