bashdb-devel

[Bashdb-devel] bashdb: make check vs. VPATH build

[Eric B. <eb...@by...>]

I'm having trouble getting 'make check' to work when doing a VPATH build. 
To reproduce:

$ tar xzvf bashdb-3.00-0.02.tar.gz
$ cd bashdb-3.00-0.02
$ mkdir build
$ cd build
$ ../configure
$ make
$ make check

The problem is that the 3.00-0.02 distribution includes generated files, 
which is a no-no from autoconf's perspective.  If dbg-main.inc is generated 
at configure time (which it is), then you should only distribute 
dbg-main.inc.in.  Otherwise, bashdb-3.00-0.02/dbg-main.inc is what you 
distributed (and remembers your value of PKGDATADIR, among others), even 
though I want 'make check' to test using my 
bashdb-3.00-0.02/build/dgb-main.inc (with my PKGDATADIR).  Likewise with 
test/check_common, and so forth.

I tried editing the distribution, to make sure the tests are run on the 
built copies, but it leads to another problem.  Now, since some of the .inc 
files are in $(srcdir), while others are in $(builddir), the uninstalled 
bashdb will not work with its -L argument, because there is no one single 
directory to include.  Maybe the solution to use from here is to generate 
all of the .inc files, even though most of them have no autoconf @patterns@ 
to be replaced.  So, this patch is a good start, but needs more work before 
'make check' will work on a VPATH build.

2005-07-30  Eric Blake  <eb...@by...>

	* test/Makefile.am (check_DATA): Don't distribute generated files.
	* Makefile.am (pkgdata_DATA): Ditto.
	(pkgdatadir): Fix definition.
	(install-data-hook): Create dirname BASHDB_MAIN, if needed.
	* configure.ac (BASHDB_MAIN): Allow --with-bashdb-main to work.
	* test/run-*: Use built check_common.


-- 
Someday, I might put a cute statement here.

Eric Blake             eb...@by...

[Bashdb-devel] bashdb: make check vs. VPATH build

[R. B. <ro...@pa...>]

Thanks for the patches and thanks for the analysis and report. I've
applied all that I could without breaking "make distcheck". The
ChangeLog entry has what was done.

As you note, more work is needed to make GNU make's VPATH work. 

I made an attempt to copy the debugger files dbg_*.inc from the source
directory to the build directory in configure.ac, but whatever I did
wasn't correct. Alas I tire easily of trying to coax configure.ac
and/or automake to do what strikes me as fairly straightforward
things. (Actually, a big motivation for the bash debugger itself is to
be able to cope better with the whole configuration/build system.). So
I leave this for someone else to work out or for some other time.

Some comments about the patches aside those already in the changelog
entry. In test/run-misc, I needed to set $builddir.  In your patch I
see some derived files which are not in CVS deleted, e.g.
dbg-pre.inc. So of course that doesn't do anything, but I guess it
does no harm either. 

Some derived files are still put in the distribution because of the -L
option problem in bashdb. You are correct that those should be removed
and would be were it not for my inability to know how to make "make
distcheck" work without doing so. On the other hand, if configure is
run as it should be those files should get overwritten.

Eric Blake writes:
 > I'm having trouble getting 'make check' to work when doing a VPATH build. 
...