Re: [Bashburn-info] Something funky in the config menu

[Nick W. <ni...@li...>]

On Wed, 24 Sep 2008 20:42:33 -0400 (EDT)
"Steven W. Orr" <st...@sy...> wrote:

> On Wednesday, Sep 24th 2008 at 17:17 -0000, quoth Anders Lind?n:
> 
> =>I noticed some weird behaviour in the config menu.
> =>
> =>I switched from English to Swedish and applied my changes without
> =>exiting the config menu. When choosing an option in the config
> menu, the =>description is now in Swedish as it should be. I can exit
> the config =>menu, go back to it and the descriptions are in Swedish
> still. 
> 
> Should I shut down BB, start it again and then enter the config menu,
> the menu itself is still in Swedish, but the descriptions are now in
> English. Very strange.
>
>
> I traced that back to BashBurn.sh which is doing this:
> 
> source_language_modules
> . ${BBROOTDIR}/misc/configure_temp_help.lang
> 
> We call source_language_modules to set the variables to be in the
> proper language and *then* we source in configure_temp_help.lang
> which overwrites some of the variables we defined. I just commented
> it out because if the default is to provide text in English then I
> thought we were already doing that just before calling
> source_language_modules.
> 
> if [[ ! -d ${BBROOTDIR}/lang/${BBLANG} ]]
> then
>     blah...
>     sleep 3s
>     # Since the set language did not exist,
>     # set it to English and save the option
>     # so that in the future this message is not
>     # shown again.
>     BBLANG=English
>     apply_options
> fi
> 
> So I'm at a loss to understand what the purpose is of C_T_H.lang and
> since it contains duplicate variable defs, it absolutely should be
> deleted. No?
> 
> =>Should I shut down BB, start it again and then enter the config
> menu, =>the menu itself is still in Swedish, but the descriptions are
> now in =>English. Very strange.
> 
> Fixed by commenting out . ${BBROOTDIR}/misc/configure_temp_help.lang

OK, this was my fault.  The idea is that if the $LANG configure.lang
file has not yet been updated to have the new 'description' variables
(see lang/Italian/configure.lang for an example), then NO help text is
printed at all.  So what should happen is these variables get set
instead from configure_temp_help.lang, so at least there is help,
albeit in English.

This is now fixed again correctly.  I should have sourced
configure_temp_help.lang FIRST, so that it doesn't clobbered $LANG
configure.lang files that have the correct $VAR

My testing shows this now works as it should.  Anders, please attempt
to replicate previous error.

Remember, as the name implies, this is only a temporary hack until all
the configure.lang files are updated.  I have commented so in the code.

Nick
-- 
Free Software Foundation Associate Member 5508