[Bashburn-info] Multiple problems in burning.sh

[Steven W. O. <st...@sy...>]

I'm fixing so many things here that I must be breaking things.

* data_burning seems to think that BBLABEL is allowed to have some special 
escape value called '<ask-me>'. If it does then it asks for a value and 
does not update the configuration file. Is this correct behavior in any 
world? What is correct?

* I need people to closely look at what I did in burning.sh and 
audiofunc.sh There are lots of changes. The code that I touched was in 
many cases obviously broken and could never have worked in the past.

* There are a lot of global variables that were removed. Look at 
set_session_type and dvd_data_burning for an example.

* I identified a lot of variables that needed to be made local and flipped 
them all to lower case.

* In the function encode_filter, it looks at the value of $ENCODEFILTER 
and does something. AFAICT, ENCODEFILTER is never set. encode_filter is 
called in a bunch of places in audiofunc.sh

* I consolidated a lot of functions is audiofunc.sh

* There were about a zillion calls to wait_for_enter. Most have been 
removed because they were set up a la

if xxx
then
     do somthing
     wait_for_enter
else
     do somthing else
     wait_for_enter
fi

Now they look like

if xxx
then
     do somthing
else
     do somthing else
fi
wait_for_enter

* I need someone to look at dvd_image_burn. It's flat out wrong.

if ${BB_DVDBURNCMD} -dvd-compat \
   -Z ${BBCDWRITER}=${BBBURNDIR}/$(ls ${BBBURNDIR} | grep -i $imagetype)

This is just plain illegal syntax. I don't understand what the goal is. 
Tell me and I can fix it.

* pipeline_burning had a number of variables that were mis-spelled. I need 
people to look at this and verify. Look at a variable that used to be 
there called IFOF. :-(

* There was a wackobanana construct in pipeline_burning that made me very 
sad:

echo ${COUNTER-MP3} $( echo $(basename "${FILE}") | head -c35 ) \
  flushed into ${FIFO} \(pipe\).

is now

pfile=${file##*/}
echo "${counter-MP3} ${pfile:0:35} flushed into ${fifo} (pipe)."

But I'd like to know where the 35 came from.

* All of the case management stuff is now exorcised via use of
shopt -s nocaseglob
shopt -u nocaseglob


So, to reiterate: PLEASE LOOK AT WHAT I DID. I need to be kept honest. 
Like I said before, there were a number of things that clearly could never 
have worked before.

-- 
Time flies like the wind. Fruit flies like a banana. Stranger things have  .0.
happened but none stranger than this. Does your driver's license say Organ ..0
Donor?Black holes are where God divided by zero. Listen to me! We are all- 000
individuals! What if this weren't a hypothetical question?
steveo at syslang.net