Re: [Bashburn-info] Some updates

[Steven W. O. <st...@sy...>]

On Friday, Aug 29th 2008 at 18:16 -0000, quoth Anders Lind?n:

=>I added a convert_audio.sh file which will replace
=>convert_mp3/ogg/flac.sh. Also got rid of the error message about
=>returning a non-numerical value by rewriting the check_for_*
=>functions. Added function convert_if_exist which check if files with
=>the supplied file extension exists, and if so runs the appropriate
=>converting function.
=>
=>I'm sure the code can be improved (It's late here dammit) so check it out.

Ok, I made a few changes.

Instead of passing *.mp3 or *.ogg to convert_audio, I made it an option, a 
la 
convert_audio --mp3
or
convert_audio --ogg

I have an allergy to passing globs around because you don't really always 
know when they're going to expand on you. (BTW, you hadn't tested for 
ogg.)

I added a read variable in check_for. Otherwise you're using the implicit 
global variable REPLY.

No big deal, but I moved convert_audio higher in Install.sh so that the 
files were kept in alphabetical order.

And in menus/audio_menus.sh, it was calling burning.sh instead of burning.

:-)

-- 
Time flies like the wind. Fruit flies like a banana. Stranger things have  .0.
happened but none stranger than this. Does your driver's license say Organ ..0
Donor?Black holes are where God divided by zero. Listen to me! We are all- 000
individuals! What if this weren't a hypothetical question?
steveo at syslang.net