bashburn-info Mailing List for BashBurn (Page 5)
Brought to you by:
bashburn
Menu
▾
▴
bashburn-info — BashBurn mailing list
You can subscribe to this list here.
| 2005 |
Jan
|
Feb
(3) |
Mar
|
Apr
(31) |
May
(5) |
Jun
(10) |
Jul
(21) |
Aug
(9) |
Sep
(9) |
Oct
(5) |
Nov
|
Dec
(17) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2006 |
Jan
(4) |
Feb
(7) |
Mar
|
Apr
(6) |
May
(1) |
Jun
|
Jul
|
Aug
(5) |
Sep
|
Oct
(7) |
Nov
(3) |
Dec
(17) |
| 2007 |
Jan
(2) |
Feb
|
Mar
(2) |
Apr
|
May
(1) |
Jun
(1) |
Jul
(7) |
Aug
|
Sep
|
Oct
(1) |
Nov
(1) |
Dec
|
| 2008 |
Jan
|
Feb
|
Mar
(2) |
Apr
|
May
(1) |
Jun
|
Jul
(8) |
Aug
(114) |
Sep
(283) |
Oct
(128) |
Nov
|
Dec
(1) |
|
From: Nick W. <ni...@uk...> - 2008-10-02 15:31:59
|
On Thu, 2 Oct 2008 16:12:11 +0100 Nick Warne <ni...@li...> wrote: > If at first you don't succeed, try, try again UNTIL the bloody thing > does work :-) > > Date: Thu, 2 Oct 2008 15:37:51 +0100 > From: Nick Warne <ni...@li...> > To: <and...@gm...>, "Steven W. Orr" <st...@sy...> > Subject: Fw: [Bashburn-info] Functionality TESTING thread > > > > For some reason my mails to the list randomly do not appear... > > Begin forwarded message: > > Date: Thu, 2 Oct 2008 15:34:55 +0100 > From: Nick Warne <ni...@li...> > To: bashburn <Bas...@li...> > Subject: Re: [Bashburn-info] Functionality TESTING thread > > > On Thu, 02 Oct 2008 15:53:01 +0200 > Anders Lindén <and...@gm...> wrote: > > > > > > Keep this tidy!. > > > > > > Data recording WORKS > > > > > > Burning ISO works > > > > > > HD file to CD (data recording) - works > > > > > > Data DVD burning works. > > > > > > *.mp3 to Audio CD works. > > > > > > CD ripping to *.ogg -> hard drive works > > > > > > CD ripping to *.mp3 -> hard drive works > > > > > > CD ripping to *.flac -> hard drive works > > > > > > AudioCD-CD copy works > > > > > > Copy Audio CD [CD to harddrive] - works > > > > > > Create Mp3s from Wavs - works > > > > > > Create Oggs from Wavs - works > > > > > > Create Flacs from Wavs - works > > > > > > Create ISO from files in <burn directory> - works > > > > > > Data CD to CD (copy) - works > > > > > > *.ogg to Audio CD - works > > > > > > *.flac to Audio CD - works > > > > > > *.wav to Audio CD - works > > > > Create ISO from CD (And edit mounted ISO) - works > > > Setting up two CD drives and configuring - works > > Burning Audio CD from CD reader -> CD Burner - works! (how trick is > that!!) > > Copy Data CD -> Data CD (two drives) - works > > -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@uk...> - 2008-10-02 15:25:16
|
It appears a lot of my mails do not ever hit the list, no matter what address I use. -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-02 15:12:21
|
If at first you don't succeed, try, try again UNTIL the bloody thing does work :-) Date: Thu, 2 Oct 2008 15:37:51 +0100 From: Nick Warne <ni...@li...> To: <and...@gm...>, "Steven W. Orr" <st...@sy...> Subject: Fw: [Bashburn-info] Functionality TESTING thread For some reason my mails to the list randomly do not appear... Begin forwarded message: Date: Thu, 2 Oct 2008 15:34:55 +0100 From: Nick Warne <ni...@li...> To: bashburn <Bas...@li...> Subject: Re: [Bashburn-info] Functionality TESTING thread On Thu, 02 Oct 2008 15:53:01 +0200 Anders Lindén <and...@gm...> wrote: > > > Keep this tidy!. > > > > Data recording WORKS > > > > Burning ISO works > > > > HD file to CD (data recording) - works > > > > Data DVD burning works. > > > > *.mp3 to Audio CD works. > > > > CD ripping to *.ogg -> hard drive works > > > > CD ripping to *.mp3 -> hard drive works > > > > CD ripping to *.flac -> hard drive works > > > > AudioCD-CD copy works > > > > Copy Audio CD [CD to harddrive] - works > > > > Create Mp3s from Wavs - works > > > > Create Oggs from Wavs - works > > > > Create Flacs from Wavs - works > > > > Create ISO from files in <burn directory> - works > > > > Data CD to CD (copy) - works > > > > *.ogg to Audio CD - works > > > > *.flac to Audio CD - works > > > > *.wav to Audio CD - works > > Create ISO from CD (And edit mounted ISO) - works Setting up two CD drives and configuring - works Burning Audio CD from CD reader -> CD Burner - works! (how trick is that!!) Copy Data CD -> Data CD (two drives) - works -- Free Software Foundation Associate Member 5508 -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@uk...> - 2008-10-02 15:08:57
|
Please ignore -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-02 14:37:29
|
On Thu, 02 Oct 2008 15:53:01 +0200 Anders Lindén <and...@gm...> wrote: > > > Keep this tidy!. > > > > Data recording WORKS > > > > Burning ISO works > > > > HD file to CD (data recording) - works > > > > Data DVD burning works. > > > > *.mp3 to Audio CD works. > > > > CD ripping to *.ogg -> hard drive works > > > > CD ripping to *.mp3 -> hard drive works > > > > CD ripping to *.flac -> hard drive works > > > > AudioCD-CD copy works > > > > Copy Audio CD [CD to harddrive] - works > > > > Create Mp3s from Wavs - works > > > > Create Oggs from Wavs - works > > > > Create Flacs from Wavs - works > > > > Create ISO from files in <burn directory> - works > > > > Data CD to CD (copy) - works > > > > *.ogg to Audio CD - works > > > > *.flac to Audio CD - works > > > > *.wav to Audio CD - works > > Create ISO from CD (And edit mounted ISO) - works Setting up two CD drives and configuring - works Burning Audio CD from CD reader -> CD Burner - works! (how trick is that!!) Copy Data CD -> Data CD (two drives) - works -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-02 14:24:54
|
On Thu, 2 Oct 2008 11:29:00 +0100 Nick Warne <ni...@li...> wrote: > On Thu, 2 Oct 2008 10:45:40 +0100 > Nick Warne <ni...@li... wrote: > > > Keep this tidy!. > > Data recording WORKS > > Burning ISO works > > HD file to CD (data recording) - works > > Data DVD burning works. > > *.mp3 to Audio CD works. > > CD ripping to *.ogg - hard drive works > > CD ripping to *.mp3 - hard drive works > > CD ripping to *.flac - hard drive works > > AudioCD-> CD copy works > > Copy Audio CD [CD to harddrive] - works > > Create Mp3s from Wavs - works > > Create Oggs from Wavs - works > > Create Flacs from Wavs - works > > Create ISO from files in <burn directory - works > > Data CD to CD (copy) - works > > *.ogg to Audio CD - works > > *.flac to Audio CD - works Setting up two CD drives and configuring - works Burning Audio CD from CD reader -> CD Burner - works! (how trick is that!!) -- Free Software Foundation Associate Member 5508 |
|
From: Anders L. <and...@gm...> - 2008-10-02 14:07:41
|
> Keep this tidy!. > > Data recording WORKS > > Burning ISO works > > HD file to CD (data recording) - works > > Data DVD burning works. > > *.mp3 to Audio CD works. > > CD ripping to *.ogg -> hard drive works > > CD ripping to *.mp3 -> hard drive works > > CD ripping to *.flac -> hard drive works > > AudioCD-CD copy works > > Copy Audio CD [CD to harddrive] - works > > Create Mp3s from Wavs - works > > Create Oggs from Wavs - works > > Create Flacs from Wavs - works > > Create ISO from files in <burn directory> - works > > Data CD to CD (copy) - works > > *.ogg to Audio CD - works > > *.flac to Audio CD - works > > *.wav to Audio CD - works Create ISO from CD (And edit mounted ISO) - works |
|
From: Nick W. <ni...@li...> - 2008-10-02 13:15:54
|
On Thu, 2 Oct 2008 11:29:00 +0100 Nick Warne <ni...@li...wrote: Keep this tidy!. Data recording WORKS Burning ISO works HD file to CD (data recording) - works Data DVD burning works. *.mp3 to Audio CD works. CD ripping to *.ogg -> hard drive works CD ripping to *.mp3 -> hard drive works CD ripping to *.flac -> hard drive works AudioCD-CD copy works Copy Audio CD [CD to harddrive] - works Create Mp3s from Wavs - works Create Oggs from Wavs - works Create Flacs from Wavs - works Create ISO from files in <burn directory> - works Data CD to CD (copy) - works *.ogg to Audio CD - works *.flac to Audio CD - works *.wav to Audio CD - works -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-02 10:29:08
|
On Thu, 2 Oct 2008 10:45:40 +0100 Nick Warne <ni...@li... wrote: Keep this tidy!. Data recording WORKS Burning ISO works HD file to CD (data recording) - works Data DVD burning works. *.mp3 to Audio CD works. CD ripping to *.ogg - hard drive works CD ripping to *.mp3 - hard drive works CD ripping to *.flac - hard drive works AudioCD-> CD copy works Copy Audio CD [CD to harddrive] - works Create Mp3s from Wavs - works Create Oggs from Wavs - works Create Flacs from Wavs - works Create ISO from files in <burn directory - works Data CD to CD (copy) - works *.ogg to Audio CD - works *.flac to Audio CD - works -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-02 09:45:59
|
On Wed, 1 Oct 2008 14:01:37 +0100 Nick Warne <ni...@li...> wrote: Keep this tidy!. Data recording WORKS Burning ISO works HD file to CD (data recording) - works Data DVD burning works. MP3 to Audio CD works. CD ripping to *.ogg -> hard drive works CD ripping to *.mp3 -> hard drive works CD ripping to *.flac -> hard drive works AudioCD-> CD copy works Copy Audio CD [CD to harddrive] - works Create Mp3s from Wavs - works Create Oggs from Wavs - works Create Flacs from Wavs - works Create ISO from files in <burn directory> - works Data CD to CD (copy) - works -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-02 09:28:09
|
On Thu, 2 Oct 2008 09:08:26 +0100
Nick Warne <ni...@li...> wrote:
> On Wed, 1 Oct 2008 15:41:41 -0400 (EDT)
> "Steven W. Orr" <st...@sy...> wrote:
>
>
> > =>No, I didn't analyse it at all.
> > =>
> > =>1) Copy Data CD (CD to CD)
> > =>
> > =>is where this issue is. I haven't looked at code at due to
> > testing all =>the other stuff.
> >
> > I just looked at the code and it looks funny (not ha ha funny). What
> > we're basically doing, I think, is this:
> >
> > mkisofs | cdrecord
> >
> > which is probably ok. But what's coded is this:
> >
> > mkisofs -o fn.iso | cdrecord fn.iso
> >
> > If cdrecord gets a filename arg on the commandline then it's not
> > going to read from its pipe. Same for mkisofs:
> >
> > -o filename
> > is the name of the file to which the iso9660
> > filesystem image should be written. This can be a disk file, a tape
> > drive, or it can correspond directly to the device name of the
> > optical disc writer. If not specified, stdout is used. Note that
> > the output can also be a block special device for a regular disk
> > drive, in which case the disk partition can be mounted and
> > examined to ensure that the premastering was done correctly.
> >
> > The last person to put his dirty mitss on this module before I
> > hacked on it was (drum roll please) Anders on rev 388. Anders, can
> > you look at this one? What we currently have is this
> >
> > mkfifo BBCDCOPY
> > ${BB_READCD} ${BB_READ_OPTS} -o ${BBBURNDIR}/BashBurn.iso \
> > ${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER}
> > ${BBDTAO} \ -v -data -eject ${BBBURNDIR}/BashBurn.iso
> > echo $bb_dm_ch2_5
> > rm ${BBBURNDIR}/BashBurn.iso
> >
> > and I think it should be this
> >
> > ${BB_READCD} ${BB_READ_OPTS} \
> > ${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER}
> > ${BBDTAO} \ -v -data -eject
> > echo $bb_dm_ch2_5
> >
> > Also note that the mkfifo and the rm should be removed.
>
> OK, this isn't what I was talking about.
>
> This is what needs to happen.
>
> Test there is a data disc mounted/there is data in the mount point
> (otherwise it carries on and tries to burn nothing).
>
> After the data has been burnt to disc, umount the disc before asking
> user to insert a blank CD.
OK, I have attempted to fix that up.
It is a bit hairy, but I don't know what else to do.
I check if the device mount point $BBCDMNT is mounted
Then later umount it, eject, before we get asked to put in a blank CD.
This, of course, will all fail if the device is wrong, or if it is
mounted elsewhere. But its better than what we had.
Nick
--
Free Software Foundation Associate Member 5508
|
|
From: Nick W. <ni...@li...> - 2008-10-02 08:08:43
|
On Wed, 1 Oct 2008 15:41:41 -0400 (EDT)
"Steven W. Orr" <st...@sy...> wrote:
> =>No, I didn't analyse it at all.
> =>
> =>1) Copy Data CD (CD to CD)
> =>
> =>is where this issue is. I haven't looked at code at due to testing
> all =>the other stuff.
>
> I just looked at the code and it looks funny (not ha ha funny). What
> we're basically doing, I think, is this:
>
> mkisofs | cdrecord
>
> which is probably ok. But what's coded is this:
>
> mkisofs -o fn.iso | cdrecord fn.iso
>
> If cdrecord gets a filename arg on the commandline then it's not
> going to read from its pipe. Same for mkisofs:
>
> -o filename
> is the name of the file to which the iso9660
> filesystem image should be written. This can be a disk file, a tape
> drive, or it can correspond directly to the device name of the
> optical disc writer. If not specified, stdout is used. Note that
> the output can also be a block special device for a regular disk
> drive, in which case the disk partition can be mounted and
> examined to ensure that the premastering was done correctly.
>
> The last person to put his dirty mitss on this module before I hacked
> on it was (drum roll please) Anders on rev 388. Anders, can you look
> at this one? What we currently have is this
>
> mkfifo BBCDCOPY
> ${BB_READCD} ${BB_READ_OPTS} -o ${BBBURNDIR}/BashBurn.iso \
> ${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER}
> ${BBDTAO} \ -v -data -eject ${BBBURNDIR}/BashBurn.iso
> echo $bb_dm_ch2_5
> rm ${BBBURNDIR}/BashBurn.iso
>
> and I think it should be this
>
> ${BB_READCD} ${BB_READ_OPTS} \
> ${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER}
> ${BBDTAO} \ -v -data -eject
> echo $bb_dm_ch2_5
>
> Also note that the mkfifo and the rm should be removed.
OK, this isn't what I was talking about.
This is what needs to happen.
Test there is a data disc mounted/there is data in the mount point
(otherwise it carries on and tries to burn nothing).
After the data has been burnt to disc, umount the disc before asking
user to insert a blank CD.
Nick
--
Free Software Foundation Associate Member 5508
|
|
From: Anders L. <and...@gm...> - 2008-10-01 20:25:56
|
ons 2008-10-01 klockan 15:41 -0400 skrev Steven W. Orr:
> On Wednesday, Oct 1st 2008 at 15:01 -0000, quoth Nick Warne:
>
> =>On Wed, 1 Oct 2008 10:59:49 -0400 (EDT)
> =>"Steven W. Orr" <st...@sy...> wrote:
> =>
> =>> On Wednesday, Oct 1st 2008 at 09:53 -0000, quoth Fabian Stietzel:
> =>>
> =>> =>Steven W. Orr wrote:
> =>> =>> * The copy command is using globbing. Globbing is evil. We need
> =>> to only =>> copy files that are explicitly specified. If you copy by
> =>> saying something =>> like...
> =>> =>>
> =>> =>The shell is globbing. cp will never do it. It's the shell. The
> =>> globbing =>can be avoided easily by using single quotation marks.
> =>> =>
> =>> =>> cp dir/* somewhere/
> =>> =>>
> =>> =>> Then there's no way to detect that the cp didn't pick something
> =>> up. We =>> have to either verify that the disk is mounted and/or we
> =>> have to always =>> specify explict files. DEATH TO GLOBBING.
> =>> =>>
> =>> =>>
> =>> =>Of course you can detect if cd "didn't pick something up". cd will
> =>> pick =>every file supplied as a command line argument before the last
> =>> (target). =>if someting goes wrong the return value/exit code of cd
> =>> will not be 0. =>the shell does the globbing, thus instead of
> =>> 'dir/*', 'dir/a' 'dir/b' is =>supplied to cp as command line argument
> =>> if 'dir/a' and 'dir/b' exist. =>
> =>> =>If you do something like 'cp dir/* somewhere/' you will get an
> =>> error if =>'dir/' is empty. This is because if 'dir/' is empty the
> =>> shell will not =>do globbing for the asterisk. So cp will complain
> =>> that it can't find the =>file 'dir/*'. I think before doing major
> =>> changes here...maybe somebody =>just forgot to check $? after the cp
> =>> invocation. =>
> =>> =>
> =>> =>Just my 2 cents,
> =>> =>Fabian
> =>>
> =>> Thanks Fabian. Certainly worth checking. Nick, do you know what code
> =>> we're talking about here? Where is this cp command in question?
> =>>
> =>
> =>No, I didn't analyse it at all.
> =>
> =>1) Copy Data CD (CD to CD)
> =>
> =>is where this issue is. I haven't looked at code at due to testing all
> =>the other stuff.
>
> I just looked at the code and it looks funny (not ha ha funny). What we're
> basically doing, I think, is this:
>
> mkisofs | cdrecord
>
> which is probably ok. But what's coded is this:
>
> mkisofs -o fn.iso | cdrecord fn.iso
>
> If cdrecord gets a filename arg on the commandline then it's not going to
> read from its pipe. Same for mkisofs:
>
> -o filename
> is the name of the file to which the iso9660 filesystem image
> should be written. This can be a disk file, a tape drive, or it
> can correspond directly to the device name of the optical disc
> writer. If not specified, stdout is used. Note that the output
> can also be a block special device for a regular disk drive, in
> which case the disk partition can be mounted and examined to
> ensure that the premastering was done correctly.
>
> The last person to put his dirty mitss on this module before I hacked on
> it was (drum roll please) Anders on rev 388. Anders, can you look at this
> one? What we currently have is this
>
> mkfifo BBCDCOPY
> ${BB_READCD} ${BB_READ_OPTS} -o ${BBBURNDIR}/BashBurn.iso \
> ${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER} ${BBDTAO} \
> -v -data -eject ${BBBURNDIR}/BashBurn.iso
> echo $bb_dm_ch2_5
> rm ${BBBURNDIR}/BashBurn.iso
>
> and I think it should be this
>
> ${BB_READCD} ${BB_READ_OPTS} \
> ${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER} ${BBDTAO} \
> -v -data -eject
> echo $bb_dm_ch2_5
>
> Also note that the mkfifo and the rm should be removed.
>
I did that? Bad me. Your fix looks correct to me.
--
Anders Lindén
http://bashburn.sf.net
|
|
From: Steven W. O. <st...@sy...> - 2008-10-01 19:41:52
|
On Wednesday, Oct 1st 2008 at 15:01 -0000, quoth Nick Warne:
=>On Wed, 1 Oct 2008 10:59:49 -0400 (EDT)
=>"Steven W. Orr" <st...@sy...> wrote:
=>
=>> On Wednesday, Oct 1st 2008 at 09:53 -0000, quoth Fabian Stietzel:
=>>
=>> =>Steven W. Orr wrote:
=>> =>> * The copy command is using globbing. Globbing is evil. We need
=>> to only =>> copy files that are explicitly specified. If you copy by
=>> saying something =>> like...
=>> =>>
=>> =>The shell is globbing. cp will never do it. It's the shell. The
=>> globbing =>can be avoided easily by using single quotation marks.
=>> =>
=>> =>> cp dir/* somewhere/
=>> =>>
=>> =>> Then there's no way to detect that the cp didn't pick something
=>> up. We =>> have to either verify that the disk is mounted and/or we
=>> have to always =>> specify explict files. DEATH TO GLOBBING.
=>> =>>
=>> =>>
=>> =>Of course you can detect if cd "didn't pick something up". cd will
=>> pick =>every file supplied as a command line argument before the last
=>> (target). =>if someting goes wrong the return value/exit code of cd
=>> will not be 0. =>the shell does the globbing, thus instead of
=>> 'dir/*', 'dir/a' 'dir/b' is =>supplied to cp as command line argument
=>> if 'dir/a' and 'dir/b' exist. =>
=>> =>If you do something like 'cp dir/* somewhere/' you will get an
=>> error if =>'dir/' is empty. This is because if 'dir/' is empty the
=>> shell will not =>do globbing for the asterisk. So cp will complain
=>> that it can't find the =>file 'dir/*'. I think before doing major
=>> changes here...maybe somebody =>just forgot to check $? after the cp
=>> invocation. =>
=>> =>
=>> =>Just my 2 cents,
=>> =>Fabian
=>>
=>> Thanks Fabian. Certainly worth checking. Nick, do you know what code
=>> we're talking about here? Where is this cp command in question?
=>>
=>
=>No, I didn't analyse it at all.
=>
=>1) Copy Data CD (CD to CD)
=>
=>is where this issue is. I haven't looked at code at due to testing all
=>the other stuff.
I just looked at the code and it looks funny (not ha ha funny). What we're
basically doing, I think, is this:
mkisofs | cdrecord
which is probably ok. But what's coded is this:
mkisofs -o fn.iso | cdrecord fn.iso
If cdrecord gets a filename arg on the commandline then it's not going to
read from its pipe. Same for mkisofs:
-o filename
is the name of the file to which the iso9660 filesystem image
should be written. This can be a disk file, a tape drive, or it
can correspond directly to the device name of the optical disc
writer. If not specified, stdout is used. Note that the output
can also be a block special device for a regular disk drive, in
which case the disk partition can be mounted and examined to
ensure that the premastering was done correctly.
The last person to put his dirty mitss on this module before I hacked on
it was (drum roll please) Anders on rev 388. Anders, can you look at this
one? What we currently have is this
mkfifo BBCDCOPY
${BB_READCD} ${BB_READ_OPTS} -o ${BBBURNDIR}/BashBurn.iso \
${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER} ${BBDTAO} \
-v -data -eject ${BBBURNDIR}/BashBurn.iso
echo $bb_dm_ch2_5
rm ${BBBURNDIR}/BashBurn.iso
and I think it should be this
${BB_READCD} ${BB_READ_OPTS} \
${BBCDMNT} | ${BB_CDBURNCMD} dev=${BBCDWRITER} ${BBDTAO} \
-v -data -eject
echo $bb_dm_ch2_5
Also note that the mkfifo and the rm should be removed.
--
Time flies like the wind. Fruit flies like a banana. Stranger things have .0.
happened but none stranger than this. Does your driver's license say Organ ..0
Donor?Black holes are where God divided by zero. Listen to me! We are all- 000
individuals! What if this weren't a hypothetical question?
steveo at syslang.net
|
|
From: Nick W. <ni...@li...> - 2008-10-01 19:01:18
|
On Wed, 1 Oct 2008 10:59:49 -0400 (EDT) "Steven W. Orr" <st...@sy...> wrote: > On Wednesday, Oct 1st 2008 at 09:53 -0000, quoth Fabian Stietzel: > > =>Steven W. Orr wrote: > =>> * The copy command is using globbing. Globbing is evil. We need > to only =>> copy files that are explicitly specified. If you copy by > saying something =>> like... > =>> > =>The shell is globbing. cp will never do it. It's the shell. The > globbing =>can be avoided easily by using single quotation marks. > => > =>> cp dir/* somewhere/ > =>> > =>> Then there's no way to detect that the cp didn't pick something > up. We =>> have to either verify that the disk is mounted and/or we > have to always =>> specify explict files. DEATH TO GLOBBING. > =>> > =>> > =>Of course you can detect if cd "didn't pick something up". cd will > pick =>every file supplied as a command line argument before the last > (target). =>if someting goes wrong the return value/exit code of cd > will not be 0. =>the shell does the globbing, thus instead of > 'dir/*', 'dir/a' 'dir/b' is =>supplied to cp as command line argument > if 'dir/a' and 'dir/b' exist. => > =>If you do something like 'cp dir/* somewhere/' you will get an > error if =>'dir/' is empty. This is because if 'dir/' is empty the > shell will not =>do globbing for the asterisk. So cp will complain > that it can't find the =>file 'dir/*'. I think before doing major > changes here...maybe somebody =>just forgot to check $? after the cp > invocation. => > => > =>Just my 2 cents, > =>Fabian > > Thanks Fabian. Certainly worth checking. Nick, do you know what code > we're talking about here? Where is this cp command in question? > No, I didn't analyse it at all. 1) Copy Data CD (CD to CD) is where this issue is. I haven't looked at code at due to testing all the other stuff. Nick -- Free Software Foundation Associate Member 5508 |
|
From: Steven W. O. <st...@sy...> - 2008-10-01 14:59:57
|
On Wednesday, Oct 1st 2008 at 09:53 -0000, quoth Fabian Stietzel: =>Steven W. Orr wrote: =>> * The copy command is using globbing. Globbing is evil. We need to only =>> copy files that are explicitly specified. If you copy by saying something =>> like... =>> =>The shell is globbing. cp will never do it. It's the shell. The globbing =>can be avoided easily by using single quotation marks. => =>> cp dir/* somewhere/ =>> =>> Then there's no way to detect that the cp didn't pick something up. We =>> have to either verify that the disk is mounted and/or we have to always =>> specify explict files. DEATH TO GLOBBING. =>> =>> =>Of course you can detect if cd "didn't pick something up". cd will pick =>every file supplied as a command line argument before the last (target). =>if someting goes wrong the return value/exit code of cd will not be 0. =>the shell does the globbing, thus instead of 'dir/*', 'dir/a' 'dir/b' is =>supplied to cp as command line argument if 'dir/a' and 'dir/b' exist. => =>If you do something like 'cp dir/* somewhere/' you will get an error if =>'dir/' is empty. This is because if 'dir/' is empty the shell will not =>do globbing for the asterisk. So cp will complain that it can't find the =>file 'dir/*'. I think before doing major changes here...maybe somebody =>just forgot to check $? after the cp invocation. => => =>Just my 2 cents, =>Fabian Thanks Fabian. Certainly worth checking. Nick, do you know what code we're talking about here? Where is this cp command in question? -- steveo at syslang dot net TMMP1 http://frambors.syslang.net/ Do you have neighbors who are not frambors? Steven W. Orr |
|
From: Fabian S. <fa...@sc...> - 2008-10-01 13:54:14
|
Steven W. Orr wrote: > * The copy command is using globbing. Globbing is evil. We need to only > copy files that are explicitly specified. If you copy by saying something > like... > The shell is globbing. cp will never do it. It's the shell. The globbing can be avoided easily by using single quotation marks. > cp dir/* somewhere/ > > Then there's no way to detect that the cp didn't pick something up. We > have to either verify that the disk is mounted and/or we have to always > specify explict files. DEATH TO GLOBBING. > > Of course you can detect if cd "didn't pick something up". cd will pick every file supplied as a command line argument before the last (target). if someting goes wrong the return value/exit code of cd will not be 0. the shell does the globbing, thus instead of 'dir/*', 'dir/a' 'dir/b' is supplied to cp as command line argument if 'dir/a' and 'dir/b' exist. If you do something like 'cp dir/* somewhere/' you will get an error if 'dir/' is empty. This is because if 'dir/' is empty the shell will not do globbing for the asterisk. So cp will complain that it can't find the file 'dir/*'. I think before doing major changes here...maybe somebody just forgot to check $? after the cp invocation. Just my 2 cents, Fabian |
|
From: Steven W. O. <st...@sy...> - 2008-10-01 13:36:34
|
On Wednesday, Oct 1st 2008 at 05:26 -0000, quoth Nick Warne: => =>I don't know what to do about this. First issue, if you do not mount =>the data CD to be copied (like I just forgot to do), the copy command =>gets 'ignored' and the burn sequence then proceeds anyway. => =>Next, I tried again with a mounted data CD. This time the data is =>ripped to *.iso in burn directory - BUT when completed, we are asked to =>insert blank CD to copy to. Well, you can't unless you go to another =>terminal and umount the original data CD first. => =>But if you mess about like this, it does work. => =>I honestly don't know what to do here? My time is limited here at work, but I can guess what's happening. * The copy command is using globbing. Globbing is evil. We need to only copy files that are explicitly specified. If you copy by saying something like... cp dir/* somewhere/ Then there's no way to detect that the cp didn't pick something up. We have to either verify that the disk is mounted and/or we have to always specify explict files. DEATH TO GLOBBING. -- steveo at syslang dot net TMMP1 http://frambors.syslang.net/ Do you have neighbors who are not frambors? Steven W. Orr |
|
From: Anders L. <and...@gm...> - 2008-10-01 13:29:17
|
ons 2008-10-01 klockan 14:01 +0100 skrev Nick Warne: > Tidy this up a bit. > SVN is still AWOL at this time - I have a few fixes to go in ASAP > > > Data recording WORKS > > Burning ISO works > > OK, update. I just burnt a *.ogv file to CD(data recording). All works > perfectly. > > Data DVD burning works. > > MP3 to Audio CD works. > > CD ripping to *.ogg -> hard drive works :-) > > CD ripping to *.mp3 -> hard drive works :-)) > > CD ripping to *.flac -> hard drive works :-))) > > Fix to be committed, but now AudioCD-> CD copy works :-)))) > > Copy Audio CD [CD to harddrive] - works :-))))) > > Create Mp3s from Wavs - works :-)))))) > > Create Oggs from Wavs - works :-))))))) > > Create Flacs from Wavs - FAILS :-( But I fixed it so it now > works :-)))))) SVN is still awol... I will commit ASAP. > > Create ISO from files in <burn directory> - FAILS :-( But I fixed > this too, and now works :-))))))))). SVN is still awol... I will > commit ASAP. > Nice work Nick. SVN is back up again, commit all you want. -- Anders Lindén http://bashburn.sf.net |
|
From: Nick W. <ni...@li...> - 2008-10-01 13:01:41
|
Tidy this up a bit. SVN is still AWOL at this time - I have a few fixes to go in ASAP Data recording WORKS Burning ISO works OK, update. I just burnt a *.ogv file to CD(data recording). All works perfectly. Data DVD burning works. MP3 to Audio CD works. CD ripping to *.ogg -> hard drive works :-) CD ripping to *.mp3 -> hard drive works :-)) CD ripping to *.flac -> hard drive works :-))) Fix to be committed, but now AudioCD-> CD copy works :-)))) Copy Audio CD [CD to harddrive] - works :-))))) Create Mp3s from Wavs - works :-)))))) Create Oggs from Wavs - works :-))))))) Create Flacs from Wavs - FAILS :-( But I fixed it so it now works :-)))))) SVN is still awol... I will commit ASAP. Create ISO from files in <burn directory> - FAILS :-( But I fixed this too, and now works :-))))))))). SVN is still awol... I will commit ASAP. -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-01 12:50:03
|
On Wed, 1 Oct 2008 13:10:29 +0100 Nick Warne <ni...@li...> wrote: > On Wed, 1 Oct 2008 09:44:17 +0100 > Nick Warne <ni...@li...> wrote: > > > On Tue, 30 Sep 2008 14:56:58 +0100 > > Nick Warne <ni...@li...> wrote: > > > > > On Tue, 30 Sep 2008 13:18:58 +0100 > > > Nick Warne <ni...@li...> wrote: > > > > > > > On Tue, 30 Sep 2008 13:05:09 +0100 > > > > Nick Warne <ni...@li...> wrote: > > > > > > > > > On Tue, 30 Sep 2008 10:37:14 +0100 > > > > > Nick Warne <ni...@li...> wrote: > > > > > > > > > > > On Fri, 12 Sep 2008 00:03:10 +0200 > > > > > > Anders Lindén <and...@gm...> wrote: > > > > > > > > > > > > > lör 2008-09-06 klockan 14:33 +0100 skrev Nick Warne: > > > > > > > > On Sun, 31 Aug 2008 17:37:09 +0100 > > > > > > > > Nick Warne <ni...@uk...> wrote: > > > > > > > > > > > > > > > > > On Sun, 31 Aug 2008 17:02:19 +0100 > > > > > > > > > Nick Warne <ni...@uk...> wrote: > > > > > > > > > > > > > > > > > > > I think we ought to start a thread reporting > > > > > > > > > > successful functionality > > > > > > > > > > > > > > > > > > > > I just fixed a broken data recording - committed. > > > > > > > > > > > > > > > > > > > > So please just reply to this thread as each function > > > > > > > > > > is proven to work so we have some sort of visible > > > > > > > > > > guide. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Data recording WORKS > > > > > > > > > > > > > > > > > > > > > > > > > > > > Burning ISO works > > > > > > > > > > > > > > > > > > > > > > > > > OK, update. I just burnt a *.ogv file to CD(data > > > > > > > > recording). > > > > > > > > > > > > > > > > All works perfectly. > > > > > > > > > > > > > > > > BTW, worth a watch: > > > > > > > > > > > > > > > > http://www.gnu.org/fry/happy-birthday-to-gnu.html > > > > > > > > > > > > > > > > Nick > > > > > > > > > > > > > > Data DVD burning works. > > > > > > > > > > > > MP3 to Audio CD works. > > > > > > > > > > CD ripping to *.ogg -> hard drive works :-) > > > > > > > > CD ripping to *.mp3 -> hard drive works :-)) > > > > > > CD ripping to *.flac -> hard drive works :-))) > > > > > Fix to be committed, but now AudioCD-> CD copy works :-)))) > > Copy Audio CD [CD to harddrive] - works :-))))) > Create Mp3s from Wavs - works :-)))))) > Create Oggs from Wavs - works :-))))))) > Create Flacs from Wavs - FAILS :-( But I fixed it so it now > works :-)))))) SVN is still awol... I will commit ASAP. Create ISO from files in <burn directory> - FAILS :-) But I fixed this too, and now works :-))))))))). SVN is still awol... I will commit ASAP. -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-01 12:17:49
|
On Wed, 1 Oct 2008 09:44:17 +0100 Nick Warne <ni...@li...> wrote: > On Tue, 30 Sep 2008 14:56:58 +0100 > Nick Warne <ni...@li...> wrote: > > > On Tue, 30 Sep 2008 13:18:58 +0100 > > Nick Warne <ni...@li...> wrote: > > > > > On Tue, 30 Sep 2008 13:05:09 +0100 > > > Nick Warne <ni...@li...> wrote: > > > > > > > On Tue, 30 Sep 2008 10:37:14 +0100 > > > > Nick Warne <ni...@li...> wrote: > > > > > > > > > On Fri, 12 Sep 2008 00:03:10 +0200 > > > > > Anders Lindén <and...@gm...> wrote: > > > > > > > > > > > lör 2008-09-06 klockan 14:33 +0100 skrev Nick Warne: > > > > > > > On Sun, 31 Aug 2008 17:37:09 +0100 > > > > > > > Nick Warne <ni...@uk...> wrote: > > > > > > > > > > > > > > > On Sun, 31 Aug 2008 17:02:19 +0100 > > > > > > > > Nick Warne <ni...@uk...> wrote: > > > > > > > > > > > > > > > > > I think we ought to start a thread reporting > > > > > > > > > successful functionality > > > > > > > > > > > > > > > > > > I just fixed a broken data recording - committed. > > > > > > > > > > > > > > > > > > So please just reply to this thread as each function > > > > > > > > > is proven to work so we have some sort of visible > > > > > > > > > guide. > > > > > > > > > > > > > > > > > > > > > > > > > > > Data recording WORKS > > > > > > > > > > > > > > > > > > > > > > > > > Burning ISO works > > > > > > > > > > > > > > > > > > > > > > OK, update. I just burnt a *.ogv file to CD(data > > > > > > > recording). > > > > > > > > > > > > > > All works perfectly. > > > > > > > > > > > > > > BTW, worth a watch: > > > > > > > > > > > > > > http://www.gnu.org/fry/happy-birthday-to-gnu.html > > > > > > > > > > > > > > Nick > > > > > > > > > > > > Data DVD burning works. > > > > > > > > > > MP3 to Audio CD works. > > > > > > > > CD ripping to *.ogg -> hard drive works :-) > > > > > > CD ripping to *.mp3 -> hard drive works :-)) > > > > CD ripping to *.flac -> hard drive works :-))) > > > Fix to be committed, but now AudioCD-> CD copy works :-)))) Copy Audio CD [CD to harddrive] - works :-))))) Create Mp3s from Wavs - works :-)))))) Create Oggs from Wavs - works :-))))))) Create Flacs from Wavs - FAILS :-( But I fixed it so it now works :-)))))) SVN is still awol... I will commit ASAP. -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-01 12:14:38
|
OK, I am about done here. I can't do much more as I have no DVD stuff, and even if I did, I have never burnt/used DVD burning, so wouldn't know what to look for. There is not much more testing I can do, really. Nick P.S. I am the only man in the world that has NO TV DVD player/disks? -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-01 12:10:46
|
On Wed, 1 Oct 2008 09:44:17 +0100 Nick Warne <ni...@li...> wrote: > On Tue, 30 Sep 2008 14:56:58 +0100 > Nick Warne <ni...@li...> wrote: > > > On Tue, 30 Sep 2008 13:18:58 +0100 > > Nick Warne <ni...@li...> wrote: > > > > > On Tue, 30 Sep 2008 13:05:09 +0100 > > > Nick Warne <ni...@li...> wrote: > > > > > > > On Tue, 30 Sep 2008 10:37:14 +0100 > > > > Nick Warne <ni...@li...> wrote: > > > > > > > > > On Fri, 12 Sep 2008 00:03:10 +0200 > > > > > Anders Lindén <and...@gm...> wrote: > > > > > > > > > > > lör 2008-09-06 klockan 14:33 +0100 skrev Nick Warne: > > > > > > > On Sun, 31 Aug 2008 17:37:09 +0100 > > > > > > > Nick Warne <ni...@uk...> wrote: > > > > > > > > > > > > > > > On Sun, 31 Aug 2008 17:02:19 +0100 > > > > > > > > Nick Warne <ni...@uk...> wrote: > > > > > > > > > > > > > > > > > I think we ought to start a thread reporting > > > > > > > > > successful functionality > > > > > > > > > > > > > > > > > > I just fixed a broken data recording - committed. > > > > > > > > > > > > > > > > > > So please just reply to this thread as each function > > > > > > > > > is proven to work so we have some sort of visible > > > > > > > > > guide. > > > > > > > > > > > > > > > > > > > > > > > > > > > Data recording WORKS > > > > > > > > > > > > > > > > > > > > > > > > > Burning ISO works > > > > > > > > > > > > > > > > > > > > > > OK, update. I just burnt a *.ogv file to CD(data > > > > > > > recording). > > > > > > > > > > > > > > All works perfectly. > > > > > > > > > > > > > > BTW, worth a watch: > > > > > > > > > > > > > > http://www.gnu.org/fry/happy-birthday-to-gnu.html > > > > > > > > > > > > > > Nick > > > > > > > > > > > > Data DVD burning works. > > > > > > > > > > MP3 to Audio CD works. > > > > > > > > CD ripping to *.ogg -> hard drive works :-) > > > > > > CD ripping to *.mp3 -> hard drive works :-)) > > > > CD ripping to *.flac -> hard drive works :-))) > > > Fix to be committed, but now AudioCD-> CD copy works :-)))) Copy Audio CD [CD to harddrive] - works :-))))) Create Mp3s from Wavs - works :-)))))) Create Oggs from Wavs - works :-))))))) Create Flacs from Wavs - FAILS :-( But I fixed it so it now works :-)))))) SVN is still awol... I will commit ASAP. -- Free Software Foundation Associate Member 5508 |
|
From: Nick W. <ni...@li...> - 2008-10-01 09:26:34
|
I don't know what to do about this. First issue, if you do not mount the data CD to be copied (like I just forgot to do), the copy command gets 'ignored' and the burn sequence then proceeds anyway. Next, I tried again with a mounted data CD. This time the data is ripped to *.iso in burn directory - BUT when completed, we are asked to insert blank CD to copy to. Well, you can't unless you go to another terminal and umount the original data CD first. But if you mess about like this, it does work. I honestly don't know what to do here? Nick -- Free Software Foundation Associate Member 5508 |
8 messages has been excluded from this view by a project administrator.
