Re: [Barry-devel] barry-0.18.2 patch for BB Bold (9930)

[Chris F. <cd...@fo...>]

On Sun, Jun 24, 2012 at 06:24:12PM -0400, me...@ro... wrote:
> Chris:
> 
> I run Gentoo Linux ~x86, and first used barry with the original BB on
> XmBlackberry + barry-0.16,
> later upgrading to a Curve with barry-0.17.x (and -0.18.x as well), and
> now the Bold.
> 
> Patch to fix 'timeout after send passwd':
> 
> File: src/m_ipmodem.cc, lines 172+
> 
> -- m_dev.BulkRead(read_ep, data);
> -- ddout("IPModem: Start Response Packet:\n" << data);
> ++ 		try {
> ++ 			m_dev.BulkRead(read_ep, data);
> ++			ddout("IPModem: Start Response Packet:\n" << data);
> ++		}
> ++		catch( Usb::Timeout &to ) {
> ++			// do nothing on timeouts
> ++			ddout("IPModem: Start Response Timeout");
> ++		}
> 
> Effect of code: allow Timeout response for 'Re-send Start Request'.

Thanks Kurt!  I've created a new branch on repo.or.cz/w/barry.git called
"ipmodemfix".  Would you be able to test this to make sure it fixes your
issue on the Bold?  The line numbers from your patch didn't quite
line up.


> there is also a problem in desktop/ModemDlg.cc, that I can't fix w/o your
> help..
> 
> my suggested fix is something along the lines of:
> 
> File: desktop/src/ModemDlg.cc, lines 270+
> 
> -- string need_sudo;
> ++ #ifndef BARRYDESKTOP_SYSTEM_GUI_SU
> ++ #define BARRYDESKTOP_SYSTEM_GUI_SU ""
> ++ #endif
> ++ 	string need_sudo = string(BARRYDESKTOP_SYSTEM_GUI_SU " ");
> 
> Effect of code: when user .configure --with-guisu=<path>, this override
> will occur

I'm unclear what the exact issue is here... in the ModemDlg.cc code, there are
3 states.  One state is for when pppd can be run by the end user.  The
other two states both use the GUI_SU setting from configure.  Ideally,
a GUI_SU should not be required, if system permissions are set correctly,
but some systems prefer not having a setuid pppd, so both modes are needed.

On systems that do have a setuid pppd, the goal is to avoid prompting for a
root password every time, since it is not needed.  But perhaps I got the
permissions tests wrong in the code.

What particular error do you get?  How does it behave for you?

Thanks,
- Chris