Re: [Bacula-devel] Regression tests - compile failures

[Dan L. <da...@la...>]

On 2012-06-08 15:05, Dan Langille wrote:
> On 2012-06-08 10:21, Kern Sibbald wrote:
>> On 06/08/2012 02:40 PM, Dan Langille wrote:
>>> I am seeing regression test failures on FreeBSD 8.2 with PostgreSQL 
>>> 9.x
>>>
>>> ==>Entering directory
>>> 
>>> /usr/home/dan/src/BaculaRegressionTesting-TRUNK/regress/build/src/lib
>>> "Makefile", line 426: Need an operator
>>> make: fatal errors encountered -- cannot continue
>>>
>>> Can anyone duplicate this error?
>>>
>>> The line in question is:   ../lib/breg.h /usr/include/regex.h
>>>
>>> I can supply more information, and provide access to systems if it
>>> comes to that.
>
>
>> Hello Dan,
>>
>> No I am not seeing the problem.  The line should end with a slash 
>> (\)
>> so that it is continued.  The line is created by the gcc (or perhaps 
>> g++),
>> so if it does not have the trailing slash there must be a problem 
>> with
>> the compiler.
>
> I think it is not the compile, but the Makefile.in.  Or perhaps
> differences in echo.  Oh wait, no, it's print.
>
> This is from around line 388 of Makefile:
>
> # 
> -----------------------------------------------------------------------
> # DO NOT DELETE: nice dependency list followsnattr.lo: attr.c
> ../bacula.h ../config.h /usr/include/stdint.h \
>   /usr/include/sys/cdefs.h /usr/include/sys/_types.h \
>
>
> I am pretty sure that should be more like this:
>
> # 
> -----------------------------------------------------------------------
> # DO NOT DELETE: nice dependency list follows
> nattr.lo: attr.c ../bacula.h ../config.h /usr/include/stdint.h \
>   /usr/include/sys/cdefs.h /usr/include/sys/_types.h \
>
> Looking at Makefile.in, I see:
>
>
> depend:
>         @$(MV) Makefile Makefile.bak
>         @$(SED) "/^# DO NOT DELETE:/,$$ d" Makefile.bak > Makefile
>         @$(ECHO) "# DO NOT DELETE: nice dependency list follows" >> 
> Makefile
>
> Could this just be missing a newline?  I think so.
>
> My simple test:
>
>         @$(SED) "/^# DO NOT DELETE:/,$$ d" Makefile.bak > Makefile
>         @$(ECHO) "# DO NOT DELETE: nice dependency list follows" >> 
> Makefile
>         @$(ECHO) "#" >> Makefile
>
> i.e. echo a #
>
> results in this Makefile:
>
> # DO NOT DELETE: nice dependency list followsn#nattr.lo: attr.c
> ../bacula.h ../config.h /usr/include/stdint.h \
>   /usr/include/sys/cdefs.h /usr/include/sys/_types.h \
>   /usr/include/machine/_types.h /usr/include/machine/_stdint.h \
>
>
> I see this defined:
>
> ECHO = printf %s\n
>
>
> However, I think that should be one of the following:
>
> ECHO = printf %s\\n
> ECHO = printf "%s\n"
>
> I'll keep looking for a bit longer, but if you know what triggers
> this, I'll stop looking.  :)

I was looking at bacula/configure and found line 6048.  If I change it 
to:

   ECHO='echo'

With that line, all goes well.

I tried both of these, they resulted in other errors:

   ECHO='printf "%s\n"'
   ECHO='printf %s\\n'

Hope this helps.

-- 
Dan Langille - http://langille.org/