Re: [Bacula-devel] Bacula FD Plugin and estimate command

[Radosław K. <rad...@ko...>]

W dniu 22 sierpnia 2010 17:03 użytkownik Kern Sibbald <ke...@si...>napisał:

> On Sunday 22 August 2010 04:00:15 Radosław Korzeniewski wrote:
> > Hello Gurus,
> >
> > What do I need to handle estimate command in FD plugin?
>
> I don't know.  I suspect that it needs a new entry point to the plugin and
> a
> suitable call at the right point in the core code.
>

So, for short - it is unimplemented?
At start I was assuming that bacula uses already available functions like
handlePluginEvent or startBackupFile, but without any real pluginIO, but it
didn't work.


> > All I've got is an
> > error message on console: "Plugin: "bplugin:/home/radekk" not found."
> > When I run bacula-fd in debug mode I've got:
> > (...)
> > radekk-fd: jcr.c:904-0 leave set_job_status old=C new=R
> > radekk-fd: find.c:94-0 Enter set_find_options()
> > radekk-fd: find.c:97-0 Leave set_find_options()
> > radekk-fd: find.c:203-0 Verify=<V> Accurate=<Cmcs> BaseJob=<Jspug5>
> > radekk-fd: message.c:1205-0 Enter Jmsg type=3
> > radekk-fd: runscript.c:110-0 runscript: running all RUNSCRIPT object
> > (ClientAfterJob) JobStatus=R
> > radekk-fd: job.c:396-0 Calling term_find_files
> > radekk-fd: job.c:401-0 Done with term_find_files
> > (...)
> > Why estimate command for FD plugin goes to find.c->find_files:166 (above
> > message: find.c:203-0 Verify=<V> Accurate=<Cmcs> BaseJob=<Jspug5>).
> > This is a plugin and it does not use find.c functions, so I assume that
> > estimate command is improper handled in bacula-fd in case of FD plugin.
> > Is it a bug? expected feature? or I miss something?
>
> I am not sure how to classify this.  I suppose it is an "unimplemented
> feature".  From my point of view bpipe is a sort of demo program to show
> people how they can write a real plugin.  It can be used for production
> work
> if you test it.
>

I'm not using bpipe. I'm writing a real custom FD plugin. It isn't based on
bpipe. I assume my plugin will be used for production work. Until my plugin
will be finished I assume estimate command is unsupported on FD plugins.
Then I'll try to fix this behavior.


> Unless adding estimate is a two or three line change, modifying bpipe to
> support estimate is not a priority item that we are likely to get around to
> doing -- on the other hand if someone were to submit a suitable patch, we
> would be willing to integrate it.
>

Well, I don't want to change bpipe plugin, because I'm writing my own.

regards

-- 
Radosław Korzeniewski
rad...@ko...