From: Mantis B. T. <no...@bu...> - 2009-11-03 11:15:33
|
The following issue has been REOPENED. ====================================================================== http://bugs.bacula.org/view.php?id=1406 ====================================================================== Reported By: elfring Assigned To: ====================================================================== Project: bacula Issue ID: 1406 Category: other Reproducibility: always Severity: minor Priority: normal Status: feedback ====================================================================== Date Submitted: 2009-11-02 17:34 UTC Last Modified: 2009-11-03 11:15 UTC ====================================================================== Summary: reserved identifier violation Description: I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source files. Some places will be found where names begin with two underscores or an underscore and an uppercase letter. Examples: - _BACULA_H http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/src/bacula.h;h=ab0ba1abd02449e2f99935184ade6a348c0ed0a5;hb=HEAD#l34 - _BWIN32_STREAM_ID http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/src/findlib/bfile.h;h=b22d50cc4e48b628928be3a4a31543320e3ea28f;hb=HEAD#l47 This does not fit to the expected naming conventions of the C language standard if they are not used for a compiler implementation. ====================================================================== ---------------------------------------------------------------------- (0004756) kern (administrator) - 2009-11-03 10:10 http://bugs.bacula.org/view.php?id=1406#c4756 ---------------------------------------------------------------------- We are aware of the C programming standards, but in this case, the code has been compiled on virtually every mid-range operating system that exists over a period of 10 years with no conflict with identifiers used. What you are reporting is not a bug, but a matter of upgrading the quality of the code. We spend about 15-20% of our effort each release improving the quality of the code. Rather than submitting bug reports on items that are not bugs, please fill out and send in the FLA (see: http://www.bacula.org [^] -> FSFE License), then send us a patch with your suggested corrections. ---------------------------------------------------------------------- (0004759) elfring (reporter) - 2009-11-03 11:15 http://bugs.bacula.org/view.php?id=1406#c4759 ---------------------------------------------------------------------- The bug is clearly that some identifiers tamper with the reserved namespace in the source files. We have just got different opinions about the relevance of this issue. Issue History Date Modified Username Field Change ====================================================================== 2009-11-02 17:34 elfring New Issue 2009-11-03 10:10 kern Note Added: 0004756 2009-11-03 10:10 kern Status new => closed 2009-11-03 10:10 kern Resolution open => not a bug 2009-11-03 11:15 elfring Note Added: 0004759 2009-11-03 11:15 elfring Status closed => feedback 2009-11-03 11:15 elfring Resolution not a bug => reopened ====================================================================== |