Re: [Backarrow-devel] skipdownload progress bar fix, needed changes to mozilla.cpp.

[<pin...@ya...>]

 --- lee bigelow <lig...@ya...> wrote: > Hello there,
> I'm not sure if your still working on this or not, but
> I've been fiddling with it.
> I checked it out of you sourceforge cvs and tried to
> compile but ran into some small problems.
> This is how I fixed them.

Yes, I'm still working on it. Just going a bit slow at the moment.
Doing my graduation work for school and stuff.
And now I'm going to be without the internet for 4-8 weeks
because I'm moving. After that I hopefully can continue it more.
Good to see other people are interested though. =)

> --------------------------------
> First the src/mozilla.cpp file:
> 
> line 41 
> had #include "history/nsIGlobalHistory.h"
> changed to just "nsIGlobalHistory.h"
> 
> line 144 
> made reference to SetGlobalHistory, which is not
> defined in any of my mozilla headers (I did and grep
> -r for it and nothing, there is a
> SetUseGlobalHistory?).  Anyway, if you just comment
> out line 144 nothing bad seems to happen -- history
> seems to still work and all.
> 
> line 589
> had GetBaseURL(), changed it to GetBaseURI().

Ok, thanks. I'll do the changes when I get the time.

> -------------------------------------
> Now, about skipdownload.  The progressbar wasn't
> working so I looked at skipdownload.c and had to
> change it a bit to work with my wget (it doesn't have
> a micro dot style output, and doesn't put square
> brackets around it's percent complete output).

Yes, I've noticed this myself too. Haven't had time
to do anything about it yet..

> file skipdownload.c:
> 
> lines 164 and 168:
> changed --progress=dot:micro to just --progress=dot
> 
> line 197:
> changed the find_string(line, "[") to
> find_string(line, "%")
> then on line 199:
> changed 'line + n' to 'line + n - 3' in the scanf
> function call.

Again, I'll add the changes when I get the time. Thanks.

> ------------------
> That's all, and everything seems be working just fine.
> Well sort of.

There still are a lot of bugs in it. =/

> Saving the page from the File->Save menu option
> sometimes works, but not always (yes, I always give a
> file name).  Anyone have any ideas? I've been digging
> around in the nsIWebBrowserPersist a bit, but to be
> honest I haven't tried very hard. (saving pages is not
> something I do very often)

Hmm. Now that you say it. I haven't much tried the page 
savings. I need the function very rarely. :x

> It might be nice to send the Save page option to
> skipdownload with some recursion options.  I mean, we
> are using wget, why not.  gtkwet is nice sample code.

You mean gtkwget right? I'll have a look at it once I
get time.. Thanks for letting me know there is such a project.


-dpb


	
	
		
____________________________________________________________
Yahoo! Messenger - Communicate instantly..."Ping" 
your friends today! Download Messenger Now 
http://uk.messenger.yahoo.com/download/index.html