Re: [Babeldoc-devel] [Fwd: [ babeldoc-Bugs-753907 ] FtpWriter.sendFtpMessage should not be static]

[Dejan K. <dej...@nb...>]

I think we could make this method non-static. Currently, there is no need
for it to be static. I think this could be case for some other methods, too.
You can change method signature and subclass this class or you can try to
implement locking in FtpWriter class. If you decide to implement this in
base class make sure it is configurable usign options. Also, for backward
compatibility this option should not be mandatory and default behaviour
should remain the same.
If you implement this you can send us patch. We will be glad to support this
feature in Babeldoc.

You should avoid extending Mailbox scanner because this class will change a
lot in the next release. We have introduced asynchronous feeding and
scanners will use it. In a few words, scanner will scan for new documents,
and when it found new one, it will just feed it in feeder. Another thread in
feeder will do processing of document. That way, scanning of messages will
be much faster since there will be no waiting for processing of document.
This is very important for mailbox scanner since mail server connections
will be much shorter.

Anyway, one of changes we are planning to do in scanners is removing inner
classes that implements IScanDocuments interface since there will be no need
for them. Now each scanner worker will put scanned document in feeder when
it found new. Much of complexity in inner classes will be removed this way.
So, I suggest you to wait until next release or to update from CVS within
few days, when I finish implementing this feature.

Dejan


> In FtpWriter I have to work with lock files : I can not PUT the file if a
> Lock file exists and I create/delete a Lock file before/after sending the
> file.  Semaphore is another word for that...  I never trusts FTP servers
> to do that for me.
> So
> I extend the FtpWriter but since a static method can not be extend I was
> blocked and had to change the babeldoc class itself (or I could rewrite
> all the class)
> I had a similar issues when customising by MailboxScanner for adding
> Filter (see another SF enhancement request).  Because the inner class was
> package protected I could not extend and add to copy/paste the class
> (beurk)
>
> These are small issues and I don't know your priorities so I am just
> dumping the ideas right now.
>
> To do the task completely there will be a need for read all classes and
> remove private/package protected definitions, remove static methods and,
> maybe, work less with inner classes (I always find it more difficult to
> inherit from Class containing inner classes)
>
> Vincent
>
> -------- Original Message --------
> Subject: [ babeldoc-Bugs-753907 ] FtpWriter.sendFtpMessage should not be
> static
> From: "SourceForge.net" <no...@so...>
> Date: Fri, June 13, 2003 15:49
> To: no...@so...
>
> Bugs item #753907, was opened at 2003-06-13 13:32
> Message generated for change (Comment added) made by dejank
> You can respond by visiting:
>
https://sourceforge.net/tracker/?func=detail&atid=482496&aid=753907&group_id
=56976
>
> Category: None
> Group: None
> Status: Open
> Resolution: None
> Priority: 5
> Submitted By: Vincent Harcq (vharcq)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: FtpWriter.sendFtpMessage should not be static
>
> Initial Comment:
> ...to be able to extend the class and overwrite the
> method to create a custom FtpWriter
>
> Vincent
>
> ----------------------------------------------------------------------
>
> >Comment By: Dejan Krsmanovic (dejank)
> Date: 2003-06-13 15:49
>
> Message:
> Logged In: YES
> user_id=608954
>
> There are few other static methods in several pipeline stages.
> I guess the main reason for this is that they could be easily
> used in other stages (Bruce?). But except parse method of
> Domify stage I cannot recall if any other stage use methods
> of other stages.
>
> I think we should discuss of this issue. I suggest you to
> subscribe to developer list (if you are not already) so we
> could discuss about this.
>
>
>
> ----------------------------------------------------------------------
>
> You can respond by visiting:
>
https://sourceforge.net/tracker/?func=detail&atid=482496&aid=753907&group_id
=56976
>
>
>
>
>
> -------------------------------------------------------
> This SF.NET email is sponsored by: eBay
> Great deals on office technology -- on eBay now! Click here:
> http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
> _______________________________________________
> Babeldoc-devel mailing list
> Bab...@li...
> https://lists.sourceforge.net/lists/listinfo/babeldoc-devel