[Babeldoc-devel] [Fwd: [ babeldoc-Bugs-753907 ] FtpWriter.sendFtpMessage should not be static]

[Vincent H. <vin...@hu...>]

Hi,
I restart this from a SF bug report

Babeldoc have a really nice way to handle module, so that I can create my
own module by extending some scanners or pipelines.
I got one issue that is to extend (in Java sense) some exsting classes and
overwrite the methods I needed.
In FtpWriter I have to work with lock files : I can not PUT the file if a
Lock file exists and I create/delete a Lock file before/after sending the
file.  Semaphore is another word for that...  I never trusts FTP servers
to do that for me.
So
I extend the FtpWriter but since a static method can not be extend I was
blocked and had to change the babeldoc class itself (or I could rewrite
all the class)
I had a similar issues when customising by MailboxScanner for adding
Filter (see another SF enhancement request).  Because the inner class was
package protected I could not extend and add to copy/paste the class
(beurk)

These are small issues and I don't know your priorities so I am just
dumping the ideas right now.

To do the task completely there will be a need for read all classes and
remove private/package protected definitions, remove static methods and,
maybe, work less with inner classes (I always find it more difficult to
inherit from Class containing inner classes)

Vincent

-------- Original Message --------
Subject: [ babeldoc-Bugs-753907 ] FtpWriter.sendFtpMessage should not be
static
From: "SourceForge.net" <no...@so...>
Date: Fri, June 13, 2003 15:49
To: no...@so...

Bugs item #753907, was opened at 2003-06-13 13:32
Message generated for change (Comment added) made by dejank
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482496&aid=753907&group_id=56976

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Vincent Harcq (vharcq)
Assigned to: Nobody/Anonymous (nobody)
Summary: FtpWriter.sendFtpMessage should not be static

Initial Comment:
...to be able to extend the class and overwrite the
method to create a custom FtpWriter

Vincent

----------------------------------------------------------------------

>Comment By: Dejan Krsmanovic (dejank)
Date: 2003-06-13 15:49

Message:
Logged In: YES
user_id=608954

There are few other static methods in several pipeline stages.
I guess the main reason for this is that they could be easily
used in other stages (Bruce?). But except parse method of
Domify stage I cannot recall if any other stage use methods
of other stages.

I think we should discuss of this issue. I suggest you to
subscribe to developer list (if you are not already) so we
could discuss about this.



----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482496&aid=753907&group_id=56976