#9 Error of NullPoints

[Ades RedDemon]

Log error of NullPoints
Java 1.6.0_05 Sun Microsystems Inc. SWT v3448
win32 Windows XP v5.1
Azureus/Vuze Beta (3.1.1.1_B58)
----------------------
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
at org.eclipse.swt.SWT.error(SWT.java:3777)
at org.eclipse.swt.SWT.error(SWT.java:3695)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:136)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3800)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3425)
at org.gudy.azureus2.ui.swt.mainwindow.SWTThread.<init>(SWTThread.java:183)
at org.gudy.azureus2.ui.swt.mainwindow.SWTThread.createInstance(SWTThread.java:67)
at org.gudy.azureus2.ui.swt.mainwindow.Initializer.<init>(Initializer.java:110)
at org.gudy.azureus2.ui.swt.Main.<init>(Main.java:84)
at org.gudy.azureus2.ui.swt.Main.main(Main.java:217)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.aelitis.azureus.launcher.MainExecutor$1.run(MainExecutor.java:37)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
at com.azureus.plugins.aztsearch.TSController.displayResults(TSController.java:167)
at com.azureus.plugins.aztsearch.TSController.syncAllTablesWithSearchResults(TSController.java:457)
at com.azureus.plugins.aztsearch.TSController.syncAndRefreshView(TSController.java:614)
at com.azureus.plugins.aztsearch.TSSearchManager$9$1.run(TSSearchManager.java:255)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:133)
... 13 more

[Dalmazio Brisinda]

I can't reproduce this error on OS X 10.5.4, running Java 1.5, Azureus/Vuze 3.1.1.0. Try running the non-beta version of Azureus and see if you can reproduce this NullPointerException.

[Ades RedDemon]

I try the last version and there is the same problem.
http://666kb.com/i/b2suau10y89y82zbj.jpg

[Dalmazio Brisinda]

Do you get the same error when running Vuze 3.1.1.0 instead of Vuze 3.1.1.1_B72?

[Ades RedDemon]

This problem is also in your system and not depend to beta version of Azureus.

A little description of the problem.
In any engine class, the variable date is initializated with null.
After, when the parse funtion failed, the variable date stay null.
After, when it is put in tableItem, it generate nullPoint error.

I have a patch with only change the initializing of this variable where this is used.
- Date date = null;
+ Date date = new Date(0);

But for a good job, we need to modify the date parse function.
And i can't find a solution in this time.

[Dalmazio Brisinda]

I had a closer look, and yes you are right.

I corrected the problem in a slightly different way, by allowing null dates and just doing a check when displaying the contents in the GUI tables. I also made a few other fixes for various other NullPointerExceptions.

I uncovered some problems where the large regular expression matches a torrent item, but the date component is sometimes null (even though it matches). This is weird and shouldn't happen if the regular expression matches. On the surface it looks like a Java RE library bug that is failing to return the date group in certain circumstances (perhaps when the RE's are too complex). But at least now, we should no longer get NullPointerExceptions. Let me know if you find any more.

The latest code has been committed. Thanks again for your sharp eye.