|
From: Zhouyang J. <jia...@gm...> - 2017-08-04 03:50:19
|
Hi, I'm new to Ayttm, I analyzed the source code and found two potential bugs that may cause crashes. 1. In ayttm-0.6.3/modules/utility/custom_message.c:158:7, if "open" failed to open "custom_away_msg", "read" would cause a crash since "fd" is -1. 2. In ayttm-0.6.3/libproxy/ssl.c:93:12, if "SSL_CTX_new" failed to initialize the SSL context, "SSL_CTX_set_default_verify_paths" would cause a crash since "ssl_ctx" is null. I think it's unsafe to assume that the library functions would be correct. It would be better if we could handle the errors properly. Attached please find the patches against version ayttm-0.6.3. Hopefully, they can solve these potential bugs. Best, Zhouyang |