From: Siddhesh P. <sid...@gm...> - 2010-04-12 13:59:09
|
On Mon, Apr 12, 2010 at 6:09 PM, Kartik Mistry <kar...@gm...> wrote: > On Mon, Apr 12, 2010 at 6:03 PM, Siddhesh Poyarekar > <sid...@gm...> wrote: >> I was wondering if we could remove the libyahoo2 code base since it is >> already a separate project. We can then have the yahoo2 plugin link to >> libyahoo2 dynamically instead and pull that as dependency on rpm/deb >> based systems. Is there any scenario where this will not be a good >> idea? >> >> My primary motivation for doing this is that I need to pull in patches >> from libyahoo2 every time there is a change upstream. It is >> unnecessary overhead. > > +1 > > Please do this :) > Ok, the first hurdle for this looks like the fact that we define USE_STRUCT_CALLBACKS while the app for which libyahoo2 was included into fedora (freehoo) does not seem to use it. Libyahoo2 needs to do this a little more flexibly so that one has the option of either using the struct or defining functions individually. I'll see how difficult that is to change. -- Siddhesh Poyarekar http://siddhesh.in |