Menu
▾
▴
ayttm-devel
|
From: Siddhesh P. <sid...@gm...> - 2010-04-12 12:33:33
|
Hi, I was wondering if we could remove the libyahoo2 code base since it is already a separate project. We can then have the yahoo2 plugin link to libyahoo2 dynamically instead and pull that as dependency on rpm/deb based systems. Is there any scenario where this will not be a good idea? My primary motivation for doing this is that I need to pull in patches from libyahoo2 every time there is a change upstream. It is unnecessary overhead. -- Siddhesh Poyarekar http://siddhesh.in |
|
From: Kartik M. <kar...@gm...> - 2010-04-12 12:39:43
|
On Mon, Apr 12, 2010 at 6:03 PM, Siddhesh Poyarekar
<sid...@gm...> wrote:
> I was wondering if we could remove the libyahoo2 code base since it is
> already a separate project. We can then have the yahoo2 plugin link to
> libyahoo2 dynamically instead and pull that as dependency on rpm/deb
> based systems. Is there any scenario where this will not be a good
> idea?
>
> My primary motivation for doing this is that I need to pull in patches
> from libyahoo2 every time there is a change upstream. It is
> unnecessary overhead.
+1
Please do this :)
--
Cheers,
Kartik Mistry
Debian GNU/Linux Developer
0xD1028C8D | Identica: @kartikm | IRC: kart_
Blogs: {gu: kartikm, en: ftbfs}.wordpress.com
|
|
From: Siddhesh P. <sid...@gm...> - 2010-04-12 13:59:09
|
On Mon, Apr 12, 2010 at 6:09 PM, Kartik Mistry <kar...@gm...> wrote: > On Mon, Apr 12, 2010 at 6:03 PM, Siddhesh Poyarekar > <sid...@gm...> wrote: >> I was wondering if we could remove the libyahoo2 code base since it is >> already a separate project. We can then have the yahoo2 plugin link to >> libyahoo2 dynamically instead and pull that as dependency on rpm/deb >> based systems. Is there any scenario where this will not be a good >> idea? >> >> My primary motivation for doing this is that I need to pull in patches >> from libyahoo2 every time there is a change upstream. It is >> unnecessary overhead. > > +1 > > Please do this :) > Ok, the first hurdle for this looks like the fact that we define USE_STRUCT_CALLBACKS while the app for which libyahoo2 was included into fedora (freehoo) does not seem to use it. Libyahoo2 needs to do this a little more flexibly so that one has the option of either using the struct or defining functions individually. I'll see how difficult that is to change. -- Siddhesh Poyarekar http://siddhesh.in |
|
From: Siddhesh P. <sid...@gm...> - 2010-04-12 14:21:20
|
On Mon, Apr 12, 2010 at 7:29 PM, Siddhesh Poyarekar <sid...@gm...> wrote: > > Ok, the first hurdle for this looks like the fact that we define > USE_STRUCT_CALLBACKS while the app for which libyahoo2 was included > into fedora (freehoo) does not seem to use it. > > Libyahoo2 needs to do this a little more flexibly so that one has the > option of either using the struct or defining functions individually. > I'll see how difficult that is to change. > Posted to libyahoo2-devel: https://sourceforge.net/mailarchive/forum.php?thread_name=j2x6e19a8cd1004120710i265def9fg50d4ee100ca01b9e%40mail.gmail.com&forum_name=libyahoo2-devel I've proposed removal of the direct linking option altogether so that we give all applications a consistent interface. -- Siddhesh Poyarekar http://siddhesh.in |
|
From: Philip T. <phi...@gm...> - 2010-04-12 14:24:14
|
On 12 April 2010 18:03, Siddhesh Poyarekar <sid...@gm...> wrote: > Hi, > > I was wondering if we could remove the libyahoo2 code base since it is > already a separate project. We can then have the yahoo2 plugin link to > libyahoo2 dynamically instead and pull that as dependency on rpm/deb > based systems. Is there any scenario where this will not be a good what about people who build from source? regarding freehoo, WITH_STRUCT_CALLBACKS should actually be the default, so perhaps you should push for them to change. |
|
From: Siddhesh P. <sid...@gm...> - 2010-04-12 14:58:13
|
On Mon, Apr 12, 2010 at 7:53 PM, Philip Tellis <phi...@gm...> wrote: > what about people who build from source? They do not have this problem anyway, since they have the freedom to enable/disable options as they wish. The problem is with a developer looking to implement a yahoo client with devel packages from a distro and finds that there are two completely different ways to do this and he would have to find out which distro is using what way. That or include a copy of libyahoo2 in his source, which is not good practice. > regarding freehoo, WITH_STRUCT_CALLBACKS should actually be the > default, so perhaps you should push for them to change. > Yes, they would have to end up making this change if libyahoo2 provides only the callback interface. Currently, the Fedora release of libyahoo2 is pulled from svn. As far as I could see, only freehoo seems to be using it, so it should not be too difficult to get that changed. Ray van Dolson is maintainer for both those packages for Fedora and perhaps upstream for freehoo too. Is freehoo in Debian or any other distro as well? How are they working things there? -- Siddhesh Poyarekar http://siddhesh.in |
|
From: Siddhesh P. <sid...@gm...> - 2010-04-13 09:28:50
|
On Mon, Apr 12, 2010 at 8:28 PM, Siddhesh Poyarekar <sid...@gm...> wrote: > On Mon, Apr 12, 2010 at 7:53 PM, Philip Tellis <phi...@gm...> wrote: >> what about people who build from source? > > They do not have this problem anyway, since they have the freedom to > enable/disable options as they wish. The problem is with a developer > looking to implement a yahoo client with devel packages from a distro > and finds that there are two completely different ways to do this and > he would have to find out which distro is using what way. That or > include a copy of libyahoo2 in his source, which is not good practice. > >> regarding freehoo, WITH_STRUCT_CALLBACKS should actually be the >> default, so perhaps you should push for them to change. >> > > Yes, they would have to end up making this change if libyahoo2 > provides only the callback interface. Currently, the Fedora release of > libyahoo2 is pulled from svn. As far as I could see, only freehoo > seems to be using it, so it should not be too difficult to get that > changed. Ray van Dolson is maintainer for both those packages for > Fedora and perhaps upstream for freehoo too. Is freehoo in Debian or > any other distro as well? How are they working things there? > Just went through sources of freehoo and turns out they're using callbacks too, along with using callback functions with the same name. Due to this the callbacks end up not being used and the functions are directly linked in. I have checked in the change into libyahoo2 as well. Will make changes here once that is released. -- Siddhesh Poyarekar http://siddhesh.in |
Thanks for helping keep SourceForge clean.
X