#25 redundant code

closed-fixed
style (23)
1
2009-01-07
2008-09-16
No

axfs_get_onmedia_super() - redundant code reported by Phillip, need to investigate

Discussion

  • William Marone

    William Marone - 2008-09-19

    Bernhard Reutner-Fischer made this comment on 8/22/08:

    > + goto out;
    > >+
    > >+ /* If no block or MTD device, adjust mmapable to cover all image */
    > >+ if (AXFS_NODEV(sb))
    > >+ sbi->mmap_size = sbi->size;
    > >+
    > >+ err = axfs_fill_region_descriptors(sb, sbo);
    [as already mentioned the clipped snippet here is unneeded]
    > >+out:
    > >+ kfree(sbo);
    > >+ return err;
    > >+}

    Err is implied to remain zero through the function, and that last if() comes right before the out: it jumps to.

     
  • William Marone

    William Marone - 2008-09-19
    • status: open --> open-fixed
     
  • William Marone

    William Marone - 2009-01-07
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks