#767 ExtraSectionFirstColumnValues reports failed if value is 0

6.9
open
nobody
5
2014-07-25
2009-10-06
No

Trying to track a query parameter "pid" with extra section. Valid values for PID are 0..255. When pid=0, awstats records "Failed to extract key"

my conf:
ExtraSectionName1="Portal visits"
ExtraSectionCodeFilter1="200 304"
ExtraSectionCondition1="QUERY_STRING,pid="
ExtraSectionFirstColumnTitle1="Portal"
ExtraSectionFirstColumnValues1="QUERY_STRING,pid=([^&]+)"
ExtraSectionFirstColumnFormat1="%s"
ExtraSectionStatTypes1=PL
ExtraSectionAddAverageRow1=0
ExtraSectionAddSumRow1=0
MaxNbOfExtra1=20
MinHitExtra1=1

I believe this should be line 7508 if (! $rowkeyval) { $rowkeyval='Failed to extract key'; }
is assuming that $rowkeyval is invalid if $rowkeyval=0. Could $rowkeyval be checked for "not null" instead?

Discussion


Log in to post a comment.