#21 Wrong weapon after precasting

[Ele Phant]

Bot precasts but doesn't switch back to main weapon set.

This is a problem when you're using an Ethereal CTA weapon as it seems to lose durability over time (mine is at 10/11 now...)

Perhaps it's wise to check weapon slot status from time to time? Perhaps you have got a better idea ;)

[Kelani Z]

Logged In: YES
user_id=193557
Originator: NO

I found when I increase all the sleeps in my precast, this happens only about once every hundred runs -if that much. The default sleep values are, IMO far too low. What's more, they seem to be processed faster than they should be. With the precast below, I should be precasting for 7 seconds, yet it takes about 3-4.

Sleep 1000
SwitchWeapons
Sleep 600

SelectRightSkill BattleCommand
Sleep 600
CastRightSkill
Sleep 600

Sleep 600
SelectRightSkill BattleOrders
Sleep 600
CastRightSkill
Sleep 600

Sleep 600
SwitchWeapons
Sleep 600

SelectRightSkill HolyShield
Sleep 600
CastRightSkill
Sleep 600

Try that and see if you notice any difference?

[Valtharak]

Logged In: YES
user_id=2101395
Originator: NO

Update on this? happen often? we could make a weapon check before attacking ?

but i guess a bigger delay before switching weapon back would fix this

[Kelani Z]

Logged In: YES
user_id=193557
Originator: NO

I'm still getting it in rc17.1, about once in 10-20 runs, even with my huge delays. If I don't manually switch it back, it stays on the wrong weapon until it gets to the next precast, at which point it switches back to main weapon, and crashes (invalid skill, no BO/BC on main weapon) Current delays are:

Sleep 650
SelectRightSkill HolyShield
Sleep 600
CastRightSkill
Sleep 650
SwitchWeapons
Sleep 850

SelectRightSkill BattleCommand
Sleep 600
CastRightSkill
Sleep 800

Sleep 500
SelectRightSkill BattleOrders
Sleep 600
CastRightSkill
Sleep 800

Sleep 400
SwitchWeapons
Sleep 850
SelectRightSkill Teleport
Sleep 400

[Kelani Z]

Logged In: YES
user_id=193557
Originator: NO

Oh duh. I just noticed something.. It's happening when your merc wanders off and kills something during the precast and you interrupt precast to teleport and pick gold or something before it's done. Apparently, it's not finishing properly. Wouldn't it be possible to suspend pick thread until precast is complete, or something?

[Kelani Z]

Logged In: YES
user_id=193557
Originator: NO

OK, weird. I just saw a "secondary weapon selected, switching to primary" in 17.1 and it did switch back perfectly.

I dunno if that's the check valtharak mentioned, and I've never seen that message before, but in this case it worked great. Leaving open until someone clarifies if that was added recently, or is something else.

If it was old code, I vote adding a check. It's an extra safety measure and you know people will always try to get delays as low as they can w/o crashing.

[Valtharak]

Logged In: YES
user_id=2101395
Originator: NO

I'v added the pickit lock/unlock when performing PrecastQueue. Also checking weapon after the queue done and switching back to primary if wrong. It doesn't do check if the switch successfull. If the bot reach that point it mean you do have a valid primary weapon if it doesn't it mean you messed up removing the weapon or something while the bot running.

let me know if you still get the problem. The bot do check to see if it has the wrong weapon at beginning of a run already

[Kelani Z]

Logged In: YES
user_id=193557
Originator: NO

I also noticed this happening twice when I took a WP and got attacked by a monster lurking nearby. Maybe being in hit recovery is causing the switch to not happen?

[Kelani Z]

Logged In: YES
user_id=193557
Originator: NO

Edit: the last comment happened in 17.1. I've not tested 18.1 yet.