Raw error message appears - PHP error unhandled?

Status: Beta

Brought to you by: amwertlen, nyxerebos, ooskapenaar

#22 Raw error message appears - PHP error unhandled?

Status: open-fixed

Owner: strix

Labels: UI Functionality (5)

Priority: 8

Updated: 2009-09-10

Created: 2009-08-07

Creator: Ronald Wertlen

Private: No

E.g. go to Mary Waters School page. Paste link in to "add image from URL" box.
URL used was (http://schools.coe.ru.ac.za/wiki/Image:Mary_Waters_Secondary_School.JPG)

(am just wondering whether the capital .JPG is a cause here)

Error reported is:

Warning: imagecreatefromstring() [function.imagecreatefromstring]: Data is not in a recognized format in /var/www/awarenet2/modules/images/download.act.php on line 39

Warning: Cannot modify header information - headers already sent by (output started at /var/www/awarenet2/modules/images/download.act.php:39) in /var/www/awarenet2/core/recordalias.inc.php on line 239

Warning: Cannot modify header information - headers already sent by (output started at /var/www/awarenet2/modules/images/download.act.php:39) in /var/www/awarenet2/core/recordalias.inc.php on line 240
The page you requested moved here.

Discussion

strix - 2009-09-03

Not a bug. The URL you used is an HTML page, the url of the image you want is:

http://schools.coe.ru.ac.za/mediawiki/images/3/37/Mary_Waters_Secondary_School.JPG

Could fail more gracefully though...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anna Wertlen - 2009-09-08

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ronald Wertlen - 2009-09-10

summary: Add image from link broken --> Raw error message appears - PHP error unhandled.

status: closed --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ronald Wertlen - 2009-09-10

Hi Strix,
sorry about the delay getting back to you.

Reopened with a new title. Don't know if this is a general problem, but it is not acceptable to see PHP file names flashing across the screen like this. This information is not for the user and so she should not see it.

It would be great to have a nice error message, which actually reports what's wrong, but Kapenta should never give out messages like these to the user display.

Thanks, Ron

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ronald Wertlen - 2009-09-10

summary: Raw error message appears - PHP error unhandled. --> Raw error message appears - PHP error unhandled?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

strix - 2009-09-10

They're PHP warnings, they can be turned off in production. For now they're useful - without them it would have just redirected back to the upload form. In any case, it no longer does this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

strix - 2009-09-10

status: open --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

strix - 2009-09-10

FYI, the error is managed, warnings happen when you don't use try/catch to check for errors, I prefer to check the error from the return value.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.