Re: [avr-llvm-devel] Inline assembly. Mostly just a stub.

[Borja F. <bor...@gm...>]

The patch looks good, some comments about coding style. We use a different
standard compared to llvm's, most important things are:
1) braces go into new lines.
2) always place braces even if they're for a 1 line statement

this:
+  std::pair<unsigned, const TargetRegisterClass*>
+            getRegForInlineAsmConstraint(const std::string &Constraint,
+            EVT VT) const;
+
should be:
std::pair<unsigned, const TargetRegisterClass *>     << space between name
and *
getRegForInlineAsmConstraint(const std::string &Constraint, EVT VT) const;

this:
+  ConstraintWeight getSingleConstraintMatchWeight(
+    AsmOperandInfo &info, const char *constraint) const;
should be:
ConstraintWeight
getSingleConstraintMatchWeight(AsmOperandInfo &info,
                                                const char *constraint)
const;


if there are any other small details i can fix them post commit.



2013/6/13 Borja Ferrer <bor...@gm...>

> Nice Stepan, I will review your patch later on. You should be given commit
> access to this svn repo until we finally decide where to move on all of the
> code.
>
>
> 2013/6/13 Stepan Dyatkovskiy <stp...@na...>
>
>> Hi all,
>> I'll use this reference for implementation, right?
>>
>> http://savannah.nongnu.org/download/avr-libc/avr-libc-user-manual-1.8.0.pdf.bz2
>>
>> -Stepan.
>>
>> Stepan Dyatkovskiy wrote:
>> > Ops. Forget to apply patch itself...
>> >
>> > -Stepan.
>> >
>> > Stepan Dyatkovskiy wrote:
>> >> Hi all. That's a Thursday patch with inline asm. Currently the only
>> >> constraint is supported: register ('r').
>> >>
>> >> -Stepan.
>> >>
>> >>
>> ------------------------------------------------------------------------------
>> >>
>> >> This SF.net email is sponsored by Windows:
>> >>
>> >> Build for Windows Store.
>> >>
>> >> http://p.sf.net/sfu/windows-dev2dev
>> >> _______________________________________________
>> >> avr-llvm-devel mailing list
>> >> avr...@li...
>> >> https://lists.sourceforge.net/lists/listinfo/avr-llvm-devel
>> >>
>> >
>> >
>> >
>> >
>> ------------------------------------------------------------------------------
>> > This SF.net email is sponsored by Windows:
>> >
>> > Build for Windows Store.
>> >
>> > http://p.sf.net/sfu/windows-dev2dev
>> >
>> >
>> >
>> > _______________________________________________
>> > avr-llvm-devel mailing list
>> > avr...@li...
>> > https://lists.sourceforge.net/lists/listinfo/avr-llvm-devel
>> >
>>
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> avr-llvm-devel mailing list
>> avr...@li...
>> https://lists.sourceforge.net/lists/listinfo/avr-llvm-devel
>>
>
>