#89 Crash when saving using MP4v2 on 2.7.3

[Charlie Laabs]

I'm seeing a crash on 2.7.3 when remuxing an NVIDIA ShadowPlay recording to MP4v2 with video and audio set to output Copy. Tested MP4 and Mkv and saw no issue. This worked in 2.7.1.

I don't have debug log, but here's the output of admlog.txt when saving:

[HandleAction] 16:29:33-522 ************ SAVE_VIDEO **************
[admSaver::admSaver] 16:29:35-987 [Save] Encoder index=0
[admSaver::save] 16:29:35-987 Audio starting time 00:00:00,000
[admSaver::save] 16:29:35-987 [A_Save] Saving..
[ADM_Composer::checkCutsAreOnIntra] 16:29:35-987 Checking cuts start on keyframe..
[ADM_Composer::switchToSegment] 16:29:35-987 Trying to switch to seg 0 with startTime in reference pic= 0 ms
[ADM_Composer::seektoTime] 16:29:35-987 Seeking to a keyframe at 0 ms
[ADM_Composer::seektoTime] 16:29:35-987 Seeking to frame 0 at 0 ms
[ADM_Composer::seektoTime] 16:29:35-987 Seek to time without decoding ok
[ADM_Composer::switchToSegment] 16:29:35-987 Switched ok to segment 0 (dontdecode=1)
[ADM_Composer::checkCutsAreOnIntra] 16:29:35-987 seg 0: ref 0, refDTS=0
[ADM_Composer::checkCutsAreOnIntra] 16:29:35-987 seg 0: ref 0, imgDTS=0
[ADM_Composer::checkCutsAreOnIntra] 16:29:35-987 Ignoring first seg (unreliable DTS)
[ADM_Composer::checkCutsAreOnIntra] 16:29:35-987 Segment 0 ok
[admSaver::dealWithH26x] 16:29:35-988 Input is probably MP4 bitstream, target is annexB
[ADM_videoStreamCopy::ADM_videoStreamCopy] 16:29:35-988 Creating copy video stream, start time: 00:00:00,000
[ADM_videoStreamCopy::ADM_videoStreamCopy] 16:29:35-988 End time: 00:01:32,516
[ADM_EditorSegment::convertLinearTimeToSeg] 16:29:35-988 Frame time=0, taking first segment 
[ADM_videoStreamCopy::ADM_videoStreamCopy] 16:29:35-988 PTS/DTS delta=0 us
[ADM_EditorSegment::convertLinearTimeToSeg] 16:29:35-988 Frame time=0, taking first segment 
[ADM_Composer::getNonClosedGopDelay] 16:29:35-988 Not a bframe, stopping (1)
[ADM_Composer::getNonClosedGopDelay] 16:29:35-988 Found maximum non closed gop delay = 0
[ADM_EditorSegment::convertLinearTimeToSeg] 16:29:35-988 Frame time=0, taking first segment 
[ADM_videoStreamCopy::ADM_videoStreamCopy] 16:29:35-988  Fixating start time by 0
[ADM_videoStreamCopy::ADM_videoStreamCopy] 16:29:35-988  Starting DTS=0, PTS=0 ms
[ADM_videoStreamCopyToAnnexB::ADM_videoStreamCopyToAnnexB] 16:29:35-988 Iso to AnnexB  filter
[ADM_videoStreamCopyToAnnexB::ADM_videoStreamCopyToAnnexB] 16:29:35-988 Copy to annexB initialized
[ADM_edAudioTrackFromVideo::goToTime] 16:29:35-988  go to time 0.00 secs
[ADM_EditorSegment::convertLinearTimeToSeg] 16:29:35-988 Frame time=0, taking first segment 
[ADM_edAudioTrackFromVideo::goToTime] 16:29:35-988 => seg 0, rel time 0.00 secs
[MP4] Go to time succeeded chunk :0 time ask:0 time get:0
[admSaver::setupAudio] 16:29:35-988 Setting up 1 audio track(s)
[admSaver::setupAudio] 16:29:35-988 [audioTrack 0] Creating audio encoding stream, starttime 00:00:00,000(copy)
[audioCreateCopyStream] 16:29:35-988 Creating audio stream copy with compensation : startTime=00:00:00,000
[audioCreateCopyStream] 16:29:35-988 and shift =00:00:00,000
[ADM_audioStreamCopy::ADM_audioStreamCopy] 16:29:35-988 Creating copy stream, startTime=00:00:00,000, shift=0
[ADM_edAudioTrackFromVideo::goToTime] 16:29:35-988  go to time 0.00 secs
[ADM_EditorSegment::convertLinearTimeToSeg] 16:29:35-988 Frame time=0, taking first segment 
[ADM_edAudioTrackFromVideo::goToTime] 16:29:35-988 => seg 0, rel time 0.00 secs
[MP4] Go to time succeeded chunk :0 time ask:0 time get:0
[ADM_audioStreamCopyPerfect::ADM_audioStreamCopyPerfect] 16:29:35-988 Creating Perfect copy stream, startTime=00:00:00,000,  shift=0

[Peter V. G.]

i have the same problem. in Windows 10 1809 17763 (64bit). but Avidemux 2.7.1 works just fine and doesn't crash.