Re: [Avalontoolkit-discuss] changes required to get code working on windows

[Rohde, B. <ber...@no...>]

The file local.h defines FALSE if it's not already defined. For some reason, this check didn't kick in.

Could you check if you can find out why FALSE is defined in your environment and what value other than 0 it has?

Cheers,

Bernd


Hi,

This morning I did a 32bit windows build of the code using Visual
Studio Express 2010. To get things working I had to make the following
mods:


glandrum@... ~/avalontoolkit
$ svn diff common
Index: common/patclean.c
===================================================================
--- common/patclean.c   (revision 2)
+++ common/patclean.c   (working copy)
@@ -845,14 +845,14 @@
    ssmatch_t *best_match;
    int problem_found, match_applied;

-   // check parameters
-   if (IsNULL(mp)  ||  IsNULL(ssp)) return (FALSE);
-
    int i, j, k, iatom, jatom;
    int symbol;
    struct reaccs_bond_t *bp, bm;
    neighbourhood_t neighbour_array[MAXATOMS], *nbp;

+   // check parameters
+   if(IsNULL(mp)  ||  IsNULL(ssp)) return 0;
+
    if (mp->n_atoms > MAXATOMS)
    {
       fprintf(stderr,"Too many atoms in molecule '%s'\n",mp->name);
Index: common/reaccsio.c
===================================================================
--- common/reaccsio.c   (revision 2)
+++ common/reaccsio.c   (working copy)
@@ -1357,7 +1357,7 @@
             {
                tempfile = tempnam(tempdir, (const char *)NULL);
                fp = fopen(tempfile, "wb+");
-               MyFree((char *)tempdir);
+               //MyFree((char *)tempdir);
                if (IsNULL(fp))
                {
                    MyFree((char *)tempfile);



-greg