Menu

#2 misc fixes (lf_* macro defs, aclocal path, mkinstalldirs)

open
None
5
2005-02-02
2005-01-23
No

run into a few problems using acmkdir in version
0.11.4, and happened to fix them. i use: autoconf 2.59,
automake 1.9.4, m4 1.4.2.

- lf_*.m4 macros used obsoleted AC_DEFUN syntax : had
to quote macro names to get rid of the warnings. did
this for all m4/lf_*.m4 files: put the names between [ ]'s.

- when creating a new project, the aclocal command did
not see the lf_*.m4 macros, because they were installed
into /usr/local/share/aclocal. modified
src/acmkdir/Makefile.am and src/acmkdir/acmkdir.sh to
add a -I <dir> option to the aclocal call in the reconf
script. the dir will be $(datadir)/aclocal.

- autoheader complained about missing templates for the
definitions (AC_DEFINE) in lf_*.m4 files. fixed this by
adding the (3rd) comment argument to the definitions.

- LF_LINK_HEADERS calls the ./mkinstalldirs script to
create the link include directories. however, the
mkinstalldirs script was not copied to the new project
root by acmkdir, and it was not installed to
/usr/local/... when running 'make install' in the
autotoolset source dir. fixed this by adding
$(top_srcdir)/config/mkinstalldirs to autotoolset_DATA
in src/acmkdir/Makefile.am and added a cp to acmkdir.sh
(to the end of create_toplevel_dir) to copy the script
to the target directory.

to apply the patch: go to the source dir of 0.11.4, then
$ patch -u -p1 < difffile
$ ./reconf
$ ./configure
$ make
$ make install

regards, petschy

Discussion

  • Peter A. Felvegi

    the patch that fix the mentioned problems

     
  • Marcelo Roberto Jimenez

    • assigned_to: nobody --> mroberto
    • status: open --> pending
     
  • Marcelo Roberto Jimenez

    Logged In: YES
    user_id=67568

    Patch does not apply cleanly to CVS. Some of the changes have already
    been made. Please, try to get a cvs snapshot and do the patches there.
    Then resubmit, please.

     
  • Peter A. Felvegi

    • status: pending --> open
     
  • Peter A. Felvegi

    Logged In: YES
    user_id=1203107

    checked out from cvs and compared the versions:
    (cvs -z3
    -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/autotoolset
    co -P autotoolset)

    - the m4/lf_* files already contained the quotation fixes
    already (first issue above)

    - the AC_DEFINE comment fixes for autoheader were not yet
    applied, so i did it (third issue)

    - src/acmkdir is the same in 0.11.4 and cvs HEAD except for
    a few new files. the two files i've modified are Makefile.am
    and acmkdir.sh (this fixes the second and the fourth issue)

    the '/config' dir is present in 0.11.4, but missing
    completely in cvs HEAD. but my patched makefile copied
    mkinstalldirs from the '/config' dir to the shared data dir.
    oooops. then i copied mkinstalldirs from the old
    0.11.4/config to src/acmkdir/mkinstalldirs.sh, edited
    Makefile.am to produce mkinstalldirs from mkinstalldirs.sh
    very similarly as acmkdir from acmkdir.sh. BUT when tried to
    run 'reconf' or 'configure', they complained too about the
    missing '/config' dir. is this a bug? the directory was left
    out accidentally or intentionally?

    the patch i attach assumes that the '/config' dir is
    present. otherwise, i may send another patch for
    src/acmkdir/Makefile.am that generates mkinstalldirs from
    mkinstalldirs.sh. (what about the other files in ./config?)

    regards, petschy

     
  • Peter A. Felvegi

    the patch. details in the text.

     

Log in to post a comment.