Menu

#5 Bugfixes/code cleanups/enhancements

open
nobody
None
5
2013-02-19
2001-01-17
No

This is a patch to autostatus-1.2.1 which fixes several bugs, cleans up the code, and adds some features. Line numbers refer to the patched source files.

Bugfixes w/line numbers:

397+ Write status to new file, then rename to hopefully avoid corrupted status file in some cases
573+ Only send 'up' alerts if minimum threshold was reached
632 #129034 Messages get mailed to the wrong people
706,734 #112498 Time zone issues in 'autostatus' perl code
740+ Fix ALT tags to use correct variables $msg_xxx
794 Show 'maybe' status if 0 < count < any threshold
799 Use $msg_up variable for ALT text instead of string "is up"

Cleanups w/line numbers:

2 Makefile.in VERSION=1.2.1e
9 makestatus --> Autostatus in comment
Variable name cleanups (img/msg/thresh are now parallel)
global & 'local' --> 'my' variables
161+ readconfig subroutine
Subroutine comments --> additional, same formatting
More comments throughout
Reorder subroutines & code for readability

Enhancements w/line numbers:

43 Default HTML title is 'hostname Autostatus'
153 send_email off option for use with alert program
152,605+ Logging events to logfile (logfile option)
188+ Custom images (img_up, img_depfailed, etc. options)
246+ Compute custom thresholds in readconfig routine
404,829 More error checking on file operations
592+ External alert program fork/exec instead of system
594 More arguments for external alert program: contact address
Extra debugging output
649+ send_email function which uses Mail::Mailer module
740+,750,814 Add threshold & count values next to icons on page
747+ Display key for custom thresholds on page
755+,811+ Verbose mode shows deps & contacts on page (verbose option)
812+ http & telnet links for each host/address on page

Discussion

  • Charles R. Anderson

    None

     
  • Charles R. Anderson

    Patch file and info is availble on shell1.sourceforge.net:

    /home/users/cra/pub/autostatus/autostatus-1.2.1-to-1.2.1e.diff
    /home/users/cra/pub/autostatus/autostatus-1.2.1-to-1.2.1e-changes.txt

     
  • Charles R. Anderson

    autostatus-1.2.1-to-1.2.1e patch file

     

Log in to post a comment.