The package names need to be updated, but this is not trivial because of old jython scripts that refer to Java packages explicitly. This is a list of all the imports and a place to store the namespace changes.
I know this is a repeat ticket, but I can't find the old one.
TO BE CONSIDERED LATER:
org.das2.qds will be the interface and a few implementations, sufficient to support das2 apps.
org.das2.qdsops will be simple operators and depends only on org.das2.qds
org.das2.qdsutil will be more abstract operations (load ascii file) and depends on the remainder of the package.
note org.virbo.dataset contains DataSetOps and DataSetUtil, which should be moved appropriately.
Last edit: Jeremy Faden 2017-06-27
Search for imports in scripts:
Note all the discovery mechanisms will need to be updated as well:
My plan is to first implement the reverse map, so new names will be translated to old names, so I can discover any issues before breaking other peoples' codes. This could then be a last release of the 2016a branch, which would give some future support for the old branch with new scripts.
Also, some codes need to be imported that haven't been imported automatically. For example, SemanticOps should probably just be imported.
So here's a proposal for a Autoplot 2017 script:
2017-06-27: Note that DDataSet was left in org.das2.qds, otherwise refactoring would be more difficult.
Last edit: Jeremy Faden 2017-06-27
See also
https://sourceforge.net/p/autoplot/feature-requests/474
which is the old ticket.
.vap files contain references to paths that will need to be corrected.
I think org.das2.qds.array is too difficult, because there might be
So we should have a one-to-one-and-onto (bijective) mapping.
This refactoring should also take care of the BoxSelectionListener class BoxSelected method, which I've never been able to fix because of legacy scripts.
For example:
from nudnik.physics.uiowa.edu:/home/jbf/project/autoplot/script/lint/plotSymbolRedefined.jy
Last edit: Jeremy Faden 2017-05-25
IDL/Matlab scripts have references to full paths as well.
Last edit: Jeremy Faden 2017-05-31
reverse map has the problem that working names (org.das2.util.filesystem.FileSystem) are converted to non-working names (zipfs.FileSystem). Any place where a bad name would be merged into a good name won't work, so the whole reverse map for v2016a will not work.
Last edit: Jeremy Faden 2017-05-31
Launchers like org.virbo.autoplot.AutoplotDataServer can be supported by leaving this package name and adapters that launch into the new names. (org.autoplot.pngwalk.PngWalkTool1 is an example that shows this is manageable.)
I plan to commence this today. I will:
These will be the headers of the document at sftp://jfaden.net/home/jbf/ct/autoplot/rfe/528/worksheet.odt
Last edit: Jeremy Faden 2017-06-22
See also http://autoplot.org//autoplot2017
Note, importing org.das2.util.filesystem.FileSystem has the effect of importing org.
sftp://jfaden.net/home/jbf/ct/hudson/script/test037/3577243.jy shows this problem, where there is no import of org.virbo.autoplot.RenderType to correct. I don't think this should be (or can be) corrected automatically. The script should be corrected manually to explicitly import the symbol.
I will not plan on refactoring inputs for the Autoplot "server" which is used to provide plotting to IDL and Matlab. I don't think this gets a lot of use, and I don't think people really need to import things (though this is allowed).
The screenshots tool script showed where reflection was used (unnecessarly) to get a class reference. (I didn't know that org.autoplot.ScreenshotsTool was the class reference.) This will be another type of script that will not be corrected automatically.
should be simply:
Also with Java preferences, prefs are based on class path, so on Linux the preferences for org.virbo.autoplot.AutoplotUI are in ~/.java/.userPrefs/org/virbo/autoplot. These will not be supported, and I've been meaning to put these under the ~/autoplot_data directory anyway.
Dan also showed that I can get at the old user preferences by using something like: Preferences.userRoot().node("/org/virbo/autoplot/")
I thought I was going to have to drop all the user default settings.
Last edit: Jeremy Faden 2017-06-26
Bob's jnlp script on autoplot.org will need to be modified.
I've added a method AutoplotSettings.settings().getPreferences(Class) which will grab the old preferences. This will also make it easy to migrate to using ~/autoplot_data/config to store the preferences.
I get this strange feedback when entering the from...import... statement:
Since I haven't referred to virbo, I would expect that I wouldn't see this message.
Last edit: Jeremy Faden 2017-06-27
In the script panel type in "from org.autoplot import <C>" and see that there's a runtime error:
Verify that the filters GUI works properly. It was left grey (pending)...
A warning was issued incorrectly for any import of the form "from org.autoplot import AutoplotUI"