Re: [Autogen-users] 5.16.1 make check failure

[Dave H. <dav...@gm...>]

On Mon, Jun 18, 2012 at 5:38 PM, Bruce Korb <bru...@gm...> wrote:
> On 06/17/12 23:26, Harlan Stenn wrote:
>> On pogo, after fixing the zNotStr instance:
>>
>> ...
>> PASS: loop.test
>> PATH is
>> /usr/local/gnu/bin:/usa/stenn/bin:/usr/local/bin:/usr/local/gnu/bin:/opt/SUNWrtvc/bin:/opt/SUNWspro/bin:/opt/netbeans-5.5.1/bin:/usr/X11R6/bin:/usr/bin/X11:/usr/openwin/bin:/bin:/usr/bin:/usr/ccs/bin:/usr/ucb:/usr/local/etc:/etc:/usr/local/sbin:/sbin:/usr/sbin:.
>> creating make.tpl
>> creating make.out in
>> /pogo/dist/gnu/autogen/autogen-5.16.1/A.pogo/agen5/test/testdir
>> FAILURE: 7,13d6
>> <
>> <  == converts to:
>> <
>> <        foo=`pwd`&&  ls -l $$foo ; \
>> <        bar=$$foo continue=command \
>> <        make macros: $(MAKE) $* $@ $<  $% $? ; \
>> <        shell vars:  $${MAKE} $$# $$F $${?} $${*} $$$$
>> FAIL: make.test
>> ...
>>
>
> on PSP-OS1:
>
>> ------------------------------------------------------------------------
>> Configuration:
>>
>>   Source code location:   /home/bkorb/autogen-5.16.1pre7
>>   Compiler:               gcc -std=gnu99
>>   Compiler flags:         -g -O2
>>   Host System Type:       i386-pc-solaris2.11
>>   Install path:           /home/bkorb/build/os1
>>
>>   See config.h for further configuration information.
>> ------------------------------------------------------------------------
>> $ make > ~/build/os1/build.log 2> ~/build/os1/errors.log
>> $ make check >> ~/build/os1/build.log 2>> ~/build/os1/errors.log
>> gmake install >> ~/build/os1/build.log 2>> ~/build/os1/errors.log
>> $ gmake install >> ~/build/os1/build.log 2>> ~/build/os1/errors.log
>> $ find ~/build/os1/
>> bin/        build.log   errors.log  include/    lib/        share/
>> /var/tmp/bkorb-AFaOY0/ag
>> $ find ~/build/os1/bin -type f
>> /home/bkorb/build/os1/bin/xml2ag
>> /home/bkorb/build/os1/bin/autogen
>> /home/bkorb/build/os1/bin/autoopts-config
>> /home/bkorb/build/os1/bin/columns
>> $ fgrep ' tests ' ~/build/os1/build.log
>> All 24 tests passed
>> All 41 tests passed
>> All 4 tests passed
>> $ gcc --version
>> gcc-4.5 (GCC) 4.5.2
>
> On POGO.UDEL.EDU:
>
>> ------------------------------------------------------------------------
>> Configuration:
>>
>>   Source code location:   ..
>>   Compiler:               gcc -std=gnu99
>>   Compiler flags:         -g -O2
>>   Host System Type:       sparc-sun-solaris2.10
>>   Install path:           /usa/bkorb/autogen-5.16.1/_i
>>
>>   See config.h for further configuration information.
>> ------------------------------------------------------------------------
>> ~/autogen-5.16.1/_b
>> $ ( exec > build.log 2> err.log
>>> set -e
>>> gmake
>>> gmake check
>>> gmake install
>>> ) &
>
> That does not build:
>
>> $ cat err.log
>> ../../autoopts/usage.c: In function 'prt_extd_usage':
>> ../../autoopts/usage.c:469: warning: passing argument 1 of 'spn_ag_char_map_chars' discards qualifiers from pointer target type

Why would that warning break the build?  I didn't see -Werr being used.

> But that message is completely bogus:

It doesn't seem bogus to me.  See below.

>> #define SPN_WHITESPACE_CHARS(_s)      spn_ag_char_map_chars((char *)_s, 11)
>> static inline char *
>> spn_ag_char_map_chars(char * p, unsigned int mask_ix)
>> {
>>     unsigned char const * v = ag_char_map_spanners[mask_ix];
>>     if (v == NULL)
>>         v = calc_ag_char_map_spanners(mask_ix);
>>     while (v[(unsigned)*p])  p++;
>>     return p;
>> }
>>
>>         char const *  pzArgType;
>>         pzArgType = SPN_WHITESPACE_CHARS(pzArgType);
>
> the SPN_WHITESPACE_CHARS macro casts the pointer to "char *", stripping the qualifier.

Right, stripping the "const" qualifier triggers the warning.  No idea
why you didn't see it with gcc 4.5.2, but again what really broke the
build?  As Harlan mentioned he had to update a zNotStr reference to
the new identifier.

>  > $ gcc --version
>  > gcc (GCC) 4.2.0

Cheers,
Dave Hart