Re: [Autogen-users] At least it's consistent

[Bruce K. <bk...@gn...>]

On Sun, Sep 21, 2008 at 11:49 AM, Eric Blake <eb...@by...> wrote:
> I recently saw this exact error message on another project which did
> things like
> : ${RM=rm -f}
>
> where the solution was to add quotes:
> : ${RM='rm -f'}
>
> Perhaps that is the problem here?

I decided to do an egrep search instead of an eyeball search:

$ egrep '\$\{[a-zA-Z_0-9]+[^a-zA-Z0-9_}]' *
Makefile:am__cd = CDPATH="$${ZSH_VERSION+.}$(PATH_SEPARATOR)" && cd
Makefile.in:am__cd = CDPATH="$${ZSH_VERSION+.}$(PATH_SEPARATOR)" && cd

These are automake constructs, so I guess they're likely okay.

defs:    LD_LIBRARY_PATH=${lo_dir}:${LIBGUILE_PATH}:${LD_LIBRARY_PATH-/dev/null}
defs:: "=== Running $progname for ${testname} using ${SHELL=sh} ==="
defs.in:    LD_LIBRARY_PATH=${lo_dir}:${LIBGUILE_PATH}:${LD_LIBRARY_PATH-/dev/null}
defs.in:: "=== Running $progname for ${testname} using ${SHELL=sh} ==="

Yep.  Should have used egrep.  Those two defs.in lines have to be processed
by /usr/xpg4/bin/sh or else be rewritten.

getopt.test:  ${CC:-cc} ${CFLAGS} -c ${testname}${1}-getopt.c || \
getopt.test:${SHELL:-/bin/sh} ${top_srcdir}/autoopts/install-options-h
shell.test:            echo "$TEST_SHELL_LONGUSAGE_TEXT" | ${PAGER-more}
shell.test:            echo "$TEST_SHELL_LONGUSAGE_TEXT" | ${PAGER-more}

And these two tests need fixing, too.  I'll have a patch shortly.
Thanks - Bruce