Menu

#204 [patch] formatting/typo fixes

autogen
pending
None
1
2020-09-21
2020-09-20
No

Hello,

find attached two trivial patches fixing a) some typos and b) a formatting issue.

cu Andreas

2 Attachments

Discussion

  • Bruce Korb

    Bruce Korb - 2020-09-20
    • status: open --> accepted
    • assigned_to: Bruce Korb
     
  • Bruce Korb

    Bruce Korb - 2020-09-20

    Thank you!

     
  • Bruce Korb

    Bruce Korb - 2020-09-20
    • status: accepted --> pending
     
  • Bruce Korb

    Bruce Korb - 2020-09-20

    The acute accent diff is incorrect. In one case, I'm putting line splices at the end of each produced line (by the columns program), and I'm showing what that output looks like. The whole thing is enclosed in "@example" and "@end example" texi doc quotations.

    I've fixed the typos and those will be in the next release, thank you.

     
  • Andreas Metzler

    Andreas Metzler - 2020-09-21

    Bruce Korb wrote

    The acute accent diff is incorrect

    Ok, I thought I had doublechecked this dilgently. Pre-patch the manpage looked like this

    $ columns --first='#define TABLE' -c 2 -I4 --line=' ´ <<_EOF_
    one
    two
    three
    four
    _EOF_
    #define TABLE         one   two         three four
    

    And with the patch like this:

    $ columns --first='#define TABLE' -c 2 -I4 --line=' \' <<_EOF_
    one
    two
    three
    four
    _EOF_
    #define TABLE \
        one   two \
        three four
    

    The latter looks correct to me.

    And it is afaict exactly what can be found in the (html version of the) texinfo manual both with and with and without patch. Well except for the fact that doc/invoke-columns.texi is not regenerated and that doc/Makefile does not even know how to do so.

     
  • Bruce Korb

    Bruce Korb - 2020-09-21

    Getting backslashes into the output is tricky. The text in the examples has to vary based on output type and then you have to futz with it long enough to figure out which works with which flavor. "Yummy", but thank you for raising the issue. I actually want to stay focused on getting criminals out of our government during the next 6 weeks, so I'll take a gander once I feel better about the state of our "leadership" (so to speak). I'm even putting photography aside. :-O

     

Log in to post a comment.