Re: [Audit-test-developer] [PATCH 3/5] audit-test/syscalls: add aarch64 support

[Linda K. <lin...@hp...>]

On 07/03/2014 03:45 AM, AKASHI Takahiro wrote:
> This patch defines a architecture type for arm64/aarch64, and excludes some
> system call tests. For example, chown is not a native system call
> on arm64/aarch64 and so __NR_chown is not defined.

Are there any arm64/aarch64-specific syscalls that should be added?
We don't audit all syscalls but we do audit ones that have permission
checks or can change anything that would affect those checks.

-- ljk

> 
> Signed-off-by: AKASHI Takahiro <tak...@li...>
> ---
>  audit-test/utils/augrok       |    2 ++
>  audit-test/utils/bin/Makefile |    8 ++++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/audit-test/utils/augrok b/audit-test/utils/augrok
> index c309d4f..15b33c8 100755
> --- a/audit-test/utils/augrok
> +++ b/audit-test/utils/augrok
> @@ -585,6 +585,8 @@ our (%archtab) = (
>      'c0009026' => 'alpha',
>      '40000028' => 'arm',
>      '28'       => 'armeb',
> +    'c00000b7' => 'aarch64',
> +    '800000b7' => 'aarch64eb',
>      '4000004c' => 'cris',
>      '2e'       => 'h8300',
>      '40000003' => 'i386',
> diff --git a/audit-test/utils/bin/Makefile b/audit-test/utils/bin/Makefile
> index 6c361e1..b0f4485 100644
> --- a/audit-test/utils/bin/Makefile
> +++ b/audit-test/utils/bin/Makefile
> @@ -112,7 +112,6 @@ ALL_EXE		= $(CAPS_EXE) \
>  		  do_bind \
>  		  do_chdir \
>  		  do_chmod \
> -		  do_chown \
>  		  do_clone \
>  		  do_delete_module \
>  		  do_dummy \
> @@ -130,7 +129,6 @@ ALL_EXE		= $(CAPS_EXE) \
>  		  do_init_module \
>  		  do_ioctl \
>  		  do_kill \
> -		  do_lchown \
>  		  do_lgetxattr \
>  		  do_link \
>  		  do_linkat \
> @@ -174,6 +172,10 @@ ALL_EXE		= $(CAPS_EXE) \
>  		  do_utimensat \
>  		  do_utimes
>  
> +ifneq ($(MACHINE), aarch64)
> +ALL_EXE		+= do_chown \
> +		  do_lchown
> +endif
>  ifeq ($(MODE), 32)
>  ifeq ($(MACHINE), ppc64)
>  ALL_EXE		+= $(ONLY32P_EXE)
> @@ -189,8 +191,10 @@ endif
>  ifeq ($(MACHINE), ia64)
>  ALL_EXE		+= $(ONLYIA64_EXE)
>  else
> +ifneq ($(MACHINE), aarch64)
>  ALL_EXE		+= $(ONLY86_EXE)
>  endif
> +endif
>  
>  $(CAPS_EXE): LDLIBS += -lcap
>  ifeq ($(LSM_SELINUX), yes)
>