Re: [Audit-test-developer] [PATCH 15/20] utils/network-server: remove unused netfilter-related code

[Jiri J. <jja...@re...>]

On 04/22/2013 10:21 PM, Linda Knippers wrote:
> Is this truly dead code or is it made unnecessary by other patches in
> this series?  I've lost track.
> 

It was dead code even before this (or previous) series.

There are multiple leads to this statement - first of all, it appears
unused completely. clroute.bash is only called from runnc4.bash and
runnc[46].bash is called only from lblnet_tst_server.c, function
ctl_nccon. This function is only called from within

  } else if (strcasecmp(ctl_cmd, "nccon") == 0) {
          ctl_nccon(rem_sock, ctl_param);

and "nccon" doesn't appear anywhere else in the suite.

Another lead suggests this code doesn't even work properly, it would
seem that it assumes "routed" configuration, without bridge:

  $ grep ifconfig utils/network-server/clroute.bash
  ifconfig $SECNET_SVR_DEV $SECNET_SVR_IPV4 netmask $SNET4MASK
  ifconfig $SECNET_SVR_DEV up

(this should be $BRIDGE_FILTER in fact)

Jiri