Re: [Audacity-devel] Massive slow down of Nyquist effects when label track present

[Steve t. F. <ste...@gm...>]

On 16 January 2017 at 11:56, James Crook <cr...@in...> wrote:
>> Question for James (RM), what do you want to do with this? I can send
>> you a patch for review if that will help.
>
> It seems safe from my perspective, even with my hat on.
>    18 seconds to 412 is a highly embarrassing regressions.
>    18 seconds to 6 seconds is a very worthwhile improvement.
>
> So there is both carrot and stick to get these changes in.  And we're
> not 'moments away' from having an RC.
>
> I don't want to commit them from a patch, but if there is a branch ready
> to review/merge then I am ready to do so, and it is very likely to go in.

I've made a pull request:
https://github.com/audacity/audacity/pull/178

Steve


>
> --James (as RM)
>
>
>
>
> On 1/16/2017 11:31 AM, Steve the Fiddle wrote:
>> Thanks Paul, that works fine on Linux (I've not tested on Mac, but I
>> presume that you have?)
>>
>> There are now three parts to a full fix for this problem:
>>
>> 1) Reduce the calls to YieldFor to a reasonable rate.
>> 2) Paul's fix for the label track issue.
>> 3) Remove (comment out) the unused updating of TextClipFlag.
>>
>> Testing on my old dual core Pentium laptop with Debian stable with
>> these three fixes:
>> * There is no slowdown of Nyquist (or other) effects when there is a label track
>> * There is "significant" improvement in the speed of Nyquist effects
>> whenever the effect takes long enough to show a progress bar.
>>
>> Performance test:
>> 30 minutes of audio, Silence Finder.
>>
>> No label track:
>> Audacity 2.1.2, release build: 18 seconds
>> Audacity 2.1.3 alpha (not patched): 18 seconds
>> Patched Audacity 2.1.3 alpha: 6 seconds
>>
>> With label track:
>> Audacity 2.1.2 release build: 18 seconds
>> Audacity 2.1.3 alpha (not patched): 412 seconds
>> Patched Audacity 2.1.3 alpha: 6 seconds
>>
>> Question for James (RM), what do you want to do with this? I can send
>> you a patch for review if that will help.
>>
>> Steve
>>
>>
>> On 15 January 2017 at 15:02, Peter Sampson
>> <pet...@gm...> wrote:
>>> Tested this on 07Jan17 Windows nightly and Mac debug nightly
>>> of 15Jan17.
>>>
>>> Testing by generating a 30 minute mono tone and then adding
>>> a track with 100 labels - using Niquist effect High Pass Filter
>>>
>>> 1)  On W10 there was no differebce between the two runs at c.15 seconds.
>>>
>>> 2) on Mac with debug build the no label track took 53 seconds
>>> wit the label track this extended to 64 seconds i.e. a 20% increase
>>>
>>> Peter.
>>>
>>> ------------------------------------------------------------------------------
>>> Developer Access Program for Intel Xeon Phi Processors
>>> Access to Intel Xeon Phi processor-based developer platforms.
>>> With one year of Intel Parallel Studio XE.
>>> Training and support from Colfax.
>>> Order your platform today. http://sdm.link/xeonphi
>>> _______________________________________________
>>> audacity-devel mailing list
>>> aud...@li...
>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>>
>> ------------------------------------------------------------------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today. http://sdm.link/xeonphi
>> _______________________________________________
>> audacity-devel mailing list
>> aud...@li...
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today. http://sdm.link/xeonphi
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel