Re: [Audacity-devel] Gnome shutdown alert removed with rev 12590? (Campbell Barton's patches)

[James C. <cr...@in...>]

> Yep - just checked and building with GTK enabled, this code can be
> removed without any warnings/errors and audacity still loads fine.

Hi Campbell.  That's not the point.
Have you inadvertently removed a piece of functionality?

Try a version before the change running and log out of your account or 
initiate a system shutdown with unsaved changes in Audacity.  A dialog 
should appear, if the original code was correct (dlls found with the 
right names and resolve fine etc). Now try with the version with the 
variable removed.

--James.



On 26/09/2013 14:09, Campbell Barton wrote:
> On Thu, Sep 26, 2013 at 8:30 PM, James Crook <cr...@in...> wrote:
>> Hi Richard,
>>
>> I noticed that in applying Campbell Barton's changes with
>> https://code.google.com/p/audacity/source/detail?r=12590
>>
>> that you removed:
>>
>> GnomeShutdown GnomeShutdownInstance;
>>
>> If it goes, surely all the content between 401 and 568 should go as well
>> as the class is no longer being used??
> Yep - just checked and building with GTK enabled, this code can be
> removed without any warnings/errors and audacity still loads fine.
>
>> I'm on Windows so can't test this code and see if there is a change
>> through removing it.  It does look as if the constructor for this
>> variable was doing something useful for us on gnome2 platform - setting
>> things up to prompt us to save our work when there is a system
>> shutdown.  So the creation of the GnomeShutdownInstance should stay?
>>
>>
>> --James.
>>
>>
>>