Re: [Audacity-devel] Pan Envelope Editing?
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Martyn S. <mar...@gm...> - 2013-05-28 23:11:06
|
Hi John Once again, that patch looks like a lot of progress, and thanks for doing the things that I/we am/are asking for! I know it can be a pain but we need to keep the code as clean as we can. I have not read all (or tried) your latest patch (there are over 1000 lines) but I do have a few problems with it. Imagine that your code were accepted as EXPERIMENTAL and subsequently as main-stream. We would do a global search for EXPERIMENTAL_OUTPUT_DISPLAY and remove all the #ifdefs, would the code be in the state that you wanted it? I suspect probably 'yes'. Now imagine that we committed the patch and then you did no more work on it. Then three years down the line we decided that it wasn't a feature we wanted and we did a global search for EXPERIMENTAL_OUTPUT_DISPLAY and removed all the cases. Would we get back to 'clean' code, or would we have a load of things that we don't really need? I'll pick on 'panZero' in HandleSliders as an example. Why would we have if(panZero) MakeParentRedrawScrollbars(); without the rest? (And that should really be if(panZero) MakeParentRedrawScrollbars(); to make it consistent with the style of the surrounding code, which we like.) Things like - void SetPan(float newPan); + bool SetPan(float newPan); definitely need to be wrapped in EXPERIMENTAL_OUTPUT_DISPLAY. For me, longer declarations should have the whole declaration wrapped, not just the line of it that has changed (for easier reading). Others may disagree. Maybe you've done this, but please check that your patch compiles to the same as HEAD with EXPERIMENTAL_OUTPUT_DISPLAY turned off. I don't know how easy that is to check though! Or how you'd do it ;-). HTH Martyn On 28/05/2013 21:47, Thales wrote: > Okay, I've attached my latest patch. It's not done yet, but what > I've done is fix the various bugs mentioned and I added a #define > EXPERIMENTAL_OUTPUT_DISPLAY to separate the display code. I hope > I've separated the code well enough. I did have to do some code > rewrites. There are a few variables here and there that I left in > the main code section. let me know if that's okay. Also, I didn't > separate out the pan and gain slider elements. I assume those are > okay left in the main code section? > > Thanks, > ...John > > ---------------------------------------------------------------------- > *From:* Thales <tha...@ya...> > *To:* "aud...@li..." > <aud...@li...> > *Sent:* Friday, May 24, 2013 10:18 AM > *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > I'm a bit busy right now, but I'm going to get to work on this next week! > > Thanks! > ...John > > ---------------------------------------------------------------------- > *From:* Martyn Shaw <mar...@gm...> > *To:* Thales <tha...@ya...>; aud...@li... > *Sent:* Tuesday, May 21, 2013 6:59 PM > *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > Yes! Great input Steve! I'm sure that John will react to this. To > me this looks like a very good feature in the future, showing what > will be the rendered with all the controls, including a (promised) pan > envelope, which I believe will be the next stage! > > I'd like to see the current code committed under EXPERIMENTAL first > though, and these bugs fixed. > > TTFN > Martyn > > On 21/05/2013 17:48, Thales wrote: > > Thanks, Steve. > > > > This is the kind of feedback I need! I'll have a look at these > > issues. > > > > Regards, > > ...John > > > > > > ---------------------------------------------------------------------- > > *From:* Steve the Fiddle <ste...@gm... > <mailto:ste...@gm...>> > > *To:* Audacity-Devel list <aud...@li... > <mailto:aud...@li...>> > > *Sent:* Monday, May 20, 2013 8:52 PM > > *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > > > 1) Create a stereo track > > 2) Split Stereo to Mono > > 3) Pan the tracks individually > > 4) Join Stereo Tracks > > > > The tracks are not redrawn correctly. I end up with a stereo track > > with something similar to a mono track below it. > > The display sorts itself out if I resize the vertical height. > > > > Steve > > > > On 21 May 2013 02:44, Steve the Fiddle <ste...@gm... > <mailto:ste...@gm...> > > <mailto:ste...@gm... > <mailto:ste...@gm...>>> wrote: > > > Is VirtualStereo_MidDesign_5_16_13.patch the current patch? > > > > > > Looking good so far. > > > > > > Is there any point in having virtual stereo for the spectrogram > views? > > > If we want this then it is not currently working correctly, but I > > > don't see much point in having the virtual stereo views for anything > > > other than waveform views. > > > > > > > > > The cursor only appears on the left virtual channel. Is that > intended? > > > If it is, why? > > > > > > Steve > > > > > > On 21 May 2013 01:48, Vaughan Johnson <va...@au... > <mailto:va...@au...> > > <mailto:va...@au... > <mailto:va...@au...>>> wrote: > > >> Sorry, that was too obvious to me -- that it's a setting so it > > wouldn't > > >> fix previously inserted tabs, so I misread it. > > >> > > >> = V > > >> > > >> On 5/20/2013 4:32 PM, Martyn Shaw wrote: > > >>> Yes, I do do too, but it doesn't fix past mistakes ;-). You > need to > > >>> do a search and replace. > > >>> > > >>> Martyn > > >>> > > >>> On 21/05/2013 00:28, Vaughan Johnson wrote: > > >>>> That is, I hit Tab and it inserts 3 spaces. > > >>>> > > >>>> - V > > >>>> > > >>>> On 5/20/2013 3:55 PM, Vaughan Johnson wrote: > > >>>>> > > >>>>> Yes, it does. I've been using it for years. > > >>>>> > > >>>>> - V > > >>>>> > > >>>>> > > >>>>> On 5/19/2013 3:50 PM, Martyn Shaw wrote: > > >>>>>> It probably won't, but you should set it anyway.Do a global > search > > >>>>>> for tabs and replace them with 3 spaces. It doesn't take long. > > >>>>>> > > >>>>>> HTH > > >>>>>> Martyn > > >>>>>> > > >>>>>> On 17/05/2013 00:10, Thales wrote: > > >>>>>>> Thanks, Vaughan. > > >>>>>>> > > >>>>>>> I did know that part, just wondering if that would make my > > code square > > >>>>>>> with the repository. It seems like it would! > > >>>>>>> > > >>>>>>> > > >>>>>>> ...John > > >>>>>>> > > >>>>>>> > > >>>>>>> > > ---------------------------------------------------------------------- > > >>>>>>> *From:* Vaughan Johnson <va...@au... > <mailto:va...@au...> > > <mailto:va...@au... <mailto:va...@au...>>> > > >>>>>>> *To:* aud...@li... > <mailto:aud...@li...> > > <mailto:aud...@li... > <mailto:aud...@li...>> > > >>>>>>> *Sent:* Thursday, May 16, 2013 2:19 PM > > >>>>>>> *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > >>>>>>> > > >>>>>>> On 5/16/2013 10:17 AM, Thales wrote: > > >>>>>>> > ... > > >>>>>>> > Regarding formatting and spacing and tabs. I'm not > > really sure > > >>>>>>> how to > > >>>>>>> > check that with certainty. Can Visual Studio be set up > > so that I > > >>>>>>> don't > > >>>>>>> > run into that problem? Setting tab to 0 maybe? > > >>>>>>> > > >>>>>>> Tools > Options > Text Editor > C/C++ > Tabs > > >>>>>>> > > >>>>>>> - V > > >>>>>>> > > >>>>> > > >>>> > > >>>> > > > ------------------------------------------------------------------------------ > > >>>> Try New Relic Now & We'll Send You this Cool Shirt > > >>>> New Relic is the only SaaS-based application performance > > monitoring service > > >>>> that delivers powerful full stack analytics. Optimize and > > monitor your > > >>>> browser, app, & servers with just a few lines of code. Try > New Relic > > >>>> and get this awesome Nerd Life shirt! > > http://p.sf.net/sfu/newrelic_d2d_may > > >>>> _______________________________________________ > > >>>> audacity-devel mailing list > > >>>> aud...@li... > <mailto:aud...@li...> > > <mailto:aud...@li... > <mailto:aud...@li...>> > > >>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > >>>> > > >>> > > >>> > > > ------------------------------------------------------------------------------ > > >>> Try New Relic Now & We'll Send You this Cool Shirt > > >>> New Relic is the only SaaS-based application performance > > monitoring service > > >>> that delivers powerful full stack analytics. Optimize and monitor > > your > > >>> browser, app, & servers with just a few lines of code. Try New > Relic > > >>> and get this awesome Nerd Life shirt! > > http://p.sf.net/sfu/newrelic_d2d_may > > >>> _______________________________________________ > > >>> audacity-devel mailing list > > >>> aud...@li... > <mailto:aud...@li...> > > <mailto:aud...@li... > <mailto:aud...@li...>> > > >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > >>> > > >> > > >> > > > ------------------------------------------------------------------------------ > > >> Try New Relic Now & We'll Send You this Cool Shirt > > >> New Relic is the only SaaS-based application performance > > monitoring service > > >> that delivers powerful full stack analytics. Optimize and > monitor your > > >> browser, app, & servers with just a few lines of code. Try New > Relic > > >> and get this awesome Nerd Life shirt! > > http://p.sf.net/sfu/newrelic_d2d_may > > >> _______________________________________________ > > >> audacity-devel mailing list > > >> aud...@li... > <mailto:aud...@li...> > > <mailto:aud...@li... > <mailto:aud...@li...>> > > >> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > > ------------------------------------------------------------------------------ > > Try New Relic Now & We'll Send You this Cool Shirt > > New Relic is the only SaaS-based application performance monitoring > > service > > that delivers powerful full stack analytics. Optimize and monitor your > > browser, app, & servers with just a few lines of code. Try New Relic > > and get this awesome Nerd Life shirt! > http://p.sf.net/sfu/newrelic_d2d_may > > _______________________________________________ > > audacity-devel mailing list > > aud...@li... > <mailto:aud...@li...> > > <mailto:aud...@li... > <mailto:aud...@li...>> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > > > > > > > > ------------------------------------------------------------------------------ > > Try New Relic Now & We'll Send You this Cool Shirt > > New Relic is the only SaaS-based application performance monitoring > service > > that delivers powerful full stack analytics. Optimize and monitor your > > browser, app, & servers with just a few lines of code. Try New Relic > > and get this awesome Nerd Life shirt! > http://p.sf.net/sfu/newrelic_d2d_may > > > > > > > > _______________________________________________ > > audacity-devel mailing list > > aud...@li... > <mailto:aud...@li...> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring > service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ > audacity-devel mailing list > aud...@li... > <mailto:aud...@li...> > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > > ------------------------------------------------------------------------------ > Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET > Get 100% visibility into your production application - at no cost. > Code-level diagnostics for performance bottlenecks with <2% overhead > Download for free and get started troubleshooting in minutes. > http://p.sf.net/sfu/appdyn_d2d_ap1 > > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |