Re: [Audacity-devel] Pan Envelope Editing?
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Thales <tha...@ya...> - 2013-05-21 16:47:52
|
Hello Martyn, "What do you have on your list of 'things left to do' for this?" I'm not really sure. I have to find all of the places that are affected, which is why I'll probably need help from those who know Audacity well! "I'm not even sure if 'virtual stereo' is a good description, although I've been happy to go along with that internally." -- How about "Mono as Stereo"? "The EXPERIMENTAL thing is designed for major inputs like this, and I think that you should look at it. If all the changes to the code were wrapped in #ifdef EXPERIMENTAL_OUTPUT_DISPLAY" Okay, I'll look at that. I presume this is all leading up to a pan envelope as the payoff here. Thanks, ....John ________________________________ From: Martyn Shaw <mar...@gm...> To: aud...@li... Sent: Monday, May 20, 2013 6:30 PM Subject: Re: [Audacity-devel] Pan Envelope Editing? Hi John Once again I have tried your code but not reviewed it. The functionality is getting better all the time, from my point of view, but it does worry me a little that there hasn't been any other input to this development (like from QA). I'm not even sure if 'virtual stereo' is a good description, although I've been happy to go along with that internally. What do you have on your list of 'things left to do' for this? I think that changing the yellow text over the waveform to add a '- Virtual Stereo' or something would be nice. I think I put that code in but don't remember exactly where, sorry! I've forgotten what other things I said I would like as well. The EXPERIMENTAL thing is designed for major inputs like this, and I think that you should look at it. If all the changes to the code were wrapped in #ifdef EXPERIMENTAL_OUTPUT_DISPLAY (or something like that) with that turned off by default in Experimental.h then I could think about committing it, and people could try it. I know that's a complete pain, but sometime it's necessary. TTFN Martyn On 16/05/2013 18:17, Thales wrote: > Hello Martyn, > > Your idea for transition code to the mainstream version sounds like a > good one! I've pushed the design and implementation forward. I > fixed the height problem on loading a pan != 0 state, and I added a > entry to Preferences to turn the feature on/off. I've also updated > other areas of code for the virtual stereo feature. There are > probably more areas to add to, which I'll learn as I study the code! > > I've attached the latest patch. > > Regarding formatting and spacing and tabs. I'm not really sure how > to check that with certainty. Can Visual Studio be set up so that I > don't run into that problem? Setting tab to 0 maybe? > > Thanks, > ...John > > > ---------------------------------------------------------------------- > *From:* Martyn Shaw <mar...@gm...> > *To:* Thales <tha...@ya...>; aud...@li... > *Sent:* Tuesday, May 14, 2013 6:58 PM > *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > Hi John > > I realise that this isn't 'finished' and is very much 'work in > progress'. I'd like to commit it as EXPERIMENTAL (search the code) so > that it is 'in there' for others to work on, and testable by others as > well. Many features have made their way into our mainstream code via > that route. > > And please ask for help if you need it! I'll do my best, and others > may contribute as well. > > TTFN > Martyn > > On 14/05/2013 06:36, Thales wrote: > > Hi Martyn, > > > > I'll have a look at that. The code I submitted wasn't meant to > > be complete. I just wanted to give you an idea of where things are! > > I didn't want to code everything up only to find it was all for > > not! Actually, I'm not sure of all of the things that would be > > affected by these changes, so I may need help on that. > > > > ...John > > > > ---------------------------------------------------------------------- > > *From:* Martyn Shaw <mar...@gm... > <mailto:mar...@gm...>> > > *To:* Martyn Shaw <mar...@gm... > <mailto:mar...@gm...>> > > *Cc:* Thales <tha...@ya... <mailto:tha...@ya...>>; > aud...@li... > <mailto:aud...@li...> > > *Sent:* Sunday, May 12, 2013 5:35 PM > > *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > > > > > > > On 12/05/2013 20:33, Martyn Shaw wrote: > > > Hi John > > > > > > I have had a look at your patch and tried it out and I think you > have > > > made great progress, I like it a lot. > > > > > > You have been using tabs instead of 3 spaces, and are a little > > > inconsistent in the code in places so I have tidied that a > little and > > > attach a slightly modified version of your patch. > > > > > > There is a display problem when I open an aup file with a stereo > track > > > and a mono track with the pan away from zero - the vs track gets > drawn > > > over the top of the stereo track until I somehow force a redraw, and > > > then the top track of the virtual pair is twice the size of the > bottom > > > one. > > > > I have noticed that the 'height' parameter of wavetrack in the aup is > > being written incorrectly - probably relevant, since the aup shouldn't > > change with your modifications, as they are only display-related. > > > > TTFN > > Martyn > > > > > We do not want/need to have any extra things stored in the project > > > file, as this is only about the display. > > > > > > We need to think about how to turn this effect on and off, by > project, > > > perhaps setting a pref in Preferences -> Interface -> Behaviors and > > > storing it in the project file? > > > > > > I have attached a png of a couple of tracks so that others can see > > > progress on this without applying the patch. The mono track has the > > > pan set to the left and the effects can be seen on the track. The > > > upper stereo track also has been 'panned' left and had the gain > > > increased as well as an envelope applied. > > > > > > TTFN > > > Martyn > > > > > > On 09/05/2013 23:43, Thales wrote: > > >> > > >> Hello Martyn, > > >> > > >> I've set it up so that it maintains the same height when > > >> panning. The patch is attached. > > >> > > >> Thanks! > > >> ...John > > >> > > >> > ---------------------------------------------------------------------- > > >> *From:* Martyn Shaw <mar...@gm... > <mailto:mar...@gm...> > > <mailto:mar...@gm... <mailto:mar...@gm...>>> > > >> *To:* Thales <tha...@ya... <mailto:tha...@ya...> > <mailto:tha...@ya... <mailto:tha...@ya...>>>; > > aud...@li... > <mailto:aud...@li...> > > <mailto:aud...@li... > <mailto:aud...@li...>> > > >> *Sent:* Wednesday, May 8, 2013 7:20 PM > > >> *Subject:* Re: [Audacity-devel] Pan Envelope Editing? > > >> > > >> Thanks John > > >> > > >> This is looking promising, from a user perspective. But for me the > > >> track that is panned is changing size as I move the pan slider from > > >> zero, and I would rather it stayed the same size, so the display > > >> doesn't jump about. Just splitting into two. > > >> > > >> I have not reviewed your code, just had a quick look at the > results. > > >> I'll try and get back to that soon. > > >> > > >> TTFN > > >> Martyn > > >> > > >> On 08/05/2013 02:17, Thales wrote: > > >> > Okay, I'm checking in to let you know I'm progressing on the > design > > >> > and implementation. I've tried about three different designs, > > >> > hoping for an easy solution, but it appears brute force > (changing > > >> lots > > >> > of locations) is required to make this work. Quite a bit of > work. > > >> > Here is where I am so far. > > >> > > > >> > If we want to save the state of the virtual track, then the > Track > > >> > class member variables "mYv" and "mHeightv" will need to be > > saved to > > >> > the project file. > > >> > > > >> > I've attached the latest patch. > > >> > > > >> > Thanks! > > >> > ...John > > > <snip> > > > > > > > > > > > ------------------------------------------------------------------------------ > > AlienVault Unified Security Management (USM) platform delivers complete > > security visibility with the essential security capabilities. > Easily and > > efficiently configure, manage, and operate all of your security > controls > > from a single console and one unified framework. Download a free trial. > > http://p.sf.net/sfu/alienvault_d2d > > > > > > > > _______________________________________________ > > audacity-devel mailing list > > aud...@li... > <mailto:aud...@li...> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > > > > > ------------------------------------------------------------------------------ > AlienVault Unified Security Management (USM) platform delivers complete > security visibility with the essential security capabilities. Easily and > efficiently configure, manage, and operate all of your security controls > from a single console and one unified framework. Download a free trial. > http://p.sf.net/sfu/alienvault_d2d > > > > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ audacity-devel mailing list aud...@li... https://lists.sourceforge.net/lists/listinfo/audacity-devel |