Re: [Audacity-devel] Bug 137
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Edgar <edg...@wa...> - 2011-08-10 16:35:14
|
Michael Chinen wrote: > > I would prefer the code would be permanent since we want to check > for write errors. > Also, it could be messy to revert a large patch like this 6-8 weeks later. > The code to pop a dialog was only intended to pin down bug 137, it would be committed as part of a code freeze, the beta would be released, and the patch reverted during the freeze. If desired, I could do a similar readReturn patch to HEAD, during the freeze, once writeReturn was committed, in a couple of days. The only "recovery" code in "exhaustive" is to eliminate a cascade of dialog boxes on error. I put that in after Gale & Martyn decided that cascading error dialogs was bad. I could pull it out so there were no logic changes, just dialogs on error but I doubt that would be good. The permanent code (error recovery) is very complex and not something to contemplate pre-2.0 unless a new P1 was created with the understanding and coding support of at least two Programmers with commit rights. Some of this would involve some pretty major decisions--QA &/or Team involvement required! As for your suggestions on changing my patch, most of them are way beyond my ability (other than the stuff marked "unnecessary" -- which I added to be "exhaustive") to change. If someone wants to use my code as a starting point that would be great, I'm just at the limits of my coding ability here! -- View this message in context: http://audacity.238276.n2.nabble.com/Bug-137-tp6614577p6673143.html Sent from the audacity-devel mailing list archive at Nabble.com. |