Re: [Audacity-devel] Fwd: [Bug 296] Control characters in .aup tag values prevent project opening
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Vaughan J. <va...@au...> - 2011-03-01 23:31:42
|
Thanks, Michael! - V On 2/28/2011 6:25 PM, Michael Chinen wrote: > On Tue, Mar 1, 2011 at 1:02 AM, Vaughan Johnson > <va...@au...> wrote: >> On 2/27/2011 4:16 PM, Martyn Shaw wrote: >>> >>> >>> On 27/02/2011 01:38, Vaughan Johnson wrote: >>>>> Gale Andrews<ga...@au...> changed: >>>>> <snip> Also Leland's comment >>>>> implied (to me) that the .aup should handle control characters in metadata >>>>> tags, so making me think this was something we should fix. >>>> >>>> That fix means .aup files are not necessarily valid XML. >>> >>> I'm not sure that's true, but I'm no XML expert. Is  etc not >>> allowed? >> >> Are you calling me a liar?! ;-) >> >> Seriously, I would not have asserted it if I didn't know for sure. I >> took Gale's sample aup file, ran it through an XML validator >> (http://www.w3schools.com/xml/xml_validator.asp) and the file failed at >> exactly that point, citing invalid character. >> >> >>> >>>> Developers, do/should we have a policy about keeping .aup as valid XML? >>>> I think we should keep it XML. >>> >>> Yes, we should keep it XML. And read what we can write, in the current >>> version. >>> >> >> Right on. >> >> Michael, does your fix accomplish that? > > I'm a bit fuzzy on it, but yes I believe it does this on the character level. > At least, it uses the same table expat uses to determine xml compatibility. > I looked up what the ampersand means for xml and it seems a bit > complicated, but we are possibly ok. > > I glanced over XMLWriter.cpp and probably there are some strings that > are not being escaped, but I think these are just names (possibly not > user input) and not attribute values (user input). > > Michael > > ------------------------------------------------------------------------------ > Free Software Download: Index, Search & Analyze Logs and other IT data in > Real-Time with Splunk. Collect, index and harness all the fast moving IT data > generated by your applications, servers and devices whether physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |