Thread: Re: [Audacity-devel] Bug 307 patch
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Gale A. <ga...@au...> - 2013-06-13 02:13:46
|
| From Henrik Agner <ha_...@ho...> | Tue, 11 Jun 2013 13:17:33 +0000 | Subject: [Audacity-devel] Bug 307 patch > I'm a new guy here, here is my first contribution to the project. > It's just a trivial P5 patch but the problem was something that bugged > me at least. > > The patch is for bug 307 and simply sets the play icon back to stopped > state, I hope it is placed at the appropriate place. Hi Henrik, I tried it on Windows. I only needed your second "toolbar->SetPlay(false);" , after wxGetApp().SetMissingAliasedFileWarningShouldShow(true); to set the Play button back to normal play after CTRL + SHIFT + I. But if I set a custom shortcut CTRL + SHIFT + O for File > Open and use it in an empty project, the Play button remains at looped. This is true with your patch or just using the second "toolbar->SetPlay(false);" and whether the uncompressed audio files warning appears or not. As per the bug comments, merely holding SHIFT changes the Play button to looped. It would be desirable IMO not to change the Play button until you press SPACE as well (so e.g. CTRL + SHIFT + Z to Undo on Linux would not as now change the Play button while you hold the shortcut). Would fixing that (if possible) also fix bug 307? PS Standard disclaimer for newcomers here - I am not a developer. Gale |