Hi!

I guess, the explanation of the commented out line of code should be in the source code. Not everyone reads mailing lists, and, also, this email can be missed, forgotten, etc. So, without this explanation, it may be pretty difficult to understand why this line was commented out.


On Fri, Dec 27, 2013 at 6:28 PM, Marco Diego Aurélio Mesquita <marcodiegomesquita@gmail.com> wrote:
Hi devs!

I'm experimenting again with AudNR. The attached patch is a simple
code improvement that I'd like to see committed. It should not change
the way AudNR behaves.

One thing: there's a small catch in the patch. It adds a commented
line of code, and this comment is there for a reason. If the line is
uncommented, AudNR changes its behavior from multi-spectral noise
gating to spectral subtraction. On some files, spectral subtraction
will be better than multi-spectral noise gating. If anybody is
interested in testing it, it is as simple as uncommenting the line and
recompiling audacity.

Now, I know it has been discussed before, but if Audacity developers accept
to add one more slider on the AudNR, it would be possible to add one
slider to smoothly select between spectral subtraction and
multi-spectral noise gating. From my tests (sorry, I can not post any
file) it is a very welcome addition to AudNR.

Testers, experimenters and restoration enthusiasts (I'm looking at you
Steve) it would be great to hear from you what do you think about the
results of comparisons between both methods. Audacity devs, if you
allow, I'm willing to add this one more slider to AudNR. It really
makes a difference.

Thanks!

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
audacity-devel mailing list
audacity-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity-devel